From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
"David S . Miller" <davem@davemloft.net>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 0/7] debugfs: Add and use debugfs_create_xul()
Date: Mon, 21 Oct 2019 16:37:35 +0200 [thread overview]
Message-ID: <20191021143742.14487-1-geert+renesas@glider.be> (raw)
Hi all,
The existing debugfs_create_ulong() function supports objects of
type "unsigned long", which are 32-bit or 64-bit depending on the
platform, in decimal form. To format objects in hexadecimal, various
debugfs_create_x*() functions exist, but all of them take fixed-size
types.
To work around this, some drivers call one of debugfs_create_x{32,64}(),
depending on the size of unsigned long.
Other driver just cast the value pointer to "u32 *" or "u64 *",
introducing portability bugs or data leaks in the process.
Hence this patch series adds a debugfs helper for "unsigned long"
objects in hexadecimal format, and converts drivers to make use of it.
It also contains two cleanups removing superfluous casts, which I added
to this series to avoid conflicts.
Thanks for your comments!
Geert Uytterhoeven (7):
debugfs: Add debugfs_create_xul() for hexadecimal unsigned long
mac80211: Use debugfs_create_xul() helper
net: caif: Fix debugfs on 64-bit platforms
mmc: atmel-mci: Fix debugfs on 64-bit platforms
mmc: atmel-mci: Remove superfluous cast in debugfs_create_u32() call
mmc: dw_mmc: Fix debugfs on 64-bit platforms
mmc: dw_mmc: Remove superfluous cast in debugfs_create_u32() call
drivers/mmc/host/atmel-mci.c | 10 +++++-----
drivers/mmc/host/dw_mmc.c | 10 +++++-----
drivers/net/caif/caif_serial.c | 4 ++--
include/linux/debugfs.h | 10 ++++++++++
net/mac80211/debugfs_sta.c | 17 +++--------------
5 files changed, 25 insertions(+), 26 deletions(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
To: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Ludovic Desroches
<ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>,
Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Nicolas Ferre
<nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>,
Alexandre Belloni
<alexandre.belloni-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>,
Jaehoon Chung
<jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"David S . Miller"
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"Rafael J . Wysocki"
<rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Geert Uytterhoeven
<geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Subject: [PATCH 0/7] debugfs: Add and use debugfs_create_xul()
Date: Mon, 21 Oct 2019 16:37:35 +0200 [thread overview]
Message-ID: <20191021143742.14487-1-geert+renesas@glider.be> (raw)
Hi all,
The existing debugfs_create_ulong() function supports objects of
type "unsigned long", which are 32-bit or 64-bit depending on the
platform, in decimal form. To format objects in hexadecimal, various
debugfs_create_x*() functions exist, but all of them take fixed-size
types.
To work around this, some drivers call one of debugfs_create_x{32,64}(),
depending on the size of unsigned long.
Other driver just cast the value pointer to "u32 *" or "u64 *",
introducing portability bugs or data leaks in the process.
Hence this patch series adds a debugfs helper for "unsigned long"
objects in hexadecimal format, and converts drivers to make use of it.
It also contains two cleanups removing superfluous casts, which I added
to this series to avoid conflicts.
Thanks for your comments!
Geert Uytterhoeven (7):
debugfs: Add debugfs_create_xul() for hexadecimal unsigned long
mac80211: Use debugfs_create_xul() helper
net: caif: Fix debugfs on 64-bit platforms
mmc: atmel-mci: Fix debugfs on 64-bit platforms
mmc: atmel-mci: Remove superfluous cast in debugfs_create_u32() call
mmc: dw_mmc: Fix debugfs on 64-bit platforms
mmc: dw_mmc: Remove superfluous cast in debugfs_create_u32() call
drivers/mmc/host/atmel-mci.c | 10 +++++-----
drivers/mmc/host/dw_mmc.c | 10 +++++-----
drivers/net/caif/caif_serial.c | 4 ++--
include/linux/debugfs.h | 10 ++++++++++
net/mac80211/debugfs_sta.c | 17 +++--------------
5 files changed, 25 insertions(+), 26 deletions(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
"David S . Miller" <davem@davemloft.net>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] debugfs: Add and use debugfs_create_xul()
Date: Mon, 21 Oct 2019 16:37:35 +0200 [thread overview]
Message-ID: <20191021143742.14487-1-geert+renesas@glider.be> (raw)
Hi all,
The existing debugfs_create_ulong() function supports objects of
type "unsigned long", which are 32-bit or 64-bit depending on the
platform, in decimal form. To format objects in hexadecimal, various
debugfs_create_x*() functions exist, but all of them take fixed-size
types.
To work around this, some drivers call one of debugfs_create_x{32,64}(),
depending on the size of unsigned long.
Other driver just cast the value pointer to "u32 *" or "u64 *",
introducing portability bugs or data leaks in the process.
Hence this patch series adds a debugfs helper for "unsigned long"
objects in hexadecimal format, and converts drivers to make use of it.
It also contains two cleanups removing superfluous casts, which I added
to this series to avoid conflicts.
Thanks for your comments!
Geert Uytterhoeven (7):
debugfs: Add debugfs_create_xul() for hexadecimal unsigned long
mac80211: Use debugfs_create_xul() helper
net: caif: Fix debugfs on 64-bit platforms
mmc: atmel-mci: Fix debugfs on 64-bit platforms
mmc: atmel-mci: Remove superfluous cast in debugfs_create_u32() call
mmc: dw_mmc: Fix debugfs on 64-bit platforms
mmc: dw_mmc: Remove superfluous cast in debugfs_create_u32() call
drivers/mmc/host/atmel-mci.c | 10 +++++-----
drivers/mmc/host/dw_mmc.c | 10 +++++-----
drivers/net/caif/caif_serial.c | 4 ++--
include/linux/debugfs.h | 10 ++++++++++
net/mac80211/debugfs_sta.c | 17 +++--------------
5 files changed, 25 insertions(+), 26 deletions(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-10-21 14:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 14:37 Geert Uytterhoeven [this message]
2019-10-21 14:37 ` [PATCH 0/7] debugfs: Add and use debugfs_create_xul() Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 1/7] debugfs: Add debugfs_create_xul() for hexadecimal unsigned long Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:45 ` Greg Kroah-Hartman
2019-10-21 14:45 ` Greg Kroah-Hartman
2019-10-21 14:59 ` Geert Uytterhoeven
2019-10-21 14:59 ` Geert Uytterhoeven
2019-10-21 15:37 ` Joe Perches
2019-10-21 15:37 ` Joe Perches
2019-10-22 8:03 ` Geert Uytterhoeven
2019-10-22 8:03 ` Geert Uytterhoeven
2019-10-22 9:07 ` Joe Perches
2019-10-22 9:07 ` Joe Perches
2019-10-22 17:35 ` Greg Kroah-Hartman
2019-10-22 17:35 ` Greg Kroah-Hartman
2019-10-21 14:37 ` [PATCH 2/7] mac80211: Use debugfs_create_xul() helper Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 3/7] net: caif: Fix debugfs on 64-bit platforms Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 4/7] mmc: atmel-mci: " Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 5/7] mmc: atmel-mci: Remove superfluous cast in debugfs_create_u32() call Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 6/7] mmc: dw_mmc: Fix debugfs on 64-bit platforms Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 7/7] mmc: dw_mmc: Remove superfluous cast in debugfs_create_u32() call Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 15:20 ` [PATCH 0/7] debugfs: Add and use debugfs_create_xul() Ulf Hansson
2019-10-21 15:20 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021143742.14487-1-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=alexandre.belloni@bootlin.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jh80.chung@samsung.com \
--cc=johannes@sipsolutions.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=rafael@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.