All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 7/7] mmc: dw_mmc: Remove superfluous cast in debugfs_create_u32() call
Date: Mon, 21 Oct 2019 16:37:42 +0200	[thread overview]
Message-ID: <20191021143742.14487-8-geert+renesas@glider.be> (raw)
In-Reply-To: <20191021143742.14487-1-geert+renesas@glider.be>

"dw_mci.state" is an enum, which is compatible with u32, so there is no
need to cast its address, preventing further compiler checks.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/mmc/host/dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index b4c4a9cd6365f122..fc9d4d000f97e434 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -176,7 +176,7 @@ static void dw_mci_init_debugfs(struct dw_mci_slot *slot)
 
 	debugfs_create_file("regs", S_IRUSR, root, host, &dw_mci_regs_fops);
 	debugfs_create_file("req", S_IRUSR, root, slot, &dw_mci_req_fops);
-	debugfs_create_u32("state", S_IRUSR, root, (u32 *)&host->state);
+	debugfs_create_u32("state", S_IRUSR, root, &host->state);
 	debugfs_create_xul("pending_events", S_IRUSR, root,
 			   &host->pending_events);
 	debugfs_create_xul("completed_events", S_IRUSR, root,
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] mmc: dw_mmc: Remove superfluous cast in debugfs_create_u32() call
Date: Mon, 21 Oct 2019 16:37:42 +0200	[thread overview]
Message-ID: <20191021143742.14487-8-geert+renesas@glider.be> (raw)
In-Reply-To: <20191021143742.14487-1-geert+renesas@glider.be>

"dw_mci.state" is an enum, which is compatible with u32, so there is no
need to cast its address, preventing further compiler checks.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/mmc/host/dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index b4c4a9cd6365f122..fc9d4d000f97e434 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -176,7 +176,7 @@ static void dw_mci_init_debugfs(struct dw_mci_slot *slot)
 
 	debugfs_create_file("regs", S_IRUSR, root, host, &dw_mci_regs_fops);
 	debugfs_create_file("req", S_IRUSR, root, slot, &dw_mci_req_fops);
-	debugfs_create_u32("state", S_IRUSR, root, (u32 *)&host->state);
+	debugfs_create_u32("state", S_IRUSR, root, &host->state);
 	debugfs_create_xul("pending_events", S_IRUSR, root,
 			   &host->pending_events);
 	debugfs_create_xul("completed_events", S_IRUSR, root,
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-10-21 14:38 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 14:37 [PATCH 0/7] debugfs: Add and use debugfs_create_xul() Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 1/7] debugfs: Add debugfs_create_xul() for hexadecimal unsigned long Geert Uytterhoeven
2019-10-21 14:37   ` Geert Uytterhoeven
2019-10-21 14:45   ` Greg Kroah-Hartman
2019-10-21 14:45     ` Greg Kroah-Hartman
2019-10-21 14:59     ` Geert Uytterhoeven
2019-10-21 14:59       ` Geert Uytterhoeven
2019-10-21 15:37   ` Joe Perches
2019-10-21 15:37     ` Joe Perches
2019-10-22  8:03     ` Geert Uytterhoeven
2019-10-22  8:03       ` Geert Uytterhoeven
2019-10-22  9:07       ` Joe Perches
2019-10-22  9:07         ` Joe Perches
2019-10-22 17:35         ` Greg Kroah-Hartman
2019-10-22 17:35           ` Greg Kroah-Hartman
2019-10-21 14:37 ` [PATCH 2/7] mac80211: Use debugfs_create_xul() helper Geert Uytterhoeven
2019-10-21 14:37   ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 3/7] net: caif: Fix debugfs on 64-bit platforms Geert Uytterhoeven
2019-10-21 14:37   ` Geert Uytterhoeven
2019-10-21 14:37   ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 4/7] mmc: atmel-mci: " Geert Uytterhoeven
2019-10-21 14:37   ` Geert Uytterhoeven
2019-10-21 14:37   ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 5/7] mmc: atmel-mci: Remove superfluous cast in debugfs_create_u32() call Geert Uytterhoeven
2019-10-21 14:37   ` Geert Uytterhoeven
2019-10-21 14:37 ` [PATCH 6/7] mmc: dw_mmc: Fix debugfs on 64-bit platforms Geert Uytterhoeven
2019-10-21 14:37   ` Geert Uytterhoeven
2019-10-21 14:37 ` Geert Uytterhoeven [this message]
2019-10-21 14:37   ` [PATCH 7/7] mmc: dw_mmc: Remove superfluous cast in debugfs_create_u32() call Geert Uytterhoeven
2019-10-21 15:20 ` [PATCH 0/7] debugfs: Add and use debugfs_create_xul() Ulf Hansson
2019-10-21 15:20   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191021143742.14487-8-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=alexandre.belloni@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jh80.chung@samsung.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=rafael@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.