All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: dri-devel@lists.freedesktop.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Yannick Fertre <yannick.fertre@st.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Xinwei Kong <kong.kongxinwei@hisilicon.com>,
	Xinliang Liu <z.liuxinliang@hisilicon.com>,
	linux-rockchip@lists.infradead.org, Chen-Yu Tsai <wens@csie.org>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	"James (Qian) Wang" <james.qian.wang@arm.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Chen Feng <puck.chen@hisilicon.com>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sean Paul <sean@poorly.run>,
	linux-arm-kernel@lists.infradead.org,
	Philippe Cornu <philippe.cornu@st.com>,
	Vincent Abriou <vincent.abriou@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Rongrong Zou <zourongrong@>
Subject: [PATCH 1/6] drm/kirin: Use DRM_GEM_CMA_VMAP_DRIVER_OPS
Date: Mon, 21 Oct 2019 16:45:45 -0500	[thread overview]
Message-ID: <20191021214550.1461-2-robh@kernel.org> (raw)
In-Reply-To: <20191021214550.1461-1-robh@kernel.org>

drm_gem_cma_dumb_create_internal() is not supposed to be used for
.dumb_create directly. drm_gem_cma_dumb_create() should be used instead.
If we do that, we might as well convert over to using
DRM_GEM_CMA_VMAP_DRIVER_OPS instead.

Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index 73cd28a6ea07..490537a1d035 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -941,16 +941,7 @@ DEFINE_DRM_GEM_CMA_FOPS(ade_fops);
 static struct drm_driver ade_driver = {
 	.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
 	.fops = &ade_fops,
-	.gem_free_object_unlocked = drm_gem_cma_free_object,
-	.gem_vm_ops = &drm_gem_cma_vm_ops,
-	.dumb_create = drm_gem_cma_dumb_create_internal,
-	.prime_handle_to_fd	= drm_gem_prime_handle_to_fd,
-	.prime_fd_to_handle	= drm_gem_prime_fd_to_handle,
-	.gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
-	.gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
-	.gem_prime_vmap = drm_gem_cma_prime_vmap,
-	.gem_prime_vunmap = drm_gem_cma_prime_vunmap,
-	.gem_prime_mmap = drm_gem_cma_prime_mmap,
+	DRM_GEM_CMA_VMAP_DRIVER_OPS,
 
 	.name = "kirin",
 	.desc = "Hisilicon Kirin620 SoC DRM Driver",
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: dri-devel@lists.freedesktop.org
Cc: "Heiko Stübner" <heiko@sntech.de>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"David Airlie" <airlied@linux.ie>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
	"Yannick Fertre" <yannick.fertre@st.com>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
	"Xinliang Liu" <z.liuxinliang@hisilicon.com>,
	linux-rockchip@lists.infradead.org,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"James (Qian) Wang" <james.qian.wang@arm.com>,
	"CK Hu" <ck.hu@mediatek.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	"Chen Feng" <puck.chen@hisilicon.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	linux-mediatek@lists.infradead.org,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>, "Sean Paul" <sean@poorly.run>,
	linux-arm-kernel@lists.infradead.org,
	"Philippe Cornu" <philippe.cornu@st.com>,
	"Vincent Abriou" <vincent.abriou@st.com>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Rongrong Zou" <zourongrong@gmail.com>
Subject: [PATCH 1/6] drm/kirin: Use DRM_GEM_CMA_VMAP_DRIVER_OPS
Date: Mon, 21 Oct 2019 16:45:45 -0500	[thread overview]
Message-ID: <20191021214550.1461-2-robh@kernel.org> (raw)
In-Reply-To: <20191021214550.1461-1-robh@kernel.org>

drm_gem_cma_dumb_create_internal() is not supposed to be used for
.dumb_create directly. drm_gem_cma_dumb_create() should be used instead.
If we do that, we might as well convert over to using
DRM_GEM_CMA_VMAP_DRIVER_OPS instead.

Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index 73cd28a6ea07..490537a1d035 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -941,16 +941,7 @@ DEFINE_DRM_GEM_CMA_FOPS(ade_fops);
 static struct drm_driver ade_driver = {
 	.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
 	.fops = &ade_fops,
-	.gem_free_object_unlocked = drm_gem_cma_free_object,
-	.gem_vm_ops = &drm_gem_cma_vm_ops,
-	.dumb_create = drm_gem_cma_dumb_create_internal,
-	.prime_handle_to_fd	= drm_gem_prime_handle_to_fd,
-	.prime_fd_to_handle	= drm_gem_prime_fd_to_handle,
-	.gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
-	.gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
-	.gem_prime_vmap = drm_gem_cma_prime_vmap,
-	.gem_prime_vunmap = drm_gem_cma_prime_vunmap,
-	.gem_prime_mmap = drm_gem_cma_prime_mmap,
+	DRM_GEM_CMA_VMAP_DRIVER_OPS,
 
 	.name = "kirin",
 	.desc = "Hisilicon Kirin620 SoC DRM Driver",
-- 
2.20.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: dri-devel@lists.freedesktop.org
Cc: "Heiko Stübner" <heiko@sntech.de>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"David Airlie" <airlied@linux.ie>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
	"Yannick Fertre" <yannick.fertre@st.com>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
	"Xinliang Liu" <z.liuxinliang@hisilicon.com>,
	linux-rockchip@lists.infradead.org,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"James (Qian) Wang" <james.qian.wang@arm.com>,
	"CK Hu" <ck.hu@mediatek.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	"Chen Feng" <puck.chen@hisilicon.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	linux-mediatek@lists.infradead.org,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>, "Sean Paul" <sean@poorly.run>,
	linux-arm-kernel@lists.infradead.org,
	"Philippe Cornu" <philippe.cornu@st.com>,
	"Vincent Abriou" <vincent.abriou@st.com>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Rongrong Zou" <zourongrong@gmail.com>
Subject: [PATCH 1/6] drm/kirin: Use DRM_GEM_CMA_VMAP_DRIVER_OPS
Date: Mon, 21 Oct 2019 16:45:45 -0500	[thread overview]
Message-ID: <20191021214550.1461-2-robh@kernel.org> (raw)
In-Reply-To: <20191021214550.1461-1-robh@kernel.org>

drm_gem_cma_dumb_create_internal() is not supposed to be used for
.dumb_create directly. drm_gem_cma_dumb_create() should be used instead.
If we do that, we might as well convert over to using
DRM_GEM_CMA_VMAP_DRIVER_OPS instead.

Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index 73cd28a6ea07..490537a1d035 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -941,16 +941,7 @@ DEFINE_DRM_GEM_CMA_FOPS(ade_fops);
 static struct drm_driver ade_driver = {
 	.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
 	.fops = &ade_fops,
-	.gem_free_object_unlocked = drm_gem_cma_free_object,
-	.gem_vm_ops = &drm_gem_cma_vm_ops,
-	.dumb_create = drm_gem_cma_dumb_create_internal,
-	.prime_handle_to_fd	= drm_gem_prime_handle_to_fd,
-	.prime_fd_to_handle	= drm_gem_prime_fd_to_handle,
-	.gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
-	.gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
-	.gem_prime_vmap = drm_gem_cma_prime_vmap,
-	.gem_prime_vunmap = drm_gem_cma_prime_vunmap,
-	.gem_prime_mmap = drm_gem_cma_prime_mmap,
+	DRM_GEM_CMA_VMAP_DRIVER_OPS,
 
 	.name = "kirin",
 	.desc = "Hisilicon Kirin620 SoC DRM Driver",
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-21 21:45 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 21:45 [PATCH 0/6] drm: Support CMA per allocation kernel mappings Rob Herring
2019-10-21 21:45 ` Rob Herring
2019-10-21 21:45 ` Rob Herring
2019-10-21 21:45 ` Rob Herring [this message]
2019-10-21 21:45   ` [PATCH 1/6] drm/kirin: Use DRM_GEM_CMA_VMAP_DRIVER_OPS Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-21 21:45 ` [PATCH 2/6] drm: Introduce DRM_MODE_DUMB_KERNEL_MAP flag Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-22 11:14   ` Laurent Pinchart
2019-10-22 11:14     ` Laurent Pinchart
2019-10-22 11:14     ` Laurent Pinchart
2019-10-22 12:42     ` Rob Herring
2019-10-22 12:42       ` Rob Herring
2019-10-22 12:42       ` Rob Herring
2019-10-23 14:28       ` Laurent Pinchart
2019-10-23 14:28         ` Laurent Pinchart
2019-10-23 14:28         ` Laurent Pinchart
2019-10-23 14:28         ` Laurent Pinchart
2019-10-23 17:03         ` Rob Herring
2019-10-23 17:03           ` Rob Herring
2019-10-23 17:03           ` Rob Herring
2019-10-23 17:03           ` Rob Herring
2019-10-21 21:45 ` [PATCH 3/6] drm/cma-helper: Use the dma_*_attr API variant Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-22  1:01   ` kbuild test robot
2019-10-22  1:01     ` kbuild test robot
2019-10-22  1:01     ` kbuild test robot
2019-10-22  1:01     ` kbuild test robot
2019-10-22 11:18   ` Laurent Pinchart
2019-10-22 11:18     ` Laurent Pinchart
2019-10-22 11:18     ` Laurent Pinchart
2019-10-21 21:45 ` [PATCH 4/6] drm/cma-helper: Support DRM_MODE_DUMB_KERNEL_MAP flag Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-22  6:13   ` james qian wang (Arm Technology China)
2019-10-22  6:13     ` james qian wang (Arm Technology China)
2019-10-22  6:13     ` james qian wang (Arm Technology China)
2019-10-22  6:13     ` james qian wang (Arm Technology China)
2019-10-22  6:13     ` james qian wang (Arm Technology China)
2019-10-22  7:50   ` Neil Armstrong
2019-10-22  7:50     ` Neil Armstrong
2019-10-22  7:50     ` Neil Armstrong
2019-10-22  7:50     ` Neil Armstrong
2019-10-22  7:50     ` Neil Armstrong
2019-10-22 11:30   ` Laurent Pinchart
2019-10-22 11:30     ` Laurent Pinchart
2019-10-22 11:30     ` Laurent Pinchart
2019-10-22 11:30     ` Laurent Pinchart
2019-10-22 11:30     ` Laurent Pinchart
2019-10-22 11:40     ` Geert Uytterhoeven
2019-10-22 11:40       ` Geert Uytterhoeven
2019-10-22 11:40       ` Geert Uytterhoeven
2019-10-22 11:40       ` Geert Uytterhoeven
2019-10-22 11:40       ` Geert Uytterhoeven
2019-10-22 19:52       ` Rob Herring
2019-10-22 19:52         ` Rob Herring
2019-10-22 19:52         ` Rob Herring
2019-10-22 19:52         ` Rob Herring
2019-10-22 19:52         ` Rob Herring
2019-10-22 20:02     ` Rob Herring
2019-10-22 20:02       ` Rob Herring
2019-10-22 20:02       ` Rob Herring
2019-10-22 20:02       ` Rob Herring
2019-10-22 20:02       ` Rob Herring
2019-10-23 14:27       ` Laurent Pinchart
2019-10-23 14:27         ` Laurent Pinchart
2019-10-23 14:27         ` Laurent Pinchart
2019-10-23 14:27         ` Laurent Pinchart
2019-10-23 14:27         ` Laurent Pinchart
2019-10-23 14:27         ` Laurent Pinchart
2019-10-21 21:45 ` [PATCH 5/6] drm/mediatek: Convert to use CMA helpers Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-22 17:07   ` Matthias Brugger
2019-10-22 17:07     ` Matthias Brugger
2019-10-22 17:07     ` Matthias Brugger
2019-10-23 17:42     ` Rob Herring
2019-10-23 17:42       ` Rob Herring
2019-10-23 17:42       ` Rob Herring
2019-10-23 17:42       ` Rob Herring
2019-10-23 21:06       ` CK Hu
2019-10-23 21:06         ` CK Hu
2019-10-23 21:06         ` CK Hu
2019-10-23 21:06         ` CK Hu
2019-10-23 22:56         ` Rob Herring
2019-10-23 22:56           ` Rob Herring
2019-10-23 22:56           ` Rob Herring
2019-10-23 22:56           ` Rob Herring
2019-10-24  7:02           ` CK Hu
2019-10-24  7:02             ` CK Hu
2019-10-24  7:02             ` CK Hu
2019-10-24  7:02             ` CK Hu
2019-12-17  1:12             ` Laurent Pinchart
2019-12-17  1:12               ` Laurent Pinchart
2019-12-17  1:12               ` Laurent Pinchart
2019-12-17  1:12               ` Laurent Pinchart
2019-10-21 21:45 ` [PATCH 6/6] drm/rockchip: Convert to use generic fbdev emulation Rob Herring
2019-10-21 21:45   ` Rob Herring
2019-10-21 21:45   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191021214550.1461-2-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@linux.ie \
    --cc=alexandre.torgue@st.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=james.qian.wang@arm.com \
    --cc=khilman@baylibre.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=liviu.dudau@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=narmstrong@baylibre.com \
    --cc=philippe.cornu@st.com \
    --cc=puck.chen@hisilicon.com \
    --cc=sean@poorly.run \
    --cc=vincent.abriou@st.com \
    --cc=wens@csie.org \
    --cc=yannick.fertre@st.com \
    --cc=z.liuxinliang@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.