All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <gaoxiang25@huawei.com>
To: Li Guifu <bluce.liguifu@huawei.com>, <linux-erofs@lists.ozlabs.org>
Cc: Yann Collet <yann.collet.73@gmail.com>
Subject: [PATCH] erofs-utils: document more known matters to README
Date: Wed, 23 Oct 2019 17:20:31 +0800	[thread overview]
Message-ID: <20191023092031.211186-1-gaoxiang25@huawei.com> (raw)

We are about to release erofs-utils 1.0, add more words
to README on known fixed issues about lz4 upstream library.

Cc: Li Guifu <bluce.liguifu@huawei.com>
Cc: Chao Yu <yuchao0@huawei.com>
Cc: Yann Collet <yann.collet.73@gmail.com>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
---
 README | 41 ++++++++++++++++++++++++++++++++++++++---
 1 file changed, 38 insertions(+), 3 deletions(-)

diff --git a/README b/README
index 9e65ad015a0b..60b8eed6c1d3 100644
--- a/README
+++ b/README
@@ -32,7 +32,9 @@ To build you can run the following commands in order:
 	$ ./configure
 	$ make
 
-mkfs.erofs binary will be generated under mkfs folder.
+mkfs.erofs binary will be generated under mkfs folder. There are still
+some issues which affect the stability of LZ4_compress_destSize()
+* they have impacts on lz4 only rather than lz4HC * [3].
 
 How to build for lz4-1.8.0~1.8.3
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -45,8 +47,8 @@ On Fedora, static lz4 can be installed using:
 
 	yum install lz4-static.x86_64
 
-However, it's not recommended to use those versions since there was a bug
-in these compressors, see [2] as well.
+However, it's not recommended to use those versions since there were bugs
+in these compressors, see [2] [3] as well.
 
 How to generate erofs images
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -68,6 +70,14 @@ add "-E legacy-compress" to the command line, e.g.
 
  $ mkfs.erofs -E legacy-compress -zlz4hc foo.erofs.img foo/
 
+
+Known issues
+~~~~~~~~~~~~
+
+1. LZ4HC cannot compress long zeroed buffer properly with
+   LZ4_compress_HC_destSize()
+   https://github.com/lz4/lz4/issues/784
+
 Obsoleted erofs.mkfs
 ~~~~~~~~~~~~~~~~~~~~
 
@@ -109,3 +119,28 @@ Comments
     For more details, please refer to
     https://github.com/lz4/lz4/commit/660d21272e4c8a0f49db5fc1e6853f08713dff82
 
+[3] There are many crash fixes merged to lz4 1.9.2 for LZ4_compress_destSize(),
+    and I once ran into some crashs due to those issues.
+    * Again lz4HC is not effected for this section. *
+
+    [LZ4_compress_destSize] Allow 2 more bytes of match length
+    https://github.com/lz4/lz4/commit/690009e2c2f9e5dcb0d40e7c0c40610ce6006eda
+
+    [LZ4_compress_destSize] Fix rare data corruption bug
+    https://github.com/lz4/lz4/commit/6bc6f836a18d1f8fd05c8fc2b42f1d800bc25de1
+
+    [LZ4_compress_destSize] Fix overflow condition
+    https://github.com/lz4/lz4/commit/13a2d9e34ffc4170720ce417c73e396d0ac1471a
+
+    [LZ4_compress_destSize] Fix off-by-one error in fix
+    https://github.com/lz4/lz4/commit/7c32101c655d93b61fc212dcd512b87119dd7333
+
+    [LZ4_compress_destSize] Fix off-by-one error
+    https://github.com/lz4/lz4/commit/d7cad81093cd805110291f84d64d385557d0ffba
+
+    since upstream lz4 doesn't have stable branch for old versions, it's
+    preferred to use latest upstream lz4 library (although some regressions
+    could happen since new features are also introduced to latest upstream
+    version as well) or backport all stable bugfixes to old stable versions,
+    e.g. our unoffical lz4 fork: https://github.com/erofs/lz4
+
-- 
2.17.1


             reply	other threads:[~2019-10-23  9:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23  9:20 Gao Xiang [this message]
2019-10-23 15:37 ` [PATCH] erofs-utils: document more known matters to README Li Guifu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023092031.211186-1-gaoxiang25@huawei.com \
    --to=gaoxiang25@huawei.com \
    --cc=bluce.liguifu@huawei.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=yann.collet.73@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.