All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Ma <aaron.ma@canonical.com>
To: perex@perex.cz, tiwai@suse.com, kailang@realtek.com,
	hui.wang@canonical.com, alsa-devel@alsa-project.org,
	aaron.ma@canonical.com, linux-kernel@vger.kernel.org
Subject: [PATCH v3] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
Date: Thu, 24 Oct 2019 19:44:39 +0800	[thread overview]
Message-ID: <20191024114439.31522-1-aaron.ma@canonical.com> (raw)
In-Reply-To: <20191022153855.14368-1-aaron.ma@canonical.com>

These 2 ThinkCentres installed a new realtek codec ID 0x623,
it has 2 front mics with the same location on pin 0x18 and 0x19.

Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
location to right, then pulseaudio can handle them.
One "Front Mic" and one "Mic" will be shown, and audio output works
fine.

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a0c237cc13d4..80f66ba85f87 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7221,6 +7221,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Aaron Ma <aaron.ma@canonical.com>
To: perex@perex.cz, tiwai@suse.com, kailang@realtek.com,
	hui.wang@canonical.com, alsa-devel@alsa-project.org,
	aaron.ma@canonical.com, linux-kernel@vger.kernel.org
Subject: [alsa-devel] [PATCH v3] ALSA: hda/realtek - Fix 2 front mics of codec 0x623
Date: Thu, 24 Oct 2019 19:44:39 +0800	[thread overview]
Message-ID: <20191024114439.31522-1-aaron.ma@canonical.com> (raw)
In-Reply-To: <20191022153855.14368-1-aaron.ma@canonical.com>

These 2 ThinkCentres installed a new realtek codec ID 0x623,
it has 2 front mics with the same location on pin 0x18 and 0x19.

Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
location to right, then pulseaudio can handle them.
One "Front Mic" and one "Mic" will be shown, and audio output works
fine.

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a0c237cc13d4..80f66ba85f87 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7221,6 +7221,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
-- 
2.17.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-10-24 11:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22 15:38 [PATCH] ALSA: hda/realtek - Fix 2 front mics of codec 0x623 Aaron Ma
2019-10-22 15:38 ` [alsa-devel] " Aaron Ma
2019-10-22 16:08 ` Takashi Iwai
2019-10-22 16:08   ` [alsa-devel] " Takashi Iwai
2019-10-23  8:44   ` Kailang
2019-10-23  8:44     ` [alsa-devel] " Kailang
2019-10-23 10:06     ` Aaron Ma
2019-10-23 10:06       ` [alsa-devel] " Aaron Ma
2019-10-24  7:20       ` Kailang
2019-10-24  7:20         ` [alsa-devel] " Kailang
2019-10-24 10:35         ` Takashi Iwai
2019-10-24 10:35           ` [alsa-devel] " Takashi Iwai
2019-10-24 10:54           ` Aaron Ma
2019-10-24 10:54             ` [alsa-devel] " Aaron Ma
2019-10-24 11:18 ` [PATCH v2] " Aaron Ma
2019-10-24 11:18   ` [alsa-devel] " Aaron Ma
2019-10-24 11:30   ` Hui Wang
2019-10-24 11:30     ` [alsa-devel] " Hui Wang
2019-10-24 11:44 ` Aaron Ma [this message]
2019-10-24 11:44   ` [alsa-devel] [PATCH v3] " Aaron Ma
2019-10-24 12:23   ` Takashi Iwai
2019-10-24 12:23     ` [alsa-devel] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024114439.31522-1-aaron.ma@canonical.com \
    --to=aaron.ma@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=hui.wang@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.