All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 10/32] drm/tegra: dp: Read eDP version from DPCD
Date: Thu, 24 Oct 2019 18:45:12 +0200	[thread overview]
Message-ID: <20191024164534.132764-11-thierry.reding@gmail.com> (raw)
In-Reply-To: <20191024164534.132764-1-thierry.reding@gmail.com>

From: Thierry Reding <treding@nvidia.com>

If the sink supports eDP, read the eDP revision from it's DPCD.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/tegra/dp.c | 18 ++++++++++++++++--
 drivers/gpu/drm/tegra/dp.h |  2 ++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tegra/dp.c b/drivers/gpu/drm/tegra/dp.c
index 1f48c2190e3b..2be0a47ecbec 100644
--- a/drivers/gpu/drm/tegra/dp.c
+++ b/drivers/gpu/drm/tegra/dp.c
@@ -5,9 +5,12 @@
  */
 
 #include <drm/drm_dp_helper.h>
+#include <drm/drm_print.h>
 
 #include "dp.h"
 
+static const u8 drm_dp_edp_revisions[] = { 0x11, 0x12, 0x13, 0x14 };
+
 static void drm_dp_link_caps_reset(struct drm_dp_link_caps *caps)
 {
 	caps->enhanced_framing = false;
@@ -37,6 +40,7 @@ static void drm_dp_link_reset(struct drm_dp_link *link)
 	link->max_lanes = 0;
 
 	drm_dp_link_caps_reset(&link->caps);
+	link->edp = 0;
 
 	link->rate = 0;
 	link->lanes = 0;
@@ -55,7 +59,7 @@ static void drm_dp_link_reset(struct drm_dp_link *link)
  */
 int drm_dp_link_probe(struct drm_dp_aux *aux, struct drm_dp_link *link)
 {
-	u8 dpcd[DP_RECEIVER_CAP_SIZE];
+	u8 dpcd[DP_RECEIVER_CAP_SIZE], value;
 	int err;
 
 	drm_dp_link_reset(link);
@@ -73,9 +77,19 @@ int drm_dp_link_probe(struct drm_dp_aux *aux, struct drm_dp_link *link)
 	link->caps.fast_training = drm_dp_fast_training_cap(dpcd);
 	link->caps.channel_coding = drm_dp_channel_coding_supported(dpcd);
 
-	if (drm_dp_alternate_scrambler_reset_cap(dpcd))
+	if (drm_dp_alternate_scrambler_reset_cap(dpcd)) {
 		link->caps.alternate_scrambler_reset = true;
 
+		err = drm_dp_dpcd_readb(aux, DP_EDP_DPCD_REV, &value);
+		if (err < 0)
+			return err;
+
+		if (value >= ARRAY_SIZE(drm_dp_edp_revisions))
+			DRM_ERROR("unsupported eDP version: %02x\n", value);
+		else
+			link->edp = drm_dp_edp_revisions[value];
+	}
+
 	link->rate = link->max_rate;
 	link->lanes = link->max_lanes;
 
diff --git a/drivers/gpu/drm/tegra/dp.h b/drivers/gpu/drm/tegra/dp.h
index 45e8ff18ab6a..681cbd0a0094 100644
--- a/drivers/gpu/drm/tegra/dp.h
+++ b/drivers/gpu/drm/tegra/dp.h
@@ -60,6 +60,7 @@ void drm_dp_link_caps_copy(struct drm_dp_link_caps *dest,
  * @max_rate: maximum clock rate supported on the link
  * @max_lanes: maximum number of lanes supported on the link
  * @caps: capabilities supported on the link (see &drm_dp_link_caps)
+ * @edp: eDP revision (0x11: eDP 1.1, 0x12: eDP 1.2, ...)
  * @rate: currently configured link rate
  * @lanes: currently configured number of lanes
  */
@@ -69,6 +70,7 @@ struct drm_dp_link {
 	unsigned int max_lanes;
 
 	struct drm_dp_link_caps caps;
+	unsigned char edp;
 
 	unsigned int rate;
 	unsigned int lanes;
-- 
2.23.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-10-24 16:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 16:45 [PATCH 00/32] drm/tegra: Add DisplayPort support Thierry Reding
2019-10-24 16:45 ` [PATCH 01/32] drm/tegra: Add missing kerneldoc for struct drm_dp_link Thierry Reding
2019-10-24 16:45 ` [PATCH 02/32] drm/tegra: dp: Add drm_dp_link_reset() implementation Thierry Reding
2019-10-24 16:45 ` [PATCH 03/32] drm/tegra: dp: Track link capabilities alongside settings Thierry Reding
2019-10-24 16:45 ` [PATCH 04/32] drm/tegra: dp: Turn link capabilities into booleans Thierry Reding
2019-10-24 16:45 ` [PATCH 05/32] drm/tegra: dp: Probe link using existing parsing helpers Thierry Reding
2019-10-24 16:45 ` [PATCH 06/32] drm/tegra: dp: Read fast training capability from link Thierry Reding
2019-10-24 16:45 ` [PATCH 07/32] drm/tegra: dp: Read TPS3 capability from sink Thierry Reding
2019-10-24 16:45 ` [PATCH 08/32] drm/tegra: dp: Read channel coding " Thierry Reding
2019-10-24 16:45 ` [PATCH 09/32] drm/tegra: dp: Read alternate scrambler reset " Thierry Reding
2019-10-24 16:45 ` Thierry Reding [this message]
2019-10-24 16:45 ` [PATCH 11/32] drm/tegra: dp: Read AUX read interval from DPCD Thierry Reding
2019-10-24 16:45 ` [PATCH 12/32] drm/tegra: dp: Set channel coding on link configuration Thierry Reding
2019-10-24 16:45 ` [PATCH 13/32] drm/tegra: dp: Enable alternate scrambler reset when supported Thierry Reding
2019-10-24 16:45 ` [PATCH 14/32] drm/tegra: dp: Add drm_dp_link_choose() helper Thierry Reding
2019-10-24 16:45 ` [PATCH 15/32] drm/tegra: dp: Add support for eDP link rates Thierry Reding
2019-10-24 16:45 ` [PATCH 16/32] drm/tegra: dp: Add DisplayPort link training helper Thierry Reding
2019-10-24 16:45 ` [PATCH 17/32] drm/tegra: sor: Use DP link training helpers Thierry Reding
2019-10-24 16:45 ` [PATCH 18/32] drm/tegra: sor: Hook up I2C-over-AUX to output Thierry Reding
2019-10-24 16:45 ` [PATCH 19/32] drm/tegra: sor: Stabilize eDP Thierry Reding
2019-10-24 16:45 ` [PATCH 20/32] drm/tegra: sor: Filter eDP rates Thierry Reding
2019-10-24 16:45 ` [PATCH 21/32] drm/tegra: sor: Add DisplayPort support Thierry Reding
2019-10-24 16:45 ` [PATCH 22/32] drm/tegra: sor: Remove tegra186-sor1 support Thierry Reding
2019-10-24 16:45 ` [PATCH 23/32] drm/tegra: sor: Use correct SOR index on Tegra210 Thierry Reding
2019-10-24 16:45 ` [PATCH 24/32] drm/tegra: sor: Implement pad clock for all SOR instances Thierry Reding
2019-10-24 16:45 ` [PATCH 25/32] drm/tegra: sor: Deduplicate connector type detection code Thierry Reding
2019-10-24 16:45 ` [PATCH 26/32] drm/tegra: sor: Support DisplayPort on Tegra194 Thierry Reding
2019-10-24 16:45 ` [PATCH 27/32] drm/tegra: sor: Unify clock setup for eDP, HDMI and DP Thierry Reding
2019-10-24 16:45 ` [PATCH 28/32] drm/tegra: sor: Use correct I/O pad for DP Thierry Reding
2019-10-24 16:45 ` [PATCH 29/32] drm/tegra: sor: Unify eDP and DP support Thierry Reding
2019-10-24 16:45 ` [PATCH 30/32] drm/tegra: sor: Avoid timeouts on unplug events Thierry Reding
2019-10-24 16:45 ` [PATCH 31/32] drm/tegra: sor: Extract common audio enabling code Thierry Reding
2019-10-24 16:45 ` [PATCH 32/32] drm/tegra: sor: Introduce audio enable/disable callbacks Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024164534.132764-11-thierry.reding@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-tegra@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.