All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/4] drm/i915: do not set MOCS control values on dgfx
Date: Thu, 24 Oct 2019 12:51:21 -0700	[thread overview]
Message-ID: <20191024195122.22877-3-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20191024195122.22877-1-lucas.demarchi@intel.com>

On dgfx there's no LLC and eDRAM control table. Since now this
also means the device has global MOCS, just return early on the
initialization function.

L3 settings still apply and still need to be tweaked.

Bspec: 45101

Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_mocs.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
index 932833e5b712..9e19637e0225 100644
--- a/drivers/gpu/drm/i915/gt/intel_mocs.c
+++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
@@ -462,6 +462,12 @@ static void intel_mocs_init_global(struct intel_gt *gt)
 	struct drm_i915_mocs_table table;
 	unsigned int index;
 
+	/*
+	 * LLC and eDRAM control values are not only applicable to dgfx
+	 */
+	if (IS_DGFX(gt->i915))
+		return;
+
 	GEM_BUG_ON(!HAS_GLOBAL_MOCS_REGISTERS(gt->i915));
 
 	if (!get_mocs_settings(gt->i915, &table))
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 3/4] drm/i915: do not set MOCS control values on dgfx
Date: Thu, 24 Oct 2019 12:51:21 -0700	[thread overview]
Message-ID: <20191024195122.22877-3-lucas.demarchi@intel.com> (raw)
Message-ID: <20191024195121.AKhKfXP30oCizf7l-ip3iXR5RxvRfcbr1TLS_WMfggQ@z> (raw)
In-Reply-To: <20191024195122.22877-1-lucas.demarchi@intel.com>

On dgfx there's no LLC and eDRAM control table. Since now this
also means the device has global MOCS, just return early on the
initialization function.

L3 settings still apply and still need to be tweaked.

Bspec: 45101

Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_mocs.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
index 932833e5b712..9e19637e0225 100644
--- a/drivers/gpu/drm/i915/gt/intel_mocs.c
+++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
@@ -462,6 +462,12 @@ static void intel_mocs_init_global(struct intel_gt *gt)
 	struct drm_i915_mocs_table table;
 	unsigned int index;
 
+	/*
+	 * LLC and eDRAM control values are not only applicable to dgfx
+	 */
+	if (IS_DGFX(gt->i915))
+		return;
+
 	GEM_BUG_ON(!HAS_GLOBAL_MOCS_REGISTERS(gt->i915));
 
 	if (!get_mocs_settings(gt->i915, &table))
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-24 19:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 19:51 [PATCH 1/4] drm/i915: Add is_dgfx to device info Lucas De Marchi
2019-10-24 19:51 ` [Intel-gfx] " Lucas De Marchi
2019-10-24 19:51 ` [PATCH 2/4] drm/i915: add new gen12 dgfx platform macro Lucas De Marchi
2019-10-24 19:51   ` [Intel-gfx] " Lucas De Marchi
2019-10-24 19:55   ` Lucas De Marchi
2019-10-24 19:55     ` [Intel-gfx] " Lucas De Marchi
2019-10-24 20:34   ` Souza, Jose
2019-10-24 20:34     ` [Intel-gfx] " Souza, Jose
2019-10-24 19:51 ` Lucas De Marchi [this message]
2019-10-24 19:51   ` [Intel-gfx] [PATCH 3/4] drm/i915: do not set MOCS control values on dgfx Lucas De Marchi
2019-10-25 16:49   ` Daniele Ceraolo Spurio
2019-10-25 16:49     ` [Intel-gfx] " Daniele Ceraolo Spurio
2019-10-24 19:51 ` [PATCH 4/4] drm/i915: split gen11_irq_handler to make it shareable Lucas De Marchi
2019-10-24 19:51   ` [Intel-gfx] " Lucas De Marchi
2019-10-24 19:57   ` Lucas De Marchi
2019-10-24 19:57     ` [Intel-gfx] " Lucas De Marchi
2019-10-24 22:08 ` [PATCH 1/4] drm/i915: Add is_dgfx to device info Lucas De Marchi
2019-10-24 22:08   ` [Intel-gfx] " Lucas De Marchi
2019-10-24 23:09   ` Rodrigo Vivi
2019-10-24 23:09     ` [Intel-gfx] " Rodrigo Vivi
2019-10-24 22:37 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] " Patchwork
2019-10-24 22:37   ` [Intel-gfx] " Patchwork
2019-10-24 23:06 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-24 23:06   ` [Intel-gfx] " Patchwork
2019-10-26  9:03 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-26  9:03   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024195122.22877-3-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.