All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	Keyon Jie <yang.jie@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [alsa-devel] [PATCH 14/26] ASoC: SOF: Intel: hda-ipc: Don't read mailbox for PM_GATE reply
Date: Fri, 25 Oct 2019 17:41:10 -0500	[thread overview]
Message-ID: <20191025224122.7718-15-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20191025224122.7718-1-pierre-louis.bossart@linux.intel.com>

From: Keyon Jie <yang.jie@linux.intel.com>

Memory windows could be powered off before receiving PM_GATE IPC reply
from FW, we can't read the mailbox to get reply.

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sof/intel/hda-ipc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sound/soc/sof/intel/hda-ipc.c b/sound/soc/sof/intel/hda-ipc.c
index 6aae6f18b3dc..0fd2153c1769 100644
--- a/sound/soc/sof/intel/hda-ipc.c
+++ b/sound/soc/sof/intel/hda-ipc.c
@@ -83,10 +83,12 @@ void hda_dsp_ipc_get_reply(struct snd_sof_dev *sdev)
 	}
 
 	hdr = msg->msg_data;
-	if (hdr->cmd == (SOF_IPC_GLB_PM_MSG | SOF_IPC_PM_CTX_SAVE)) {
+	if (hdr->cmd == (SOF_IPC_GLB_PM_MSG | SOF_IPC_PM_CTX_SAVE) ||
+	    hdr->cmd == (SOF_IPC_GLB_PM_MSG | SOF_IPC_PM_GATE)) {
 		/*
 		 * memory windows are powered off before sending IPC reply,
-		 * so we can't read the mailbox for CTX_SAVE reply.
+		 * so we can't read the mailbox for CTX_SAVE and PM_GATE
+		 * replies.
 		 */
 		reply.error = 0;
 		reply.hdr.cmd = SOF_IPC_GLB_REPLY;
-- 
2.20.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-10-25 22:51 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 22:40 [alsa-devel] [PATCH 00/26] ASoC: SOF: enable S0ix support for Intel platforms Pierre-Louis Bossart
2019-10-25 22:40 ` [alsa-devel] [PATCH 01/26] ASoC: SOF: add a field to store the current D0 substate of DSP Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: add a field to store the current D0 substate of DSP" to the asoc tree Mark Brown
2019-10-29 10:20   ` [alsa-devel] [PATCH 01/26] ASoC: SOF: add a field to store the current D0 substate of DSP Cezary Rojewski
2019-10-29 14:11     ` Pierre-Louis Bossart
2019-10-25 22:40 ` [alsa-devel] [PATCH 02/26] ASoC: SOF: reset default d0_substate at probe() and resume() Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: reset default d0_substate at probe() and resume()" to the asoc tree Mark Brown
2019-10-25 22:40 ` [alsa-devel] [PATCH 03/26] ASoC: SOF: add set_power_state() to dsp_ops for power state update Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: add set_power_state() to dsp_ops for power state update" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 04/26] ASoC: SOF: Intel: hda-dsp: Add helper for setting DSP D0ix substate Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: Intel: hda-dsp: Add helper for setting DSP D0ix substate" to the asoc tree Mark Brown
2019-10-29 10:07   ` [alsa-devel] [PATCH 04/26] ASoC: SOF: Intel: hda-dsp: Add helper for setting DSP D0ix substate Cezary Rojewski
2019-10-29 16:37     ` Sridharan, Ranjani
2019-10-25 22:41 ` [alsa-devel] [PATCH 05/26] ASoC: SOF: Intel: CNL: add set_power_state() ops Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: Intel: CNL: add set_power_state() ops" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 06/26] ASoC: SOF: Intel: APL: add set_power_state() ops Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: Intel: APL: add set_power_state() ops" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 07/26] ASoC: SOF: add flag to snd_sof_pcm_stream for D0i3 compatible stream Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: add flag to snd_sof_pcm_stream for D0i3 compatible stream" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 08/26] ASoC: SOF: token: add tokens for PCM compatible with D0i3 substate Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: token: add tokens for PCM compatible with D0i3 substate" to the asoc tree Mark Brown
2019-10-29 10:11   ` [alsa-devel] [PATCH 08/26] ASoC: SOF: token: add tokens for PCM compatible with D0i3 substate Cezary Rojewski
2019-10-29 14:13     ` Pierre-Louis Bossart
2019-10-25 22:41 ` [alsa-devel] [PATCH 09/26] ASoC: SOF: topology: parse and store d0i3_compatible flag Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: topology: parse and store d0i3_compatible flag" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 10/26] ASoC: SOF: Intel: hda-dsp: align the comments for D0I3C update Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: Intel: hda-dsp: align the comments for D0I3C update" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 11/26] ASoC: SOF: Intel: HDA: use macro for register polling retry count Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: Intel: HDA: use macro for register polling retry count" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 12/26] ASoC: SOF: PM: rename sof_send_pm_ipc to sof_send_pm_ctx_ipc Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: PM: rename sof_send_pm_ipc to sof_send_pm_ctx_ipc" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 13/26] ASoC: SOF: ipc: introduce message for DSP power gating Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: ipc: introduce message for DSP power gating" to the asoc tree Mark Brown
2019-10-25 22:41 ` Pierre-Louis Bossart [this message]
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: Intel: hda-ipc: Don't read mailbox for PM_GATE reply" " Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 15/26] ASoC: SOF: Intel: HDA: add cAVS specific compact IPC header file Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: Intel: HDA: add cAVS specific compact IPC header file" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 16/26] ASoC: SOF: configure D0ix IPC flags in set_power_state Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: configure D0ix IPC flags in set_power_state" to the asoc tree Mark Brown
2019-10-29 10:37   ` [alsa-devel] [PATCH 16/26] ASoC: SOF: configure D0ix IPC flags in set_power_state Cezary Rojewski
2019-10-25 22:41 ` [alsa-devel] [PATCH 17/26] ASoC: SOF: PM: add helpers for setting D0 substate for ADSP Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: PM: add helpers for setting D0 substate for ADSP" to the asoc tree Mark Brown
2019-10-29 10:44   ` [alsa-devel] [PATCH 17/26] ASoC: SOF: PM: add helpers for setting D0 substate for ADSP Cezary Rojewski
2019-10-25 22:41 ` [alsa-devel] [PATCH 18/26] ASoC: SOF: Intel: CNL: add support for sending compact IPC Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: Intel: CNL: add support for sending compact IPC" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 19/26] ASoC: SOF: add a flag to indicate the system suspend target Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: add a flag to indicate the system suspend target" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 20/26] ASoC: SOF: add a flag suspend_ignored for sof stream Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: add a flag suspend_ignored for sof stream" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 21/26] ASoC: SOF: PM: implement prepare/complete callbacks Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: PM: implement prepare/complete callbacks" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 22/26] ASoC: SOF: ignore suspend/resume for D0ix compatible streams Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: ignore suspend/resume for D0ix compatible streams" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 23/26] ASoC: SOF: Intel: hda-dsp: implement suspend/resume for S0ix<->S0 transition Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: Intel: hda-dsp: implement suspend/resume for S0ix<->S0 transition" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 24/26] ASoC: SOF: return -ENOTSUPP if D0I3 is not supported Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: return -ENOTSUPP if D0I3 is not supported" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 25/26] ASoC: SOF: PM: Add support for DSP D0i3 state when entering S0ix Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: PM: Add support for DSP D0i3 state when entering S0ix" to the asoc tree Mark Brown
2019-10-25 22:41 ` [alsa-devel] [PATCH 26/26] ASoC: SOF: pci: Add prepare/complete PM callbacks Pierre-Louis Bossart
2019-10-28 14:56   ` [alsa-devel] Applied "ASoC: SOF: pci: Add prepare/complete PM callbacks" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025224122.7718-15-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=tiwai@suse.de \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.