All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mao Wenan <maowenan@huawei.com>
To: <bfields@redhat.com>, <chuck.lever@oracle.com>,
	<trond.myklebust@primarydata.com>, <dros@primarydata.com>,
	<jeff.layton@primarydata.com>, <richard.sharpe@primarydata.com>
Cc: <linux-nfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>,
	Mao Wenan <maowenan@huawei.com>
Subject: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
Date: Fri, 1 Nov 2019 19:40:54 +0800	[thread overview]
Message-ID: <20191101114054.50225-1-maowenan@huawei.com> (raw)

The declarations were introduced with the file, but the declared
variables were not used.

Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 fs/nfsd/filecache.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
index ef55e9b..32a9bf2 100644
--- a/fs/nfsd/filecache.c
+++ b/fs/nfsd/filecache.c
@@ -685,8 +685,6 @@ nfsd_file_cache_purge(struct net *net)
 void
 nfsd_file_cache_shutdown(void)
 {
-	LIST_HEAD(dispose);
-
 	set_bit(NFSD_FILE_SHUTDOWN, &nfsd_file_lru_flags);
 
 	lease_unregister_notifier(&nfsd_file_lease_notifier);
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Mao Wenan <maowenan@huawei.com>
To: bfields@redhat.com, chuck.lever@oracle.com,
	trond.myklebust@primarydata.com, dros@primarydata.com,
	jeff.layton@primarydata.com, richard.sharpe@primarydata.com
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, Mao Wenan <maowenan@huawei.com>
Subject: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
Date: Fri, 01 Nov 2019 11:40:54 +0000	[thread overview]
Message-ID: <20191101114054.50225-1-maowenan@huawei.com> (raw)

The declarations were introduced with the file, but the declared
variables were not used.

Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 fs/nfsd/filecache.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
index ef55e9b..32a9bf2 100644
--- a/fs/nfsd/filecache.c
+++ b/fs/nfsd/filecache.c
@@ -685,8 +685,6 @@ nfsd_file_cache_purge(struct net *net)
 void
 nfsd_file_cache_shutdown(void)
 {
-	LIST_HEAD(dispose);
-
 	set_bit(NFSD_FILE_SHUTDOWN, &nfsd_file_lru_flags);
 
 	lease_unregister_notifier(&nfsd_file_lease_notifier);
-- 
2.7.4

             reply	other threads:[~2019-11-01 11:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01 11:40 Mao Wenan [this message]
2019-11-01 11:40 ` [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used Mao Wenan
2019-11-01 13:36 ` Chuck Lever
2019-11-01 13:36   ` Chuck Lever
2019-11-01 14:49   ` Dan Carpenter
2019-11-01 14:49     ` Dan Carpenter
2019-11-01 15:51     ` J. Bruce Fields
2019-11-01 15:51       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191101114054.50225-1-maowenan@huawei.com \
    --to=maowenan@huawei.com \
    --cc=bfields@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=dros@primarydata.com \
    --cc=jeff.layton@primarydata.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=richard.sharpe@primarydata.com \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.