From: Steven Price <steven.price@arm.com> To: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org Cc: "Steven Price" <steven.price@arm.com>, "Andy Lutomirski" <luto@kernel.org>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Arnd Bergmann" <arnd@arndb.de>, "Borislav Petkov" <bp@alien8.de>, "Catalin Marinas" <catalin.marinas@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Ingo Molnar" <mingo@redhat.com>, "James Morse" <james.morse@arm.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Will Deacon" <will@kernel.org>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Mark Rutland" <Mark.Rutland@arm.com>, "Liang, Kan" <kan.liang@linux.intel.com> Subject: [PATCH v15 00/23] Generic page walk and ptdump Date: Fri, 1 Nov 2019 14:09:19 +0000 [thread overview] Message-ID: <20191101140942.51554-1-steven.price@arm.com> (raw) Many architectures current have a debugfs file for dumping the kernel page tables. Currently each architecture has to implement custom functions for this because the details of walking the page tables used by the kernel are different between architectures. This series extends the capabilities of walk_page_range() so that it can deal with the page tables of the kernel (which have no VMAs and can contain larger huge pages than exist for user space). A generic PTDUMP implementation is the implemented making use of the new functionality of walk_page_range() and finally arm64 and x86 are switch to using it, removing the custom table walkers. To enable a generic page table walker to walk the unusual mappings of the kernel we need to implement a set of functions which let us know when the walker has reached the leaf entry. After a suggestion from Will Deacon I've chosen the name p?d_leaf() as this (hopefully) describes the purpose (and is a new name so has no historic baggage). Some architectures have p?d_large macros but this is easily confused with "large pages". This series ends with a generic PTDUMP implemention for arm64 and x86. Mostly this is a clean up and there should be very little functional change. The exceptions are: * arm64 PTDUMP debugfs now displays pages which aren't present (patch 22). * arm64 has the ability to efficiently process KASAN pages (which previously only x86 implemented). This means that the combination of KASAN and DEBUG_WX is now useable. Also available as a git tree: git://linux-arm.org/linux-sp.git walk_page_range/v15 Changes since v14: https://lore.kernel.org/lkml/20191028135910.33253-1-steven.price@arm.com/ * Switch walk_page_range() into two functions, the existing walk_page_range() now still requires VMAs (and treats areas without a VMA as a 'hole'). The new walk_page_range_novma() ignores VMAs and will report the actual page table layout. This fixes the previous breakage of /proc/<pid>/pagemap * New patch at the end of the series which reduces the 'level' numbers by 1 to simplify the code slightly * Added tags Changes since v13: https://lore.kernel.org/lkml/20191024093716.49420-1-steven.price@arm.com/ * Fixed typo in arc definition of pmd_leaf() spotted by the kbuild test robot * Added tags Changes since v12: https://lore.kernel.org/lkml/20191018101248.33727-1-steven.price@arm.com/ * Correct code format in riscv pud_leaf()/pmd_leaf() * v12 may not have reached everyone because of mail server problems (which are now hopefully resolved!) Changes since v11: https://lore.kernel.org/lkml/20191007153822.16518-1-steven.price@arm.com/ * Use "-1" as dummy depth parameter in patch 14. Changes since v10: https://lore.kernel.org/lkml/20190731154603.41797-1-steven.price@arm.com/ * Rebased to v5.4-rc1 - mainly various updates to deal with the splitting out of ops from struct mm_walk. * Deal with PGD_LEVEL_MULT not always being constant on x86. Changes since v9: https://lore.kernel.org/lkml/20190722154210.42799-1-steven.price@arm.com/ * Moved generic macros to first page in the series and explained the macro naming in the commit message. * mips: Moved macros to pgtable.h as they are now valid for both 32 and 64 bit * x86: Dropped patch which changed the debugfs output for x86, instead we have... * new patch adding 'depth' parameter to pte_hole. This is used to provide the necessary information to output lines for 'holes' in the debugfs files * new patch changing arm64 debugfs output to include holes to match x86 * generic ptdump KASAN handling has been simplified and now works with CONFIG_DEBUG_VIRTUAL. Changes since v8: https://lore.kernel.org/lkml/20190403141627.11664-1-steven.price@arm.com/ * Rename from p?d_large() to p?d_leaf() * Dropped patches migrating arm64/x86 custom walkers to walk_page_range() in favour of adding a generic PTDUMP implementation and migrating arm64/x86 to that instead. * Rebased to v5.3-rc1 Steven Price (23): mm: Add generic p?d_leaf() macros arc: mm: Add p?d_leaf() definitions arm: mm: Add p?d_leaf() definitions arm64: mm: Add p?d_leaf() definitions mips: mm: Add p?d_leaf() definitions powerpc: mm: Add p?d_leaf() definitions riscv: mm: Add p?d_leaf() definitions s390: mm: Add p?d_leaf() definitions sparc: mm: Add p?d_leaf() definitions x86: mm: Add p?d_leaf() definitions mm: pagewalk: Add p4d_entry() and pgd_entry() mm: pagewalk: Allow walking without vma mm: pagewalk: Add test_p?d callbacks mm: pagewalk: Add 'depth' parameter to pte_hole x86: mm: Point to struct seq_file from struct pg_state x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct x86: mm: Convert ptdump_walk_pgd_level_core() to take an mm_struct mm: Add generic ptdump x86: mm: Convert dump_pagetables to use walk_page_range arm64: mm: Convert mm/dump.c to use walk_page_range() arm64: mm: Display non-present entries in ptdump mm: ptdump: Reduce level numbers by 1 in note_page() arch/arc/include/asm/pgtable.h | 1 + arch/arm/include/asm/pgtable-2level.h | 1 + arch/arm/include/asm/pgtable-3level.h | 1 + arch/arm64/Kconfig | 1 + arch/arm64/Kconfig.debug | 19 +- arch/arm64/include/asm/pgtable.h | 2 + arch/arm64/include/asm/ptdump.h | 8 +- arch/arm64/mm/Makefile | 4 +- arch/arm64/mm/dump.c | 148 +++----- arch/arm64/mm/mmu.c | 4 +- arch/arm64/mm/ptdump_debugfs.c | 2 +- arch/mips/include/asm/pgtable.h | 5 + arch/powerpc/include/asm/book3s/64/pgtable.h | 30 +- arch/riscv/include/asm/pgtable-64.h | 7 + arch/riscv/include/asm/pgtable.h | 7 + arch/s390/include/asm/pgtable.h | 2 + arch/sparc/include/asm/pgtable_64.h | 2 + arch/x86/Kconfig | 1 + arch/x86/Kconfig.debug | 20 +- arch/x86/include/asm/pgtable.h | 10 +- arch/x86/mm/Makefile | 4 +- arch/x86/mm/debug_pagetables.c | 8 +- arch/x86/mm/dump_pagetables.c | 343 +++++-------------- arch/x86/platform/efi/efi_32.c | 2 +- arch/x86/platform/efi/efi_64.c | 4 +- drivers/firmware/efi/arm-runtime.c | 2 +- fs/proc/task_mmu.c | 4 +- include/asm-generic/pgtable.h | 20 ++ include/linux/pagewalk.h | 42 ++- include/linux/ptdump.h | 22 ++ mm/Kconfig.debug | 21 ++ mm/Makefile | 1 + mm/hmm.c | 8 +- mm/migrate.c | 5 +- mm/mincore.c | 1 + mm/pagewalk.c | 126 +++++-- mm/ptdump.c | 151 ++++++++ 37 files changed, 586 insertions(+), 453 deletions(-) create mode 100644 include/linux/ptdump.h create mode 100644 mm/ptdump.c -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com> To: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org Cc: "Mark Rutland" <Mark.Rutland@arm.com>, x86@kernel.org, "Arnd Bergmann" <arnd@arndb.de>, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>, "Peter Zijlstra" <peterz@infradead.org>, "Catalin Marinas" <catalin.marinas@arm.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, linux-kernel@vger.kernel.org, "Steven Price" <steven.price@arm.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>, "Andy Lutomirski" <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, "James Morse" <james.morse@arm.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Will Deacon" <will@kernel.org>, linux-arm-kernel@lists.infradead.org, "Liang, Kan" <kan.liang@linux.intel.com> Subject: [PATCH v15 00/23] Generic page walk and ptdump Date: Fri, 1 Nov 2019 14:09:19 +0000 [thread overview] Message-ID: <20191101140942.51554-1-steven.price@arm.com> (raw) Many architectures current have a debugfs file for dumping the kernel page tables. Currently each architecture has to implement custom functions for this because the details of walking the page tables used by the kernel are different between architectures. This series extends the capabilities of walk_page_range() so that it can deal with the page tables of the kernel (which have no VMAs and can contain larger huge pages than exist for user space). A generic PTDUMP implementation is the implemented making use of the new functionality of walk_page_range() and finally arm64 and x86 are switch to using it, removing the custom table walkers. To enable a generic page table walker to walk the unusual mappings of the kernel we need to implement a set of functions which let us know when the walker has reached the leaf entry. After a suggestion from Will Deacon I've chosen the name p?d_leaf() as this (hopefully) describes the purpose (and is a new name so has no historic baggage). Some architectures have p?d_large macros but this is easily confused with "large pages". This series ends with a generic PTDUMP implemention for arm64 and x86. Mostly this is a clean up and there should be very little functional change. The exceptions are: * arm64 PTDUMP debugfs now displays pages which aren't present (patch 22). * arm64 has the ability to efficiently process KASAN pages (which previously only x86 implemented). This means that the combination of KASAN and DEBUG_WX is now useable. Also available as a git tree: git://linux-arm.org/linux-sp.git walk_page_range/v15 Changes since v14: https://lore.kernel.org/lkml/20191028135910.33253-1-steven.price@arm.com/ * Switch walk_page_range() into two functions, the existing walk_page_range() now still requires VMAs (and treats areas without a VMA as a 'hole'). The new walk_page_range_novma() ignores VMAs and will report the actual page table layout. This fixes the previous breakage of /proc/<pid>/pagemap * New patch at the end of the series which reduces the 'level' numbers by 1 to simplify the code slightly * Added tags Changes since v13: https://lore.kernel.org/lkml/20191024093716.49420-1-steven.price@arm.com/ * Fixed typo in arc definition of pmd_leaf() spotted by the kbuild test robot * Added tags Changes since v12: https://lore.kernel.org/lkml/20191018101248.33727-1-steven.price@arm.com/ * Correct code format in riscv pud_leaf()/pmd_leaf() * v12 may not have reached everyone because of mail server problems (which are now hopefully resolved!) Changes since v11: https://lore.kernel.org/lkml/20191007153822.16518-1-steven.price@arm.com/ * Use "-1" as dummy depth parameter in patch 14. Changes since v10: https://lore.kernel.org/lkml/20190731154603.41797-1-steven.price@arm.com/ * Rebased to v5.4-rc1 - mainly various updates to deal with the splitting out of ops from struct mm_walk. * Deal with PGD_LEVEL_MULT not always being constant on x86. Changes since v9: https://lore.kernel.org/lkml/20190722154210.42799-1-steven.price@arm.com/ * Moved generic macros to first page in the series and explained the macro naming in the commit message. * mips: Moved macros to pgtable.h as they are now valid for both 32 and 64 bit * x86: Dropped patch which changed the debugfs output for x86, instead we have... * new patch adding 'depth' parameter to pte_hole. This is used to provide the necessary information to output lines for 'holes' in the debugfs files * new patch changing arm64 debugfs output to include holes to match x86 * generic ptdump KASAN handling has been simplified and now works with CONFIG_DEBUG_VIRTUAL. Changes since v8: https://lore.kernel.org/lkml/20190403141627.11664-1-steven.price@arm.com/ * Rename from p?d_large() to p?d_leaf() * Dropped patches migrating arm64/x86 custom walkers to walk_page_range() in favour of adding a generic PTDUMP implementation and migrating arm64/x86 to that instead. * Rebased to v5.3-rc1 Steven Price (23): mm: Add generic p?d_leaf() macros arc: mm: Add p?d_leaf() definitions arm: mm: Add p?d_leaf() definitions arm64: mm: Add p?d_leaf() definitions mips: mm: Add p?d_leaf() definitions powerpc: mm: Add p?d_leaf() definitions riscv: mm: Add p?d_leaf() definitions s390: mm: Add p?d_leaf() definitions sparc: mm: Add p?d_leaf() definitions x86: mm: Add p?d_leaf() definitions mm: pagewalk: Add p4d_entry() and pgd_entry() mm: pagewalk: Allow walking without vma mm: pagewalk: Add test_p?d callbacks mm: pagewalk: Add 'depth' parameter to pte_hole x86: mm: Point to struct seq_file from struct pg_state x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct x86: mm: Convert ptdump_walk_pgd_level_core() to take an mm_struct mm: Add generic ptdump x86: mm: Convert dump_pagetables to use walk_page_range arm64: mm: Convert mm/dump.c to use walk_page_range() arm64: mm: Display non-present entries in ptdump mm: ptdump: Reduce level numbers by 1 in note_page() arch/arc/include/asm/pgtable.h | 1 + arch/arm/include/asm/pgtable-2level.h | 1 + arch/arm/include/asm/pgtable-3level.h | 1 + arch/arm64/Kconfig | 1 + arch/arm64/Kconfig.debug | 19 +- arch/arm64/include/asm/pgtable.h | 2 + arch/arm64/include/asm/ptdump.h | 8 +- arch/arm64/mm/Makefile | 4 +- arch/arm64/mm/dump.c | 148 +++----- arch/arm64/mm/mmu.c | 4 +- arch/arm64/mm/ptdump_debugfs.c | 2 +- arch/mips/include/asm/pgtable.h | 5 + arch/powerpc/include/asm/book3s/64/pgtable.h | 30 +- arch/riscv/include/asm/pgtable-64.h | 7 + arch/riscv/include/asm/pgtable.h | 7 + arch/s390/include/asm/pgtable.h | 2 + arch/sparc/include/asm/pgtable_64.h | 2 + arch/x86/Kconfig | 1 + arch/x86/Kconfig.debug | 20 +- arch/x86/include/asm/pgtable.h | 10 +- arch/x86/mm/Makefile | 4 +- arch/x86/mm/debug_pagetables.c | 8 +- arch/x86/mm/dump_pagetables.c | 343 +++++-------------- arch/x86/platform/efi/efi_32.c | 2 +- arch/x86/platform/efi/efi_64.c | 4 +- drivers/firmware/efi/arm-runtime.c | 2 +- fs/proc/task_mmu.c | 4 +- include/asm-generic/pgtable.h | 20 ++ include/linux/pagewalk.h | 42 ++- include/linux/ptdump.h | 22 ++ mm/Kconfig.debug | 21 ++ mm/Makefile | 1 + mm/hmm.c | 8 +- mm/migrate.c | 5 +- mm/mincore.c | 1 + mm/pagewalk.c | 126 +++++-- mm/ptdump.c | 151 ++++++++ 37 files changed, 586 insertions(+), 453 deletions(-) create mode 100644 include/linux/ptdump.h create mode 100644 mm/ptdump.c -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-11-01 14:09 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-01 14:09 Steven Price [this message] 2019-11-01 14:09 ` [PATCH v15 00/23] Generic page walk and ptdump Steven Price 2019-11-01 14:09 ` [PATCH v15 01/23] mm: Add generic p?d_leaf() macros Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 02/23] arc: mm: Add p?d_leaf() definitions Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 03/23] arm: " Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 04/23] arm64: " Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 05/23] mips: " Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 06/23] powerpc: " Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 07/23] riscv: " Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 08/23] s390: " Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 09/23] sparc: " Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 10/23] x86: " Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 11/23] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 12/23] mm: pagewalk: Allow walking without vma Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 13/23] mm: pagewalk: Add test_p?d callbacks Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 14/23] mm: pagewalk: Add 'depth' parameter to pte_hole Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 15/23] x86: mm: Point to struct seq_file from struct pg_state Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 16/23] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 17/23] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 18/23] x86: mm: Convert ptdump_walk_pgd_level_core() " Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 19/23] mm: Add generic ptdump Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 20/23] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 21/23] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 22/23] arm64: mm: Display non-present entries in ptdump Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-01 14:09 ` [PATCH v15 23/23] mm: ptdump: Reduce level numbers by 1 in note_page() Steven Price 2019-11-01 14:09 ` Steven Price 2019-11-04 19:35 ` [PATCH v15 00/23] Generic page walk and ptdump Qian Cai 2019-11-04 19:35 ` Qian Cai 2019-11-06 13:31 ` Qian Cai 2019-11-06 13:31 ` Qian Cai 2019-11-06 15:05 ` Steven Price 2019-11-06 15:05 ` Steven Price 2019-12-03 11:02 ` David Hildenbrand 2019-12-03 11:02 ` David Hildenbrand 2019-12-04 14:54 ` Qian Cai 2019-12-04 14:54 ` Qian Cai 2019-12-04 14:56 ` David Hildenbrand 2019-12-04 14:56 ` David Hildenbrand 2019-12-04 16:32 ` Steven Price 2019-12-04 16:32 ` Steven Price 2019-12-04 17:51 ` Thomas Hellstrom 2019-12-04 17:51 ` Thomas Hellstrom 2019-12-05 13:15 ` Qian Cai 2019-12-05 13:15 ` Qian Cai 2019-12-05 14:32 ` Thomas Hellstrom 2019-12-05 14:32 ` Thomas Hellstrom 2019-12-05 14:32 ` Thomas Hellstrom 2019-12-05 14:38 ` Qian Cai 2019-12-05 14:38 ` Qian Cai 2019-12-05 14:38 ` Qian Cai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191101140942.51554-1-steven.price@arm.com \ --to=steven.price@arm.com \ --cc=Mark.Rutland@arm.com \ --cc=akpm@linux-foundation.org \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=dave.hansen@linux.intel.com \ --cc=hpa@zytor.com \ --cc=james.morse@arm.com \ --cc=jglisse@redhat.com \ --cc=kan.liang@linux.intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.