All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: [PATCH 7/8] ov6650: fix smatch warning
Date: Sun,  3 Nov 2019 12:23:37 +0100	[thread overview]
Message-ID: <20191103112338.22569-8-hverkuil-cisco@xs4all.nl> (raw)
In-Reply-To: <20191103112338.22569-1-hverkuil-cisco@xs4all.nl>

Initialize ret to 0 to fix this smatch error:

drivers/media/i2c/ov6650.c:853 ov6650_video_probe() error: uninitialized symbol 'ret'.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/i2c/ov6650.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c
index 3c8f50f8619f..91906b94f978 100644
--- a/drivers/media/i2c/ov6650.c
+++ b/drivers/media/i2c/ov6650.c
@@ -819,7 +819,7 @@ static int ov6650_video_probe(struct v4l2_subdev *sd)
 	const struct ov6650_xclk *xclk = NULL;
 	unsigned long rate;
 	u8 pidh, pidl, midh, midl;
-	int i, ret;
+	int i, ret = 0;
 
 	priv->clk = v4l2_clk_get(&client->dev, NULL);
 	if (IS_ERR(priv->clk)) {
-- 
2.23.0


  parent reply	other threads:[~2019-11-03 11:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-03 11:23 [PATCH 0/8] Fix various smatch warnings/errors Hans Verkuil
2019-11-03 11:23 ` [PATCH 1/8] am437x: fix smatch warning Hans Verkuil
2019-11-04 17:40   ` Benoit Parrot
2019-11-03 11:23 ` [PATCH 2/8] smiapp: smiapp_start_streaming(): replace return by goto Hans Verkuil
2019-11-04  8:12   ` Sakari Ailus
2019-11-04  8:17     ` Hans Verkuil
2019-11-03 11:23 ` [PATCH 3/8] mtk-vpu: fix two smatch warnings Hans Verkuil
2019-11-03 11:23 ` [PATCH 4/8] rc/ite-cir: fix smatch warning Hans Verkuil
2019-11-03 22:02   ` Sean Young
2019-11-03 11:23 ` [PATCH 5/8] em28xx: fix two smatch warnings Hans Verkuil
2019-11-03 11:23 ` [PATCH 6/8] ti-vpe: fix smatch error Hans Verkuil
2019-11-04 17:40   ` Benoit Parrot
2019-11-03 11:23 ` Hans Verkuil [this message]
2019-11-04  8:13   ` [PATCH 7/8] ov6650: fix smatch warning Sakari Ailus
2019-11-03 11:23 ` [PATCH 8/8] mantis: fix two smatch errors Hans Verkuil
2019-11-03 14:01 ` [PATCH 9/8] vivid: add vivid_create_queue() helper Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191103112338.22569-8-hverkuil-cisco@xs4all.nl \
    --to=hverkuil-cisco@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.