All of lore.kernel.org
 help / color / mirror / Atom feed
From: <mikita.lipski-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: David Francis <David.Francis-5C7GfCeVMHo@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH v6 04/13] drm/dp_mst: Fill branch->num_ports
Date: Thu, 7 Nov 2019 10:32:03 -0500	[thread overview]
Message-ID: <20191107153212.1145-5-mikita.lipski@amd.com> (raw)
In-Reply-To: <20191107153212.1145-1-mikita.lipski-5C7GfCeVMHo@public.gmane.org>

From: David Francis <David.Francis@amd.com>

This field on drm_dp_mst_branch was never filled

It is initialized to zero when the port is kzallocced.
When a port is added to the list, increment num_ports,
and when a port is removed from the list, decrement num_ports.

v2: remember to decrement on port removal
v3: don't explicitly init to 0

Reviewed-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: David Francis <David.Francis@amd.com>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 9f3604355705..502923c24450 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -1669,6 +1669,7 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb,
 		mutex_lock(&mstb->mgr->lock);
 		drm_dp_mst_topology_get_port(port);
 		list_add(&port->next, &mstb->ports);
+		mstb->num_ports++;
 		mutex_unlock(&mstb->mgr->lock);
 	}
 
@@ -1703,6 +1704,7 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb,
 			/* remove it from the port list */
 			mutex_lock(&mstb->mgr->lock);
 			list_del(&port->next);
+			mstb->num_ports--;
 			mutex_unlock(&mstb->mgr->lock);
 			/* drop port list reference */
 			drm_dp_mst_topology_put_port(port);
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: <mikita.lipski@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: David Francis <David.Francis@amd.com>, dri-devel@lists.freedesktop.org
Subject: [PATCH v6 04/13] drm/dp_mst: Fill branch->num_ports
Date: Thu, 7 Nov 2019 10:32:03 -0500	[thread overview]
Message-ID: <20191107153212.1145-5-mikita.lipski@amd.com> (raw)
Message-ID: <20191107153203.5I-gZHDY_6NNw5ND-0cyG5xjNsI-SJaj0VEU-WRABXk@z> (raw)
In-Reply-To: <20191107153212.1145-1-mikita.lipski@amd.com>

From: David Francis <David.Francis@amd.com>

This field on drm_dp_mst_branch was never filled

It is initialized to zero when the port is kzallocced.
When a port is added to the list, increment num_ports,
and when a port is removed from the list, decrement num_ports.

v2: remember to decrement on port removal
v3: don't explicitly init to 0

Reviewed-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: David Francis <David.Francis@amd.com>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 9f3604355705..502923c24450 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -1669,6 +1669,7 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb,
 		mutex_lock(&mstb->mgr->lock);
 		drm_dp_mst_topology_get_port(port);
 		list_add(&port->next, &mstb->ports);
+		mstb->num_ports++;
 		mutex_unlock(&mstb->mgr->lock);
 	}
 
@@ -1703,6 +1704,7 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb,
 			/* remove it from the port list */
 			mutex_lock(&mstb->mgr->lock);
 			list_del(&port->next);
+			mstb->num_ports--;
 			mutex_unlock(&mstb->mgr->lock);
 			/* drop port list reference */
 			drm_dp_mst_topology_put_port(port);
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: <mikita.lipski@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: David Francis <David.Francis@amd.com>, dri-devel@lists.freedesktop.org
Subject: [PATCH v6 04/13] drm/dp_mst: Fill branch->num_ports
Date: Thu, 7 Nov 2019 10:32:03 -0500	[thread overview]
Message-ID: <20191107153212.1145-5-mikita.lipski@amd.com> (raw)
Message-ID: <20191107153203.dEqxRI2v3ztX9CzSV1aLYEgPsNmz1bSpPRtQeVHSWg4@z> (raw)
In-Reply-To: <20191107153212.1145-1-mikita.lipski@amd.com>

From: David Francis <David.Francis@amd.com>

This field on drm_dp_mst_branch was never filled

It is initialized to zero when the port is kzallocced.
When a port is added to the list, increment num_ports,
and when a port is removed from the list, decrement num_ports.

v2: remember to decrement on port removal
v3: don't explicitly init to 0

Reviewed-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: David Francis <David.Francis@amd.com>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 9f3604355705..502923c24450 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -1669,6 +1669,7 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb,
 		mutex_lock(&mstb->mgr->lock);
 		drm_dp_mst_topology_get_port(port);
 		list_add(&port->next, &mstb->ports);
+		mstb->num_ports++;
 		mutex_unlock(&mstb->mgr->lock);
 	}
 
@@ -1703,6 +1704,7 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb,
 			/* remove it from the port list */
 			mutex_lock(&mstb->mgr->lock);
 			list_del(&port->next);
+			mstb->num_ports--;
 			mutex_unlock(&mstb->mgr->lock);
 			/* drop port list reference */
 			drm_dp_mst_topology_put_port(port);
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-11-07 15:32 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 15:31 [PATCH v5 00/13] DSC MST support for DRM and AMDGPU mikita.lipski
2019-11-07 15:31 ` mikita.lipski
2019-11-07 15:31 ` mikita.lipski
     [not found] ` <20191107153212.1145-1-mikita.lipski-5C7GfCeVMHo@public.gmane.org>
2019-11-07 15:32   ` [PATCH v6 01/13] drm/dp_mst: Add PBN calculation for DSC modes mikita.lipski-5C7GfCeVMHo
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32   ` [PATCH v6 02/13] drm/dp_mst: Parse FEC capability on MST ports mikita.lipski-5C7GfCeVMHo
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32   ` [PATCH v6 03/13] drm/dp_mst: Add MST support to DP DPCD R/W functions mikita.lipski-5C7GfCeVMHo
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32   ` mikita.lipski-5C7GfCeVMHo [this message]
2019-11-07 15:32     ` [PATCH v6 04/13] drm/dp_mst: Fill branch->num_ports mikita.lipski
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32   ` [PATCH v6 05/13] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux mikita.lipski-5C7GfCeVMHo
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32   ` [PATCH v6 07/13] drm/amd/display: Initialize DSC PPS variables to 0 mikita.lipski-5C7GfCeVMHo
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32   ` [PATCH v6 09/13] drm/amd/display: Write DSC enable to MST DPCD mikita.lipski-5C7GfCeVMHo
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32   ` [PATCH v6 10/13] drm/dp_mst: Add DSC enablement helpers to DRM mikita.lipski-5C7GfCeVMHo
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32   ` [PATCH v6 12/13] drm/amd/display: MST DSC compute fair share mikita.lipski-5C7GfCeVMHo
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32   ` [PATCH v6 13/13] drm/amd/display: Recalculate VCPI slots for new DSC connectors mikita.lipski-5C7GfCeVMHo
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32     ` mikita.lipski
2019-11-07 15:32 ` [PATCH v6 06/13] drm/dp_mst: Add new quirk for Synaptics MST hubs mikita.lipski
2019-11-07 15:32   ` mikita.lipski
2019-11-07 15:32   ` mikita.lipski
2019-11-07 15:32 ` [PATCH v6 08/13] drm/amd/display: Validate DSC caps on MST endpoints mikita.lipski
2019-11-07 15:32   ` mikita.lipski
2019-11-07 15:32   ` mikita.lipski
2019-11-07 15:32 ` [PATCH v6 11/13] drm/dp_mst: Add branch bandwidth validation to MST atomic check mikita.lipski
2019-11-07 15:32   ` mikita.lipski
2019-11-07 15:32   ` mikita.lipski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107153212.1145-5-mikita.lipski@amd.com \
    --to=mikita.lipski-5c7gfcevmho@public.gmane.org \
    --cc=David.Francis-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.