All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valdis Kletnieks <valdis.kletnieks@vt.edu>
To: gregkh@linuxfoundation.org
Cc: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
	Valdis Kletnieks <valdis.kletnieks@vt.edu>,
	linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 9/9] staging: exfat: Correct return code
Date: Mon, 11 Nov 2019 21:09:57 -0500	[thread overview]
Message-ID: <20191112021000.42091-10-Valdis.Kletnieks@vt.edu> (raw)
In-Reply-To: <20191112021000.42091-1-Valdis.Kletnieks@vt.edu>

Use -ENOTEMPTY rather than -EEXIST for attempting to remove
a directory that still has files in it.

Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
---
 drivers/staging/exfat/exfat_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index a97a61a60517..e2254d45ef6e 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -2167,7 +2167,7 @@ static int ffsRemoveDir(struct inode *inode, struct file_id_t *fid)
 	clu_to_free.flags = fid->flags;
 
 	if (!is_dir_empty(sb, &clu_to_free)) {
-		ret = -EEXIST;
+		ret = -ENOTEMPTY;
 		goto out;
 	}
 
-- 
2.24.0


WARNING: multiple messages have this Message-ID (diff)
From: Valdis Kletnieks <valdis.kletnieks@vt.edu>
To: gregkh@linuxfoundation.org
Cc: linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org,
	Valdis Kletnieks <valdis.kletnieks@vt.edu>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 9/9] staging: exfat: Correct return code
Date: Mon, 11 Nov 2019 21:09:57 -0500	[thread overview]
Message-ID: <20191112021000.42091-10-Valdis.Kletnieks@vt.edu> (raw)
In-Reply-To: <20191112021000.42091-1-Valdis.Kletnieks@vt.edu>

Use -ENOTEMPTY rather than -EEXIST for attempting to remove
a directory that still has files in it.

Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
---
 drivers/staging/exfat/exfat_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index a97a61a60517..e2254d45ef6e 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -2167,7 +2167,7 @@ static int ffsRemoveDir(struct inode *inode, struct file_id_t *fid)
 	clu_to_free.flags = fid->flags;
 
 	if (!is_dir_empty(sb, &clu_to_free)) {
-		ret = -EEXIST;
+		ret = -ENOTEMPTY;
 		goto out;
 	}
 
-- 
2.24.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2019-11-12  2:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191112021000.42091-1-Valdis.Kletnieks@vt.edu>
2019-11-12  2:09 ` [PATCH v3 1/9] staging: exfat: Clean up return codes - FFS_FORMATERR Valdis Kletnieks
2019-11-12  2:09   ` Valdis Kletnieks
2019-11-12  2:09 ` [PATCH v3 2/9] staging: exfat: Clean up return codes - FFS_MEDIAERR Valdis Kletnieks
2019-11-12  2:09   ` Valdis Kletnieks
2019-11-12  2:09 ` [PATCH v3 3/9] staging: exfat: Clean up return codes - FFS_EOF Valdis Kletnieks
2019-11-12  2:09   ` Valdis Kletnieks
2019-11-12  2:09 ` [PATCH v3 4/9] staging: exfat: Clean up return codes - FFS_INVALIDFID Valdis Kletnieks
2019-11-12  2:09   ` Valdis Kletnieks
2019-11-12  2:09 ` [PATCH v3 5/9] staging: exfat: Clean up return codes - FFS_ERROR Valdis Kletnieks
2019-11-12  2:09   ` Valdis Kletnieks
2019-11-12  2:09 ` [PATCH v3 6/9] staging: exfat: Clean up return codes - remove unused codes Valdis Kletnieks
2019-11-12  2:09   ` Valdis Kletnieks
2019-11-12  2:09 ` [PATCH v3 7/9] staging: exfat: Clean up return codes - FFS_SUCCESS Valdis Kletnieks
2019-11-12  2:09   ` Valdis Kletnieks
2019-11-12  2:09 ` [PATCH v3 8/9] staging: exfat: Collapse redundant return code translations Valdis Kletnieks
2019-11-12  2:09   ` Valdis Kletnieks
2019-11-13 18:19   ` Dan Carpenter
2019-11-13 18:19     ` Dan Carpenter
2019-11-12  2:09 ` Valdis Kletnieks [this message]
2019-11-12  2:09   ` [PATCH v3 9/9] staging: exfat: Correct return code Valdis Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112021000.42091-10-Valdis.Kletnieks@vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.