From: Geert Uytterhoeven <geert+renesas@glider.be> To: "Russell King" <linux@armlinux.org.uk>, "Arnd Bergmann" <arnd@arndb.de>, "Nicolas Pitre" <nico@fluxnic.net>, "Eric Miao" <eric.miao@nvidia.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Chris Brandt <chris.brandt@renesas.com>, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH/RFC] ARM: boot: Relax kernel image alignment for RZ/A with CS3 SDRAM Date: Wed, 13 Nov 2019 11:27:29 +0100 [thread overview] Message-ID: <20191113102729.29303-1-geert+renesas@glider.be> (raw) The RZA2MEVB sub board has 64 MiB of SDRAM at 0x0C000000 (CS3 space). Hence the mask for CONFIG_AUTO_ZRELADDR needs to be changed, otherwise the system will crash because it will try to decompress a zImage or uImage to a non-RAM garbage address. Based on a patch in the BSP by Chris Brandt <chris.brandt@renesas.com>. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- No idea what to do with the rest of the comment, or if this breaks existing platforms. Thanks for your comments! --- arch/arm/boot/compressed/head.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S index 93dffed0ac6e02b4..cfee6bd1e7a0a582 100644 --- a/arch/arm/boot/compressed/head.S +++ b/arch/arm/boot/compressed/head.S @@ -231,10 +231,10 @@ not_angel: * address. * * This alignment is a balance between the requirements of - * different platforms - we have chosen 128MB to allow + * different platforms - we have chosen 64MB to allow * platforms which align the start of their physical memory - * to 128MB to use this feature, while allowing the zImage - * to be placed within the first 128MB of memory on other + * to 64MB to use this feature, while allowing the zImage + * to be placed within the first 64MB of memory on other * platforms. Increasing the alignment means we place * stricter alignment requirements on the start of physical * memory, but relaxing it means that we break people who @@ -242,7 +242,7 @@ not_angel: * of this range. */ mov r4, pc - and r4, r4, #0xf8000000 + and r4, r4, #0xfc000000 /* Determine final kernel image address. */ add r4, r4, #TEXT_OFFSET #else -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be> To: "Russell King" <linux@armlinux.org.uk>, "Arnd Bergmann" <arnd@arndb.de>, "Nicolas Pitre" <nico@fluxnic.net>, "Eric Miao" <eric.miao@nvidia.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: linux-renesas-soc@vger.kernel.org, Chris Brandt <chris.brandt@renesas.com>, Geert Uytterhoeven <geert+renesas@glider.be>, linux-arm-kernel@lists.infradead.org Subject: [PATCH/RFC] ARM: boot: Relax kernel image alignment for RZ/A with CS3 SDRAM Date: Wed, 13 Nov 2019 11:27:29 +0100 [thread overview] Message-ID: <20191113102729.29303-1-geert+renesas@glider.be> (raw) The RZA2MEVB sub board has 64 MiB of SDRAM at 0x0C000000 (CS3 space). Hence the mask for CONFIG_AUTO_ZRELADDR needs to be changed, otherwise the system will crash because it will try to decompress a zImage or uImage to a non-RAM garbage address. Based on a patch in the BSP by Chris Brandt <chris.brandt@renesas.com>. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- No idea what to do with the rest of the comment, or if this breaks existing platforms. Thanks for your comments! --- arch/arm/boot/compressed/head.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S index 93dffed0ac6e02b4..cfee6bd1e7a0a582 100644 --- a/arch/arm/boot/compressed/head.S +++ b/arch/arm/boot/compressed/head.S @@ -231,10 +231,10 @@ not_angel: * address. * * This alignment is a balance between the requirements of - * different platforms - we have chosen 128MB to allow + * different platforms - we have chosen 64MB to allow * platforms which align the start of their physical memory - * to 128MB to use this feature, while allowing the zImage - * to be placed within the first 128MB of memory on other + * to 64MB to use this feature, while allowing the zImage + * to be placed within the first 64MB of memory on other * platforms. Increasing the alignment means we place * stricter alignment requirements on the start of physical * memory, but relaxing it means that we break people who @@ -242,7 +242,7 @@ not_angel: * of this range. */ mov r4, pc - and r4, r4, #0xf8000000 + and r4, r4, #0xfc000000 /* Determine final kernel image address. */ add r4, r4, #TEXT_OFFSET #else -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-11-13 10:27 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-13 10:27 Geert Uytterhoeven [this message] 2019-11-13 10:27 ` [PATCH/RFC] ARM: boot: Relax kernel image alignment for RZ/A with CS3 SDRAM Geert Uytterhoeven 2019-11-13 10:39 ` Russell King - ARM Linux admin 2019-11-13 10:39 ` Russell King - ARM Linux admin 2019-11-13 10:50 ` Uwe Kleine-König 2019-11-13 10:50 ` Uwe Kleine-König 2019-11-13 13:32 ` Geert Uytterhoeven 2019-11-13 13:32 ` Geert Uytterhoeven 2019-11-13 17:04 ` Russell King - ARM Linux admin 2019-11-13 17:04 ` Russell King - ARM Linux admin 2019-11-13 18:34 ` Geert Uytterhoeven 2019-11-13 18:34 ` Geert Uytterhoeven 2019-11-13 10:40 ` Uwe Kleine-König 2019-11-13 10:40 ` Uwe Kleine-König 2019-11-13 10:44 ` Russell King - ARM Linux admin 2019-11-13 10:44 ` Russell King - ARM Linux admin 2019-11-13 13:16 ` Geert Uytterhoeven 2019-11-13 13:16 ` Geert Uytterhoeven 2019-11-13 16:56 ` Nicolas Pitre 2019-11-13 16:56 ` Nicolas Pitre
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191113102729.29303-1-geert+renesas@glider.be \ --to=geert+renesas@glider.be \ --cc=arnd@arndb.de \ --cc=chris.brandt@renesas.com \ --cc=eric.miao@nvidia.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=nico@fluxnic.net \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.