All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 1/2] drm/i915: move power domains dumped variable to drm_i915_private
Date: Fri, 15 Nov 2019 12:18:39 +0200	[thread overview]
Message-ID: <20191115101840.23921-1-jani.nikula@intel.com> (raw)

Get rid of the module specific static variable.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 10 +++-------
 drivers/gpu/drm/i915/display/intel_display_power.h |  1 +
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index ce1b64f4dd44..cbdf27705166 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -5277,13 +5277,9 @@ static void intel_power_domains_verify_state(struct drm_i915_private *i915)
 		}
 	}
 
-	if (dump_domain_info) {
-		static bool dumped;
-
-		if (!dumped) {
-			intel_power_domains_dump_info(i915);
-			dumped = true;
-		}
+	if (dump_domain_info && !power_domains->dumped) {
+		intel_power_domains_dump_info(i915);
+		power_domains->dumped = true;
 	}
 
 	mutex_unlock(&power_domains->lock);
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 1da04f3e0fb3..8af46661a10b 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -205,6 +205,7 @@ struct i915_power_domains {
 	 */
 	bool initializing;
 	bool display_core_suspended;
+	bool dumped;
 	int power_well_count;
 
 	intel_wakeref_t wakeref;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [Intel-gfx] [PATCH 1/2] drm/i915: move power domains dumped variable to drm_i915_private
Date: Fri, 15 Nov 2019 12:18:39 +0200	[thread overview]
Message-ID: <20191115101840.23921-1-jani.nikula@intel.com> (raw)
Message-ID: <20191115101839.45Xb1ALTAk4GLwIgno80m6fXconw6c8gCGumOwHi6rc@z> (raw)

Get rid of the module specific static variable.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 10 +++-------
 drivers/gpu/drm/i915/display/intel_display_power.h |  1 +
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index ce1b64f4dd44..cbdf27705166 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -5277,13 +5277,9 @@ static void intel_power_domains_verify_state(struct drm_i915_private *i915)
 		}
 	}
 
-	if (dump_domain_info) {
-		static bool dumped;
-
-		if (!dumped) {
-			intel_power_domains_dump_info(i915);
-			dumped = true;
-		}
+	if (dump_domain_info && !power_domains->dumped) {
+		intel_power_domains_dump_info(i915);
+		power_domains->dumped = true;
 	}
 
 	mutex_unlock(&power_domains->lock);
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 1da04f3e0fb3..8af46661a10b 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -205,6 +205,7 @@ struct i915_power_domains {
 	 */
 	bool initializing;
 	bool display_core_suspended;
+	bool dumped;
 	int power_well_count;
 
 	intel_wakeref_t wakeref;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2019-11-15 10:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 10:18 Jani Nikula [this message]
2019-11-15 10:18 ` [Intel-gfx] [PATCH 1/2] drm/i915: move power domains dumped variable to drm_i915_private Jani Nikula
2019-11-15 10:18 ` [PATCH 2/2] drm/i915: make debug printer shown_bug_once " Jani Nikula
2019-11-15 10:18   ` [Intel-gfx] " Jani Nikula
2019-11-15 10:20   ` Jani Nikula
2019-11-15 10:20     ` [Intel-gfx] " Jani Nikula
2019-11-15 10:21   ` Chris Wilson
2019-11-15 10:21     ` [Intel-gfx] " Chris Wilson
2019-11-15 11:04     ` Jani Nikula
2019-11-15 11:04       ` [Intel-gfx] " Jani Nikula
2019-11-15 11:08       ` Chris Wilson
2019-11-15 11:08         ` [Intel-gfx] " Chris Wilson
2019-12-11 10:36         ` Jani Nikula
2019-12-11 15:25           ` Joonas Lahtinen
2019-12-12  7:33             ` Vivi, Rodrigo
2019-12-12  7:34             ` Jani Nikula
2019-11-15 12:05 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: move power domains dumped " Patchwork
2019-11-15 12:05   ` [Intel-gfx] " Patchwork
2019-11-16 16:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-16 16:36   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115101840.23921-1-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.