All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915/gt: Mention which device failed
Date: Fri, 15 Nov 2019 12:23:43 +0000	[thread overview]
Message-ID: <20191115122343.821331-1-chris@chris-wilson.co.uk> (raw)

When telling the user that device power management is disabled, it is
helpful to say which device that was. At the same time, while it is a
mere inconvenience to the user, it is devastating to CI as this and
future tests may fail out of the blue.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
index 602a02d01850..b56a903431b8 100644
--- a/drivers/gpu/drm/i915/gt/intel_rc6.c
+++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
@@ -540,7 +540,9 @@ void intel_rc6_ctx_wa_check(struct intel_rc6 *rc6)
 	if (!intel_rc6_ctx_corrupted(rc6))
 		return;
 
-	DRM_NOTE("RC6 context corruption, disabling runtime power management\n");
+	dev_notice(i915->drm.dev,
+		   "RC6 context corruption, disabling runtime power management\n");
+	add_taint_for_CI(TAINT_WARN);
 
 	intel_rc6_disable(rc6);
 	rc6->ctx_corrupted = true;
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915/gt: Mention which device failed
Date: Fri, 15 Nov 2019 12:23:43 +0000	[thread overview]
Message-ID: <20191115122343.821331-1-chris@chris-wilson.co.uk> (raw)
Message-ID: <20191115122343.YSx8q6zuyHYGkx2fDAL5GF3a7L1e3PyssU48RkbYunw@z> (raw)

When telling the user that device power management is disabled, it is
helpful to say which device that was. At the same time, while it is a
mere inconvenience to the user, it is devastating to CI as this and
future tests may fail out of the blue.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
index 602a02d01850..b56a903431b8 100644
--- a/drivers/gpu/drm/i915/gt/intel_rc6.c
+++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
@@ -540,7 +540,9 @@ void intel_rc6_ctx_wa_check(struct intel_rc6 *rc6)
 	if (!intel_rc6_ctx_corrupted(rc6))
 		return;
 
-	DRM_NOTE("RC6 context corruption, disabling runtime power management\n");
+	dev_notice(i915->drm.dev,
+		   "RC6 context corruption, disabling runtime power management\n");
+	add_taint_for_CI(TAINT_WARN);
 
 	intel_rc6_disable(rc6);
 	rc6->ctx_corrupted = true;
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2019-11-15 12:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 12:23 Chris Wilson [this message]
2019-11-15 12:23 ` [Intel-gfx] [PATCH] drm/i915/gt: Mention which device failed Chris Wilson
2019-11-15 13:11 ` Imre Deak
2019-11-15 13:11   ` [Intel-gfx] " Imre Deak
2019-11-15 13:15   ` Imre Deak
2019-11-15 13:15     ` [Intel-gfx] " Imre Deak
2019-11-15 13:22     ` Chris Wilson
2019-11-15 13:22       ` [Intel-gfx] " Chris Wilson
2019-11-15 13:28       ` Chris Wilson
2019-11-15 13:28         ` [Intel-gfx] " Chris Wilson
2019-11-15 13:30         ` Imre Deak
2019-11-15 13:30           ` [Intel-gfx] " Imre Deak
2019-11-15 17:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-15 17:05   ` [Intel-gfx] " Patchwork
2019-11-17  2:10 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-17  2:10   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115122343.821331-1-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.