All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 08/14] drm/i915/gt: Move new timelines to the end of active_list
Date: Sun, 17 Nov 2019 21:03:24 +0000	[thread overview]
Message-ID: <20191117210330.2190963-8-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20191117210330.2190963-1-chris@chris-wilson.co.uk>

When adding a new active timeline, place it at the end of the list. This
allows for intel_gt_retire_requests() to pick up the newcomer more
quickly and hopefully complete the retirement sooner.

References: 7936a22dd466 ("drm/i915/gt: Wait for new requests in intel_gt_retire_requests()")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
index bd973d950064..b190a5d9ab02 100644
--- a/drivers/gpu/drm/i915/gt/intel_timeline.c
+++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
@@ -359,7 +359,7 @@ void intel_timeline_enter(struct intel_timeline *tl)
 
 	spin_lock(&timelines->lock);
 	if (!atomic_fetch_inc(&tl->active_count))
-		list_add(&tl->link, &timelines->active_list);
+		list_add_tail(&tl->link, &timelines->active_list);
 	spin_unlock(&timelines->lock);
 }
 
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 08/14] drm/i915/gt: Move new timelines to the end of active_list
Date: Sun, 17 Nov 2019 21:03:24 +0000	[thread overview]
Message-ID: <20191117210330.2190963-8-chris@chris-wilson.co.uk> (raw)
Message-ID: <20191117210324.tS0wzcBB-OVlfL9AE5dqnU7mvd5G66APlViWwtBhoOM@z> (raw)
In-Reply-To: <20191117210330.2190963-1-chris@chris-wilson.co.uk>

When adding a new active timeline, place it at the end of the list. This
allows for intel_gt_retire_requests() to pick up the newcomer more
quickly and hopefully complete the retirement sooner.

References: 7936a22dd466 ("drm/i915/gt: Wait for new requests in intel_gt_retire_requests()")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
index bd973d950064..b190a5d9ab02 100644
--- a/drivers/gpu/drm/i915/gt/intel_timeline.c
+++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
@@ -359,7 +359,7 @@ void intel_timeline_enter(struct intel_timeline *tl)
 
 	spin_lock(&timelines->lock);
 	if (!atomic_fetch_inc(&tl->active_count))
-		list_add(&tl->link, &timelines->active_list);
+		list_add_tail(&tl->link, &timelines->active_list);
 	spin_unlock(&timelines->lock);
 }
 
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-17 21:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-17 21:03 [PATCH 01/14] drm/i915/gt: Close race between engine_park and intel_gt_retire_requests Chris Wilson
2019-11-17 21:03 ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 02/14] drm/i915: Mark up the calling context for intel_wakeref_put() Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 03/14] drm/i915/gem: Merge GGTT vma flush into a single loop Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 04/14] drm/i915/gt: Only wait for register chipset flush if active Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 05/14] drm/i915: Protect the obj->vma.list during iteration Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 06/14] drm/i915: Wait until the intel_wakeref idle callback is complete Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 07/14] drm/i915/gt: Declare timeline.lock to be irq-free Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` Chris Wilson [this message]
2019-11-17 21:03   ` [Intel-gfx] [PATCH 08/14] drm/i915/gt: Move new timelines to the end of active_list Chris Wilson
2019-11-17 21:03 ` [PATCH 09/14] drm/i915/gt: Schedule next retirement worker first Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 10/14] drm/i915/gt: Flush the requests after wedging on suspend Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 11/14] drm/i915/selftests: Flush the active callbacks Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 12/14] drm/i915/selftests: Be explicit in ERR_PTR handling Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 13/14] drm/i915/selftests: Exercise rc6 handling Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:03 ` [PATCH 14/14] drm/i915/gt: Track engine round-trip times Chris Wilson
2019-11-17 21:03   ` [Intel-gfx] " Chris Wilson
2019-11-17 21:14 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/14] drm/i915/gt: Close race between engine_park and intel_gt_retire_requests Patchwork
2019-11-17 21:14   ` [Intel-gfx] " Patchwork
2019-11-17 21:35 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-17 21:35   ` [Intel-gfx] " Patchwork
2019-11-18  1:47 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-18  1:47   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191117210330.2190963-8-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.