From: Tero Kristo <t-kristo@ti.com> To: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, s-anna@ti.com, Tero Kristo <t-kristo@ti.com> Subject: [PATCHv2 05/15] remoteproc/omap: Add the rproc ops .da_to_va() implementation Date: Tue, 19 Nov 2019 16:16:35 +0200 [thread overview] Message-ID: <20191119141645.19777-6-t-kristo@ti.com> (raw) In-Reply-To: <20191119141645.19777-1-t-kristo@ti.com> From: Suman Anna <s-anna@ti.com> An implementation for the rproc ops .da_to_va() has been added that provides the address translation between device addresses to kernel virtual addresses for internal RAMs present on that particular remote processor device. The implementation provides the translations based on the addresses parsed and stored during the probe. This ops gets invoked by the exported rproc_da_to_va() function and allows the remoteproc core's ELF loader to be able to load program data directly into the internal memories. Signed-off-by: Suman Anna <s-anna@ti.com> Signed-off-by: Tero Kristo <t-kristo@ti.com> --- v2: - minor cleanups of code, fixed kerneldoc comments drivers/remoteproc/omap_remoteproc.c | 39 ++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c index 844703507a74..28f14e24b389 100644 --- a/drivers/remoteproc/omap_remoteproc.c +++ b/drivers/remoteproc/omap_remoteproc.c @@ -232,10 +232,49 @@ static int omap_rproc_stop(struct rproc *rproc) return 0; } +/** + * omap_rproc_da_to_va() - internal memory translation helper + * @rproc: remote processor to apply the address translation for + * @da: device address to translate + * @len: length of the memory buffer + * + * Custom function implementing the rproc .da_to_va ops to provide address + * translation (device address to kernel virtual address) for internal RAMs + * present in a DSP or IPU device). The translated addresses can be used + * either by the remoteproc core for loading, or by any rpmsg bus drivers. + * Returns the translated virtual address in kernel memory space, or NULL + * in failure. + */ +static void *omap_rproc_da_to_va(struct rproc *rproc, u64 da, int len) +{ + struct omap_rproc *oproc = rproc->priv; + int i; + u32 offset; + + if (len <= 0) + return NULL; + + if (!oproc->num_mems) + return NULL; + + for (i = 0; i < oproc->num_mems; i++) { + if (da >= oproc->mem[i].dev_addr && da + len <= + oproc->mem[i].dev_addr + oproc->mem[i].size) { + offset = da - oproc->mem[i].dev_addr; + /* __force to make sparse happy with type conversion */ + return (__force void *)(oproc->mem[i].cpu_addr + + offset); + } + } + + return NULL; +} + static const struct rproc_ops omap_rproc_ops = { .start = omap_rproc_start, .stop = omap_rproc_stop, .kick = omap_rproc_kick, + .da_to_va = omap_rproc_da_to_va, }; static const char * const ipu_mem_names[] = { -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com> To: <bjorn.andersson@linaro.org>, <ohad@wizery.com>, <linux-remoteproc@vger.kernel.org> Cc: <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>, <s-anna@ti.com>, Tero Kristo <t-kristo@ti.com> Subject: [PATCHv2 05/15] remoteproc/omap: Add the rproc ops .da_to_va() implementation Date: Tue, 19 Nov 2019 16:16:35 +0200 [thread overview] Message-ID: <20191119141645.19777-6-t-kristo@ti.com> (raw) In-Reply-To: <20191119141645.19777-1-t-kristo@ti.com> From: Suman Anna <s-anna@ti.com> An implementation for the rproc ops .da_to_va() has been added that provides the address translation between device addresses to kernel virtual addresses for internal RAMs present on that particular remote processor device. The implementation provides the translations based on the addresses parsed and stored during the probe. This ops gets invoked by the exported rproc_da_to_va() function and allows the remoteproc core's ELF loader to be able to load program data directly into the internal memories. Signed-off-by: Suman Anna <s-anna@ti.com> Signed-off-by: Tero Kristo <t-kristo@ti.com> --- v2: - minor cleanups of code, fixed kerneldoc comments drivers/remoteproc/omap_remoteproc.c | 39 ++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c index 844703507a74..28f14e24b389 100644 --- a/drivers/remoteproc/omap_remoteproc.c +++ b/drivers/remoteproc/omap_remoteproc.c @@ -232,10 +232,49 @@ static int omap_rproc_stop(struct rproc *rproc) return 0; } +/** + * omap_rproc_da_to_va() - internal memory translation helper + * @rproc: remote processor to apply the address translation for + * @da: device address to translate + * @len: length of the memory buffer + * + * Custom function implementing the rproc .da_to_va ops to provide address + * translation (device address to kernel virtual address) for internal RAMs + * present in a DSP or IPU device). The translated addresses can be used + * either by the remoteproc core for loading, or by any rpmsg bus drivers. + * Returns the translated virtual address in kernel memory space, or NULL + * in failure. + */ +static void *omap_rproc_da_to_va(struct rproc *rproc, u64 da, int len) +{ + struct omap_rproc *oproc = rproc->priv; + int i; + u32 offset; + + if (len <= 0) + return NULL; + + if (!oproc->num_mems) + return NULL; + + for (i = 0; i < oproc->num_mems; i++) { + if (da >= oproc->mem[i].dev_addr && da + len <= + oproc->mem[i].dev_addr + oproc->mem[i].size) { + offset = da - oproc->mem[i].dev_addr; + /* __force to make sparse happy with type conversion */ + return (__force void *)(oproc->mem[i].cpu_addr + + offset); + } + } + + return NULL; +} + static const struct rproc_ops omap_rproc_ops = { .start = omap_rproc_start, .stop = omap_rproc_stop, .kick = omap_rproc_kick, + .da_to_va = omap_rproc_da_to_va, }; static const char * const ipu_mem_names[] = { -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-11-19 14:16 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-19 14:16 [PATCHv2 00/15] Remoteproc: updates for OMAP remoteproc support Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2.5 01/15] dt-bindings: remoteproc: Add OMAP remoteproc bindings Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 02/15] remoteproc/omap: Add device tree support Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 03/15] remoteproc/omap: Add a sanity check for DSP boot address alignment Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 04/15] remoteproc/omap: Add support to parse internal memories from DT Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` Tero Kristo [this message] 2019-11-19 14:16 ` [PATCHv2 05/15] remoteproc/omap: Add the rproc ops .da_to_va() implementation Tero Kristo 2019-11-19 14:16 ` [PATCHv2 06/15] remoteproc/omap: Initialize and assign reserved memory node Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 07/15] remoteproc/omap: Add support for DRA7xx remote processors Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 08/15] remoteproc/omap: Remove the unused fields from platform data Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 09/15] remoteproc/omap: Remove the omap_rproc_reserve_cma declaration Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 10/15] remoteproc/omap: Check for undefined mailbox messages Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 11/15] remoteproc/omap: Request a timer(s) for remoteproc usage Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 12/15] remoteproc/omap: add support for system suspend/resume Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 13/15] remoteproc/omap: add support for runtime auto-suspend/resume Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 14/15] remoteproc/omap: report device exceptions and trigger recovery Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 14:16 ` [PATCHv2 15/15] remoteproc/omap: add watchdog functionality for remote processors Tero Kristo 2019-11-19 14:16 ` Tero Kristo 2019-11-19 17:31 ` [PATCHv2 00/15] Remoteproc: updates for OMAP remoteproc support Mathieu Poirier 2019-11-19 18:07 ` Mathieu Poirier 2019-11-20 11:28 ` Tero Kristo 2019-11-20 11:28 ` Tero Kristo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191119141645.19777-6-t-kristo@ti.com \ --to=t-kristo@ti.com \ --cc=bjorn.andersson@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=ohad@wizery.com \ --cc=s-anna@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.