All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com,
	qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com
Subject: [PATCH v2 1/6] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter
Date: Wed, 20 Nov 2019 19:44:56 +0100	[thread overview]
Message-ID: <20191120184501.28159-2-kwolf@redhat.com> (raw)
In-Reply-To: <20191120184501.28159-1-kwolf@redhat.com>

bdrv_co_do_pwrite_zeroes() can already cope with maximum request sizes
by calling the driver in a loop until everything is done. Make the small
remaining change that is necessary to let it accept a 64 bit byte count.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
---
 block/io.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/block/io.c b/block/io.c
index f75777f5ea..003f4ea38c 100644
--- a/block/io.c
+++ b/block/io.c
@@ -42,7 +42,7 @@
 
 static void bdrv_parent_cb_resize(BlockDriverState *bs);
 static int coroutine_fn bdrv_co_do_pwrite_zeroes(BlockDriverState *bs,
-    int64_t offset, int bytes, BdrvRequestFlags flags);
+    int64_t offset, int64_t bytes, BdrvRequestFlags flags);
 
 static void bdrv_parent_drained_begin(BlockDriverState *bs, BdrvChild *ignore,
                                       bool ignore_bds_parents)
@@ -1730,7 +1730,7 @@ int coroutine_fn bdrv_co_preadv_part(BdrvChild *child,
 }
 
 static int coroutine_fn bdrv_co_do_pwrite_zeroes(BlockDriverState *bs,
-    int64_t offset, int bytes, BdrvRequestFlags flags)
+    int64_t offset, int64_t bytes, BdrvRequestFlags flags)
 {
     BlockDriver *drv = bs->drv;
     QEMUIOVector qiov;
@@ -1760,7 +1760,7 @@ static int coroutine_fn bdrv_co_do_pwrite_zeroes(BlockDriverState *bs,
     assert(max_write_zeroes >= bs->bl.request_alignment);
 
     while (bytes > 0 && !ret) {
-        int num = bytes;
+        int num = MIN(bytes, BDRV_REQUEST_MAX_BYTES);
 
         /* Align request.  Block drivers can expect the "bulk" of the request
          * to be aligned, and that unaligned requests do not cross cluster
-- 
2.20.1



  reply	other threads:[~2019-11-20 18:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 18:44 [PATCH for-4.2? v2 0/6] block: Fix resize (extending) of short overlays Kevin Wolf
2019-11-20 18:44 ` Kevin Wolf [this message]
2019-11-20 18:44 ` [PATCH v2 2/6] block: truncate: Don't make backing file data visible Kevin Wolf
2019-11-20 21:15   ` Eric Blake
2019-11-21 11:22     ` Kevin Wolf
2019-11-21  8:59   ` Max Reitz
2019-11-21  9:46     ` Vladimir Sementsov-Ogievskiy
2019-11-21 11:34     ` Kevin Wolf
2019-11-21 12:21       ` Max Reitz
2019-11-21 14:33         ` Kevin Wolf
2019-11-21 15:25           ` Max Reitz
2019-11-22 14:07           ` Alberto Garcia
2019-11-22 14:27   ` Alberto Garcia
2019-11-20 18:44 ` [PATCH v2 3/6] iotests: Add qemu_io_log() Kevin Wolf
2019-11-21 13:35   ` Alberto Garcia
2019-11-20 18:44 ` [PATCH v2 4/6] iotests: Fix timeout in run_job() Kevin Wolf
2019-11-21 13:34   ` Alberto Garcia
2019-11-20 18:45 ` [PATCH v2 5/6] iotests: Support job-complete " Kevin Wolf
2019-11-21 13:35   ` Alberto Garcia
2019-11-20 18:45 ` [PATCH v2 6/6] iotests: Test committing to short backing file Kevin Wolf
2019-11-20 21:27   ` Eric Blake
2019-11-21  9:36     ` Vladimir Sementsov-Ogievskiy
2019-11-21 10:24   ` Vladimir Sementsov-Ogievskiy
2019-11-21 10:28   ` Vladimir Sementsov-Ogievskiy
2019-11-21 10:30     ` Vladimir Sementsov-Ogievskiy
2019-11-21 11:39       ` Kevin Wolf
2019-11-21 13:02         ` Vladimir Sementsov-Ogievskiy
2019-11-21 14:09 ` [PATCH for-4.2? v2 0/6] block: Fix resize (extending) of short overlays Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120184501.28159-2-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.