All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: linux-nfs@vger.kernel.org
Cc: Petr Vorel <petr.vorel@gmail.com>, Steve Dickson <steved@redhat.com>
Subject: [nfs-utils PATCH 1/1] mount: Fix return 0 from void function
Date: Fri, 22 Nov 2019 17:25:28 +0100	[thread overview]
Message-ID: <20191122162528.18199-1-petr.vorel@gmail.com> (raw)

Fixes: d5e30346 ("mount: Do not overwrite /etc/mtab if it's symlink")

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Hi Steve,

sorry for introducing a regression.

Kind regards,
Petr

 utils/mount/mount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/mount/mount.c b/utils/mount/mount.c
index 92a0dfe4..2be3dc2f 100644
--- a/utils/mount/mount.c
+++ b/utils/mount/mount.c
@@ -208,7 +208,7 @@ create_mtab (void) {
 	   that would create a file /proc/mounts in case the proc filesystem
 	   is not mounted, and the fchmod below would also fail. */
 	if (mtab_is_a_symlink()) {
-		return EX_SUCCESS;
+		return;
 	}
 
 	lock_mtab();
-- 
2.24.0


             reply	other threads:[~2019-11-22 16:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 16:25 Petr Vorel [this message]
2019-11-22 18:09 ` [nfs-utils PATCH 1/1] mount: Fix return 0 from void function Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191122162528.18199-1-petr.vorel@gmail.com \
    --to=petr.vorel@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.