All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 03/16] scripts/kallsyms: set relative_base more effectively
Date: Sat, 23 Nov 2019 22:27:14 +0900	[thread overview]
Message-ID: <20191123132727.30151-4-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <20191123132727.30151-1-yamada.masahiro@socionext.com>

Currently, record_relative_base() iterates over the entire table to
find the minimum address, but it is not efficient because we sort
the table anyway.

After sort_symbol(), the table is sorted by address. (kallsyms parses
the 'nm -n' output, so the data is already sorted by address, but this
commit does not rely on it.)

Move record_relative_base() after sort_symbols(), and take the first
non-absolute symbol value.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 scripts/kallsyms.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 79641874d860..0959e1de381c 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -731,11 +731,15 @@ static void record_relative_base(void)
 {
 	unsigned int i;
 
-	relative_base = -1ULL;
 	for (i = 0; i < table_cnt; i++)
-		if (!symbol_absolute(&table[i]) &&
-		    table[i].addr < relative_base)
+		if (!symbol_absolute(&table[i])) {
+			/*
+			 * The table is sorted by address.
+			 * Take the first non-absolute symbol value.
+			 */
 			relative_base = table[i].addr;
+			return;
+		}
 }
 
 int main(int argc, char **argv)
@@ -758,9 +762,9 @@ int main(int argc, char **argv)
 	read_map(stdin);
 	if (absolute_percpu)
 		make_percpus_absolute();
+	sort_symbols();
 	if (base_relative)
 		record_relative_base();
-	sort_symbols();
 	optimize_token_table();
 	write_src();
 
-- 
2.17.1


  parent reply	other threads:[~2019-11-23 13:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 13:27 [PATCH 00/16] scripts/kallsyms: various cleanups and optimizations Masahiro Yamada
2019-11-23 13:27 ` [PATCH 01/16] scripts/kallsyms: remove unneeded #ifndef ARRAY_SIZE Masahiro Yamada
2019-11-23 13:27 ` [PATCH 02/16] scripts/kallsyms: fix definitely-lost memory leak Masahiro Yamada
2019-11-23 13:27 ` Masahiro Yamada [this message]
2019-11-23 13:27 ` [PATCH 04/16] scripts/kallsyms: remove redundant is_arm_mapping_symbol() Masahiro Yamada
2019-11-23 13:27 ` [PATCH 05/16] scripts/kallsyms: remove unneeded length check for prefix matching Masahiro Yamada
2019-11-23 13:27 ` [PATCH 06/16] scripts/kallsyms: add sym_name() to mitigate cast ugliness Masahiro Yamada
2019-11-23 13:27 ` [PATCH 07/16] scripts/kallsyms: replace prefix_underscores_count() with strspn() Masahiro Yamada
2019-11-23 13:27 ` [PATCH 08/16] scripts/kallsyms: make find_token() return (unsigned char *) Masahiro Yamada
2019-11-23 13:27 ` [PATCH 09/16] scripts/kallsyms: add const qualifiers where possible Masahiro Yamada
2019-11-23 13:27 ` [PATCH 10/16] scripts/kallsyms: skip ignored symbols very early Masahiro Yamada
2019-11-23 13:27 ` [PATCH 11/16] scripts/kallsyms: move more patterns to the ignored_prefixes array Masahiro Yamada
2019-11-23 13:27 ` [PATCH 12/16] scripts/kallsyms: move ignored symbol types to is_ignored_symbol() Masahiro Yamada
2019-11-23 13:27 ` [PATCH 13/16] scripts/kallsyms: make check_symbol_range() void function Masahiro Yamada
2019-11-23 13:27 ` [PATCH 14/16] scripts/kallsyms: check no valid symbol earlier Masahiro Yamada
2019-11-23 13:27 ` [PATCH 15/16] scripts/kallsyms: put check_symbol_range() calls close together Masahiro Yamada
2019-11-23 13:27 ` [PATCH 16/16] scripts/kallsyms: remove redundant initializers Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191123132727.30151-4-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.