All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Bolshakov <r.bolshakov@yadro.com>
To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: linux@yadro.com, Roman Bolshakov <r.bolshakov@yadro.com>,
	Quinn Tran <qutran@marvell.com>,
	Himanshu Madhani <hmadhani@marvel.com>,
	Hannes Reinecke <hare@suse.de>
Subject: [PATCH v3 07/13] scsi: qla2xxx: Don't call qlt_async_event twice
Date: Mon, 25 Nov 2019 16:56:56 +0000	[thread overview]
Message-ID: <20191125165702.1013-8-r.bolshakov@yadro.com> (raw)
In-Reply-To: <20191125165702.1013-1-r.bolshakov@yadro.com>

MBA_PORT_UPDATE generates duplicate log lines in target mode because
qlt_async_event is called twice. Drop the calls within the case as
the function will be called right after the switch statement.

Cc: Quinn Tran <qutran@marvell.com>
Acked-by: Himanshu Madhani <hmadhani@marvel.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
 drivers/scsi/qla2xxx/qla_isr.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 1b8f297449cf..c6274178b0b0 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -1061,8 +1061,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
 			ql_dbg(ql_dbg_async, vha, 0x5011,
 			    "Asynchronous PORT UPDATE ignored %04x/%04x/%04x.\n",
 			    mb[1], mb[2], mb[3]);
-
-			qlt_async_event(mb[0], vha, mb);
 			break;
 		}
 
@@ -1079,8 +1077,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
 		set_bit(LOOP_RESYNC_NEEDED, &vha->dpc_flags);
 		set_bit(LOCAL_LOOP_UPDATE, &vha->dpc_flags);
 		set_bit(VP_CONFIG_OK, &vha->vp_flags);
-
-		qlt_async_event(mb[0], vha, mb);
 		break;
 
 	case MBA_RSCN_UPDATE:		/* State Change Registration */
-- 
2.24.0

WARNING: multiple messages have this Message-ID (diff)
From: Roman Bolshakov <r.bolshakov@yadro.com>
To: <linux-scsi@vger.kernel.org>, <target-devel@vger.kernel.org>
Cc: <linux@yadro.com>, Roman Bolshakov <r.bolshakov@yadro.com>,
	Quinn Tran <qutran@marvell.com>,
	Himanshu Madhani <hmadhani@marvel.com>,
	Hannes Reinecke <hare@suse.de>
Subject: [PATCH v3 07/13] scsi: qla2xxx: Don't call qlt_async_event twice
Date: Mon, 25 Nov 2019 19:56:56 +0300	[thread overview]
Message-ID: <20191125165702.1013-8-r.bolshakov@yadro.com> (raw)
In-Reply-To: <20191125165702.1013-1-r.bolshakov@yadro.com>

MBA_PORT_UPDATE generates duplicate log lines in target mode because
qlt_async_event is called twice. Drop the calls within the case as
the function will be called right after the switch statement.

Cc: Quinn Tran <qutran@marvell.com>
Acked-by: Himanshu Madhani <hmadhani@marvel.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
 drivers/scsi/qla2xxx/qla_isr.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 1b8f297449cf..c6274178b0b0 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -1061,8 +1061,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
 			ql_dbg(ql_dbg_async, vha, 0x5011,
 			    "Asynchronous PORT UPDATE ignored %04x/%04x/%04x.\n",
 			    mb[1], mb[2], mb[3]);
-
-			qlt_async_event(mb[0], vha, mb);
 			break;
 		}
 
@@ -1079,8 +1077,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
 		set_bit(LOOP_RESYNC_NEEDED, &vha->dpc_flags);
 		set_bit(LOCAL_LOOP_UPDATE, &vha->dpc_flags);
 		set_bit(VP_CONFIG_OK, &vha->vp_flags);
-
-		qlt_async_event(mb[0], vha, mb);
 		break;
 
 	case MBA_RSCN_UPDATE:		/* State Change Registration */
-- 
2.24.0


  parent reply	other threads:[~2019-11-25 16:56 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 16:56 [PATCH v3 00/13] scsi: qla2xxx: Bug fixes Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 01/13] scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd Roman Bolshakov
2019-11-25 16:56   ` Roman Bolshakov
2019-11-26 20:55   ` Bart Van Assche
2019-11-26 20:55     ` Bart Van Assche
2019-11-25 16:56 ` [PATCH v3 02/13] scsi: qla2xxx: Use explicit LOGO in target mode Roman Bolshakov
2019-11-25 16:56   ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 03/13] scsi: qla2xxx: Initialize free_work before flushing it Roman Bolshakov
2019-11-25 16:56   ` Roman Bolshakov
2019-11-26 20:55   ` Bart Van Assche
2019-11-26 20:55     ` Bart Van Assche
2019-11-25 16:56 ` [PATCH v3 04/13] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work Roman Bolshakov
2019-11-25 16:56   ` Roman Bolshakov
2019-11-26 20:56   ` Bart Van Assche
2019-11-26 20:56     ` Bart Van Assche
2019-11-25 16:56 ` [PATCH v3 05/13] scsi: qla2xxx: Change discovery state before PLOGI Roman Bolshakov
2019-11-25 16:56   ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 06/13] scsi: qla2xxx: Allow PLOGI in target mode Roman Bolshakov
2019-11-25 16:56   ` Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov [this message]
2019-11-25 16:56   ` [PATCH v3 07/13] scsi: qla2xxx: Don't call qlt_async_event twice Roman Bolshakov
2019-11-25 17:00   ` Roman Bolshakov
2019-11-25 17:00     ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 08/13] scsi: qla2xxx: Fix PLOGI payload and ELS IOCB dump length Roman Bolshakov
2019-11-25 16:56   ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 09/13] scsi: qla2xxx: Configure local loop for N2N target Roman Bolshakov
2019-11-25 16:56   ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 10/13] scsi: qla2xxx: Send Notify ACK after N2N PLOGI Roman Bolshakov
2019-11-25 16:56   ` Roman Bolshakov
2019-11-25 16:57 ` [PATCH v3 11/13] scsi: qla2xxx: Don't defer relogin unconditonally Roman Bolshakov
2019-11-25 16:57   ` Roman Bolshakov
2019-11-25 16:57 ` [PATCH v3 12/13] scsi: qla2xxx: Ignore PORT UPDATE after N2N PLOGI Roman Bolshakov
2019-11-25 16:57   ` Roman Bolshakov
2019-11-25 16:57 ` [PATCH v3 13/13] scsi: qla2xxx: Add debug dump of LOGO payload and ELS IOCB Roman Bolshakov
2019-11-25 16:57   ` Roman Bolshakov
2019-11-26 20:57   ` Bart Van Assche
2019-11-26 20:57     ` Bart Van Assche
2019-11-26 20:56 ` [PATCH v3 00/13] scsi: qla2xxx: Bug fixes Bart Van Assche
2019-11-26 20:56   ` Bart Van Assche
2019-11-27 17:24   ` Roman Bolshakov
2019-11-27 17:24     ` Roman Bolshakov
2019-11-27 17:34     ` Bart Van Assche
2019-11-27 17:34       ` Bart Van Assche
2019-11-28 12:18       ` Martin K. Petersen
2019-11-28 12:18         ` Martin K. Petersen
2019-12-09 23:36 ` Martin K. Petersen
2019-12-09 23:36   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125165702.1013-8-r.bolshakov@yadro.com \
    --to=r.bolshakov@yadro.com \
    --cc=hare@suse.de \
    --cc=hmadhani@marvel.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@yadro.com \
    --cc=qutran@marvell.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.