From: Georgi Djakov <georgi.djakov@linaro.org>
To: linux-pm@vger.kernel.org
Cc: bjorn.andersson@linaro.org, agross@kernel.org, digetx@gmail.com,
evgreen@chromium.org, daidavid1@codeaurora.org,
masneyb@onstation.org, sibis@codeaurora.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
georgi.djakov@linaro.org
Subject: [PATCH 3/5] interconnect: qcom: msm8974: Walk the list safely on node removal
Date: Thu, 28 Nov 2019 15:34:33 +0200 [thread overview]
Message-ID: <20191128133435.25667-3-georgi.djakov@linaro.org> (raw)
In-Reply-To: <20191128133435.25667-1-georgi.djakov@linaro.org>
As we will remove items off the list using list_del(), we need to use the
safe version of list_for_each_entry().
Fixes: 4e60a9568dc6 ("interconnect: qcom: add msm8974 driver")
Reported-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
drivers/interconnect/qcom/msm8974.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/interconnect/qcom/msm8974.c b/drivers/interconnect/qcom/msm8974.c
index ce599a0c83d9..0a1a8ba6afa7 100644
--- a/drivers/interconnect/qcom/msm8974.c
+++ b/drivers/interconnect/qcom/msm8974.c
@@ -732,7 +732,7 @@ static int msm8974_icc_probe(struct platform_device *pdev)
return 0;
err_del_icc:
- list_for_each_entry(node, &provider->nodes, node_list) {
+ list_for_each_entry_safe(node, &provider->nodes, node_list) {
icc_node_del(node);
icc_node_destroy(node->id);
}
@@ -750,7 +750,7 @@ static int msm8974_icc_remove(struct platform_device *pdev)
struct icc_provider *provider = &qp->provider;
struct icc_node *n;
- list_for_each_entry(n, &provider->nodes, node_list) {
+ list_for_each_entry_safe(n, &provider->nodes, node_list) {
icc_node_del(n);
icc_node_destroy(n->id);
}
next prev parent reply other threads:[~2019-11-28 13:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 13:34 [PATCH 1/5] interconnect: qcom: sdm845: Walk the list safely on node removal Georgi Djakov
2019-11-28 13:34 ` [PATCH 2/5] interconnect: qcom: qcs404: " Georgi Djakov
2019-11-28 13:34 ` Georgi Djakov [this message]
2019-11-28 15:15 ` [PATCH 3/5] interconnect: qcom: msm8974: " Brian Masney
2019-11-28 13:34 ` [PATCH 4/5] interconnect: Add a common helper for removing all nodes Georgi Djakov
2019-11-28 18:20 ` Bjorn Andersson
2019-11-28 13:34 ` [PATCH 5/5] interconnect: qcom: Use the new common helper for node removal Georgi Djakov
2019-11-28 13:43 ` Dmitry Osipenko
2019-11-28 13:52 ` Georgi Djakov
2019-11-28 18:14 ` [PATCH 1/5] interconnect: qcom: sdm845: Walk the list safely on " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128133435.25667-3-georgi.djakov@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=digetx@gmail.com \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.