From: Marco Felsch <m.felsch@pengutronix.de> To: support.opensource@diasemi.com, lee.jones@linaro.org, robh+dt@kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, joel@jms.id.au, andrew@aj.id.au, lgirdwood@gmail.com, broonie@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH v3 4/6] regulator: da9062: add voltage selection gpio support Date: Fri, 29 Nov 2019 18:25:35 +0100 [thread overview] Message-ID: <20191129172537.31410-5-m.felsch@pengutronix.de> (raw) In-Reply-To: <20191129172537.31410-1-m.felsch@pengutronix.de> The DA9062/1 devices can switch their regulator voltages between voltage-A (active) and voltage-B (suspend) settings. Switching the voltages can be controlled by ther internal state-machine or by a gpio input signal and can be configured for each individual regulator. This commit adds the gpio-based voltage switching support. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- Changelog: v3: - make use of <linux/gpio/private.h> - add comment to vsel_gpi - append vsel_gpi to da9062_regulator_info instead of insert it in the middle v2: - use new public api gpiod_to_offset() - add -ENOENT error check to mimic devm_gpio_optional - add local gpio check for hardening the code --- drivers/regulator/da9062-regulator.c | 174 +++++++++++++++++++++++++++ 1 file changed, 174 insertions(+) diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062-regulator.c index 710e67081d53..6117e631236b 100644 --- a/drivers/regulator/da9062-regulator.c +++ b/drivers/regulator/da9062-regulator.c @@ -7,6 +7,8 @@ #include <linux/module.h> #include <linux/init.h> #include <linux/err.h> +#include <linux/gpio/consumer.h> +#include <linux/gpio/private.h> /* for gpiod_to_offset() */ #include <linux/slab.h> #include <linux/of.h> #include <linux/platform_device.h> @@ -52,6 +54,16 @@ struct da9062_regulator_info { unsigned int suspend_vsel_reg; /* Event detection bit */ struct reg_field oc_event; + /* + * The DA9062 can use its own general purpose inputs to control the + * regulators. Each regulator can be configured independently. So the + * DA9062 is a consumer of its own provided general purpose inputs. + * + * vsel_gpi: + * The input port which is used by a regulator to select between + * voltage-a/b settings. + */ + struct reg_field vsel_gpi; }; /* Single regulator settings */ @@ -65,6 +77,7 @@ struct da9062_regulator { struct regmap_field *suspend; struct regmap_field *sleep; struct regmap_field *suspend_sleep; + struct regmap_field *vsel_gpi; }; /* Encapsulates all information for the regulators driver */ @@ -351,6 +364,81 @@ static const struct regulator_ops da9062_ldo_ops = { .set_suspend_mode = da9062_ldo_set_suspend_mode, }; +static int da9062_config_gpi(struct device_node *np, + const struct regulator_desc *desc, + struct regulator_config *cfg, const char *gpi_id) +{ + struct da9062_regulator *regl = cfg->driver_data; + struct device *hw = regl->hw->dev; + struct device_node *gpio_np; + struct gpio_desc *gpi; + unsigned int nr; + int ret; + char *prop, *label; + + prop = kasprintf(GFP_KERNEL, "dlg,%s-sense-gpios", gpi_id); + if (!prop) + return -ENOMEM; + + label = kasprintf(GFP_KERNEL, "%s-%s-gpi", desc->name, gpi_id); + if (!label) { + ret = -ENOMEM; + goto free; + } + + /* + * We only must ensure that the gpio device is probed before the + * regulator driver so no need to store the reference global. Luckily + * devm_* releases the gpio upon a remove action. The gpio's are + * optional so we need to check for ENOENT. Also we need to check for + * the GPIOLIB support. Do nothing if the property or the gpiolib is + * missing. + */ + gpi = devm_gpiod_get_from_of_node(cfg->dev, np, prop, 0, GPIOD_IN | + GPIOD_FLAGS_BIT_NONEXCLUSIVE, label); + if (IS_ERR(gpi)) { + ret = PTR_ERR(gpi); + if (ret == -ENOENT || ret == -ENOSYS) + ret = 0; + goto free; + } + + /* + * Only local gpios are valid. The gpio-controller is within the + * mfd-root node. + */ + gpio_np = of_parse_phandle(np, prop, 0); + if (gpio_np != hw->of_node) { + of_node_put(gpio_np); + dev_err(hw, "Failed to request %s.\n", prop); + ret = -EINVAL; + goto free; + } + of_node_put(gpio_np); + + /* We need the local number */ + nr = gpiod_to_offset(gpi); + if (nr < 1 || nr > 3) { + ret = -EINVAL; + goto free; + } + + ret = regmap_field_write(regl->vsel_gpi, nr); + +free: + kfree(prop); + kfree(label); + + return ret; +} + +static int da9062_parse_dt(struct device_node *np, + const struct regulator_desc *desc, + struct regulator_config *cfg) +{ + return da9062_config_gpi(np, desc, cfg, "vsel"); +} + /* DA9061 Regulator information */ static const struct da9062_regulator_info local_da9061_regulator_info[] = { { @@ -358,6 +446,7 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { .desc.name = "DA9061 BUCK1", .desc.of_match = of_match_ptr("buck1"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (300) * 1000, .desc.uV_step = (10) * 1000, @@ -388,12 +477,17 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK1_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK1_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK1_CONT, + __builtin_ffs((int)DA9062AA_VBUCK1_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK1_GPI_MASK) - 1), }, { .desc.id = DA9061_ID_BUCK2, .desc.name = "DA9061 BUCK2", .desc.of_match = of_match_ptr("buck2"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (800) * 1000, .desc.uV_step = (20) * 1000, @@ -424,12 +518,17 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK3_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK3_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK3_CONT, + __builtin_ffs((int)DA9062AA_VBUCK3_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK3_GPI_MASK) - 1), }, { .desc.id = DA9061_ID_BUCK3, .desc.name = "DA9061 BUCK3", .desc.of_match = of_match_ptr("buck3"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (530) * 1000, .desc.uV_step = (10) * 1000, @@ -460,12 +559,17 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK4_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK4_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK4_CONT, + __builtin_ffs((int)DA9062AA_VBUCK4_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK4_GPI_MASK) - 1), }, { .desc.id = DA9061_ID_LDO1, .desc.name = "DA9061 LDO1", .desc.of_match = of_match_ptr("ldo1"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -489,6 +593,10 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO1_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO1_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO1_CONT, + __builtin_ffs((int)DA9062AA_VLDO1_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO1_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO1_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -499,6 +607,7 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { .desc.name = "DA9061 LDO2", .desc.of_match = of_match_ptr("ldo2"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -522,6 +631,10 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO2_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO2_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO2_CONT, + __builtin_ffs((int)DA9062AA_VLDO2_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO2_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO2_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -532,6 +645,7 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { .desc.name = "DA9061 LDO3", .desc.of_match = of_match_ptr("ldo3"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -555,6 +669,10 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO3_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO3_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO3_CONT, + __builtin_ffs((int)DA9062AA_VLDO3_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO3_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO3_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -565,6 +683,7 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { .desc.name = "DA9061 LDO4", .desc.of_match = of_match_ptr("ldo4"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -588,6 +707,10 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO4_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO4_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO4_CONT, + __builtin_ffs((int)DA9062AA_VLDO4_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO4_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO4_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -602,6 +725,7 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { .desc.name = "DA9062 BUCK1", .desc.of_match = of_match_ptr("buck1"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (300) * 1000, .desc.uV_step = (10) * 1000, @@ -632,12 +756,17 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK1_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK1_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK1_CONT, + __builtin_ffs((int)DA9062AA_VBUCK1_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK1_GPI_MASK) - 1), }, { .desc.id = DA9062_ID_BUCK2, .desc.name = "DA9062 BUCK2", .desc.of_match = of_match_ptr("buck2"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (300) * 1000, .desc.uV_step = (10) * 1000, @@ -668,12 +797,17 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK2_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK2_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK2_CONT, + __builtin_ffs((int)DA9062AA_VBUCK2_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK2_GPI_MASK) - 1), }, { .desc.id = DA9062_ID_BUCK3, .desc.name = "DA9062 BUCK3", .desc.of_match = of_match_ptr("buck3"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (800) * 1000, .desc.uV_step = (20) * 1000, @@ -704,12 +838,17 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK3_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK3_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK3_CONT, + __builtin_ffs((int)DA9062AA_VBUCK3_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK3_GPI_MASK) - 1), }, { .desc.id = DA9062_ID_BUCK4, .desc.name = "DA9062 BUCK4", .desc.of_match = of_match_ptr("buck4"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (530) * 1000, .desc.uV_step = (10) * 1000, @@ -740,12 +879,17 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK4_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK4_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK4_CONT, + __builtin_ffs((int)DA9062AA_VBUCK4_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK4_GPI_MASK) - 1), }, { .desc.id = DA9062_ID_LDO1, .desc.name = "DA9062 LDO1", .desc.of_match = of_match_ptr("ldo1"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -769,6 +913,10 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO1_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO1_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO1_CONT, + __builtin_ffs((int)DA9062AA_VLDO1_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO1_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO1_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -779,6 +927,7 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { .desc.name = "DA9062 LDO2", .desc.of_match = of_match_ptr("ldo2"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -802,6 +951,10 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO2_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO2_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO2_CONT, + __builtin_ffs((int)DA9062AA_VLDO2_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO2_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO2_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -812,6 +965,7 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { .desc.name = "DA9062 LDO3", .desc.of_match = of_match_ptr("ldo3"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -835,6 +989,10 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO3_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO3_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO3_CONT, + __builtin_ffs((int)DA9062AA_VLDO3_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO3_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO3_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -845,6 +1003,7 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { .desc.name = "DA9062 LDO4", .desc.of_match = of_match_ptr("ldo4"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -868,6 +1027,10 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO4_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO4_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO4_CONT, + __builtin_ffs((int)DA9062AA_VLDO4_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO4_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO4_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -988,6 +1151,15 @@ static int da9062_regulator_probe(struct platform_device *pdev) return PTR_ERR(regl->suspend_sleep); } + if (regl->info->vsel_gpi.reg) { + regl->vsel_gpi = devm_regmap_field_alloc( + &pdev->dev, + chip->regmap, + regl->info->vsel_gpi); + if (IS_ERR(regl->vsel_gpi)) + return PTR_ERR(regl->vsel_gpi); + } + /* Register regulator */ memset(&config, 0, sizeof(config)); config.dev = chip->dev; @@ -997,6 +1169,8 @@ static int da9062_regulator_probe(struct platform_device *pdev) regl->rdev = devm_regulator_register(&pdev->dev, ®l->desc, &config); if (IS_ERR(regl->rdev)) { + if (PTR_ERR(regl->rdev) == -EPROBE_DEFER) + return -EPROBE_DEFER; dev_err(&pdev->dev, "Failed to register %s regulator\n", regl->desc.name); -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Marco Felsch <m.felsch@pengutronix.de> To: support.opensource@diasemi.com, lee.jones@linaro.org, robh+dt@kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, joel@jms.id.au, andrew@aj.id.au, lgirdwood@gmail.com, broonie@kernel.org Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 4/6] regulator: da9062: add voltage selection gpio support Date: Fri, 29 Nov 2019 18:25:35 +0100 [thread overview] Message-ID: <20191129172537.31410-5-m.felsch@pengutronix.de> (raw) In-Reply-To: <20191129172537.31410-1-m.felsch@pengutronix.de> The DA9062/1 devices can switch their regulator voltages between voltage-A (active) and voltage-B (suspend) settings. Switching the voltages can be controlled by ther internal state-machine or by a gpio input signal and can be configured for each individual regulator. This commit adds the gpio-based voltage switching support. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- Changelog: v3: - make use of <linux/gpio/private.h> - add comment to vsel_gpi - append vsel_gpi to da9062_regulator_info instead of insert it in the middle v2: - use new public api gpiod_to_offset() - add -ENOENT error check to mimic devm_gpio_optional - add local gpio check for hardening the code --- drivers/regulator/da9062-regulator.c | 174 +++++++++++++++++++++++++++ 1 file changed, 174 insertions(+) diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062-regulator.c index 710e67081d53..6117e631236b 100644 --- a/drivers/regulator/da9062-regulator.c +++ b/drivers/regulator/da9062-regulator.c @@ -7,6 +7,8 @@ #include <linux/module.h> #include <linux/init.h> #include <linux/err.h> +#include <linux/gpio/consumer.h> +#include <linux/gpio/private.h> /* for gpiod_to_offset() */ #include <linux/slab.h> #include <linux/of.h> #include <linux/platform_device.h> @@ -52,6 +54,16 @@ struct da9062_regulator_info { unsigned int suspend_vsel_reg; /* Event detection bit */ struct reg_field oc_event; + /* + * The DA9062 can use its own general purpose inputs to control the + * regulators. Each regulator can be configured independently. So the + * DA9062 is a consumer of its own provided general purpose inputs. + * + * vsel_gpi: + * The input port which is used by a regulator to select between + * voltage-a/b settings. + */ + struct reg_field vsel_gpi; }; /* Single regulator settings */ @@ -65,6 +77,7 @@ struct da9062_regulator { struct regmap_field *suspend; struct regmap_field *sleep; struct regmap_field *suspend_sleep; + struct regmap_field *vsel_gpi; }; /* Encapsulates all information for the regulators driver */ @@ -351,6 +364,81 @@ static const struct regulator_ops da9062_ldo_ops = { .set_suspend_mode = da9062_ldo_set_suspend_mode, }; +static int da9062_config_gpi(struct device_node *np, + const struct regulator_desc *desc, + struct regulator_config *cfg, const char *gpi_id) +{ + struct da9062_regulator *regl = cfg->driver_data; + struct device *hw = regl->hw->dev; + struct device_node *gpio_np; + struct gpio_desc *gpi; + unsigned int nr; + int ret; + char *prop, *label; + + prop = kasprintf(GFP_KERNEL, "dlg,%s-sense-gpios", gpi_id); + if (!prop) + return -ENOMEM; + + label = kasprintf(GFP_KERNEL, "%s-%s-gpi", desc->name, gpi_id); + if (!label) { + ret = -ENOMEM; + goto free; + } + + /* + * We only must ensure that the gpio device is probed before the + * regulator driver so no need to store the reference global. Luckily + * devm_* releases the gpio upon a remove action. The gpio's are + * optional so we need to check for ENOENT. Also we need to check for + * the GPIOLIB support. Do nothing if the property or the gpiolib is + * missing. + */ + gpi = devm_gpiod_get_from_of_node(cfg->dev, np, prop, 0, GPIOD_IN | + GPIOD_FLAGS_BIT_NONEXCLUSIVE, label); + if (IS_ERR(gpi)) { + ret = PTR_ERR(gpi); + if (ret == -ENOENT || ret == -ENOSYS) + ret = 0; + goto free; + } + + /* + * Only local gpios are valid. The gpio-controller is within the + * mfd-root node. + */ + gpio_np = of_parse_phandle(np, prop, 0); + if (gpio_np != hw->of_node) { + of_node_put(gpio_np); + dev_err(hw, "Failed to request %s.\n", prop); + ret = -EINVAL; + goto free; + } + of_node_put(gpio_np); + + /* We need the local number */ + nr = gpiod_to_offset(gpi); + if (nr < 1 || nr > 3) { + ret = -EINVAL; + goto free; + } + + ret = regmap_field_write(regl->vsel_gpi, nr); + +free: + kfree(prop); + kfree(label); + + return ret; +} + +static int da9062_parse_dt(struct device_node *np, + const struct regulator_desc *desc, + struct regulator_config *cfg) +{ + return da9062_config_gpi(np, desc, cfg, "vsel"); +} + /* DA9061 Regulator information */ static const struct da9062_regulator_info local_da9061_regulator_info[] = { { @@ -358,6 +446,7 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { .desc.name = "DA9061 BUCK1", .desc.of_match = of_match_ptr("buck1"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (300) * 1000, .desc.uV_step = (10) * 1000, @@ -388,12 +477,17 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK1_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK1_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK1_CONT, + __builtin_ffs((int)DA9062AA_VBUCK1_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK1_GPI_MASK) - 1), }, { .desc.id = DA9061_ID_BUCK2, .desc.name = "DA9061 BUCK2", .desc.of_match = of_match_ptr("buck2"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (800) * 1000, .desc.uV_step = (20) * 1000, @@ -424,12 +518,17 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK3_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK3_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK3_CONT, + __builtin_ffs((int)DA9062AA_VBUCK3_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK3_GPI_MASK) - 1), }, { .desc.id = DA9061_ID_BUCK3, .desc.name = "DA9061 BUCK3", .desc.of_match = of_match_ptr("buck3"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (530) * 1000, .desc.uV_step = (10) * 1000, @@ -460,12 +559,17 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK4_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK4_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK4_CONT, + __builtin_ffs((int)DA9062AA_VBUCK4_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK4_GPI_MASK) - 1), }, { .desc.id = DA9061_ID_LDO1, .desc.name = "DA9061 LDO1", .desc.of_match = of_match_ptr("ldo1"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -489,6 +593,10 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO1_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO1_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO1_CONT, + __builtin_ffs((int)DA9062AA_VLDO1_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO1_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO1_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -499,6 +607,7 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { .desc.name = "DA9061 LDO2", .desc.of_match = of_match_ptr("ldo2"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -522,6 +631,10 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO2_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO2_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO2_CONT, + __builtin_ffs((int)DA9062AA_VLDO2_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO2_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO2_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -532,6 +645,7 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { .desc.name = "DA9061 LDO3", .desc.of_match = of_match_ptr("ldo3"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -555,6 +669,10 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO3_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO3_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO3_CONT, + __builtin_ffs((int)DA9062AA_VLDO3_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO3_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO3_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -565,6 +683,7 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { .desc.name = "DA9061 LDO4", .desc.of_match = of_match_ptr("ldo4"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -588,6 +707,10 @@ static const struct da9062_regulator_info local_da9061_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO4_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO4_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO4_CONT, + __builtin_ffs((int)DA9062AA_VLDO4_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO4_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO4_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -602,6 +725,7 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { .desc.name = "DA9062 BUCK1", .desc.of_match = of_match_ptr("buck1"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (300) * 1000, .desc.uV_step = (10) * 1000, @@ -632,12 +756,17 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK1_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK1_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK1_CONT, + __builtin_ffs((int)DA9062AA_VBUCK1_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK1_GPI_MASK) - 1), }, { .desc.id = DA9062_ID_BUCK2, .desc.name = "DA9062 BUCK2", .desc.of_match = of_match_ptr("buck2"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (300) * 1000, .desc.uV_step = (10) * 1000, @@ -668,12 +797,17 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK2_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK2_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK2_CONT, + __builtin_ffs((int)DA9062AA_VBUCK2_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK2_GPI_MASK) - 1), }, { .desc.id = DA9062_ID_BUCK3, .desc.name = "DA9062 BUCK3", .desc.of_match = of_match_ptr("buck3"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (800) * 1000, .desc.uV_step = (20) * 1000, @@ -704,12 +838,17 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK3_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK3_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK3_CONT, + __builtin_ffs((int)DA9062AA_VBUCK3_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK3_GPI_MASK) - 1), }, { .desc.id = DA9062_ID_BUCK4, .desc.name = "DA9062 BUCK4", .desc.of_match = of_match_ptr("buck4"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_buck_ops, .desc.min_uV = (530) * 1000, .desc.uV_step = (10) * 1000, @@ -740,12 +879,17 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_BUCK4_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_BUCK4_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_BUCK4_CONT, + __builtin_ffs((int)DA9062AA_VBUCK4_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VBUCK4_GPI_MASK) - 1), }, { .desc.id = DA9062_ID_LDO1, .desc.name = "DA9062 LDO1", .desc.of_match = of_match_ptr("ldo1"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -769,6 +913,10 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO1_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO1_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO1_CONT, + __builtin_ffs((int)DA9062AA_VLDO1_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO1_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO1_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -779,6 +927,7 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { .desc.name = "DA9062 LDO2", .desc.of_match = of_match_ptr("ldo2"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -802,6 +951,10 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO2_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO2_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO2_CONT, + __builtin_ffs((int)DA9062AA_VLDO2_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO2_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO2_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -812,6 +965,7 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { .desc.name = "DA9062 LDO3", .desc.of_match = of_match_ptr("ldo3"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -835,6 +989,10 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO3_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO3_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO3_CONT, + __builtin_ffs((int)DA9062AA_VLDO3_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO3_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO3_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -845,6 +1003,7 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { .desc.name = "DA9062 LDO4", .desc.of_match = of_match_ptr("ldo4"), .desc.regulators_node = of_match_ptr("regulators"), + .desc.of_parse_cb = da9062_parse_dt, .desc.ops = &da9062_ldo_ops, .desc.min_uV = (900) * 1000, .desc.uV_step = (50) * 1000, @@ -868,6 +1027,10 @@ static const struct da9062_regulator_info local_da9062_regulator_info[] = { __builtin_ffs((int)DA9062AA_LDO4_CONF_MASK) - 1, sizeof(unsigned int) * 8 - __builtin_clz(DA9062AA_LDO4_CONF_MASK) - 1), + .vsel_gpi = REG_FIELD(DA9062AA_LDO4_CONT, + __builtin_ffs((int)DA9062AA_VLDO4_GPI_MASK) - 1, + sizeof(unsigned int) * 8 - + __builtin_clz(DA9062AA_VLDO4_GPI_MASK) - 1), .oc_event = REG_FIELD(DA9062AA_STATUS_D, __builtin_ffs((int)DA9062AA_LDO4_ILIM_MASK) - 1, sizeof(unsigned int) * 8 - @@ -988,6 +1151,15 @@ static int da9062_regulator_probe(struct platform_device *pdev) return PTR_ERR(regl->suspend_sleep); } + if (regl->info->vsel_gpi.reg) { + regl->vsel_gpi = devm_regmap_field_alloc( + &pdev->dev, + chip->regmap, + regl->info->vsel_gpi); + if (IS_ERR(regl->vsel_gpi)) + return PTR_ERR(regl->vsel_gpi); + } + /* Register regulator */ memset(&config, 0, sizeof(config)); config.dev = chip->dev; @@ -997,6 +1169,8 @@ static int da9062_regulator_probe(struct platform_device *pdev) regl->rdev = devm_regulator_register(&pdev->dev, ®l->desc, &config); if (IS_ERR(regl->rdev)) { + if (PTR_ERR(regl->rdev) == -EPROBE_DEFER) + return -EPROBE_DEFER; dev_err(&pdev->dev, "Failed to register %s regulator\n", regl->desc.name); -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-29 17:26 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-29 17:25 [PATCH v3 0/6] DA9062 PMIC features Marco Felsch 2019-11-29 17:25 ` Marco Felsch 2019-11-29 17:25 ` [PATCH v3 1/6] gpio: treewide rename gpio_chip_hwgpio to gpiod_to_offset Marco Felsch 2019-11-29 17:25 ` Marco Felsch 2019-12-02 2:59 ` Andrew Jeffery 2019-12-02 2:59 ` Andrew Jeffery 2019-11-29 17:25 ` [PATCH v3 2/6] gpio: make gpiod_to_offset() available for other users Marco Felsch 2019-11-29 17:25 ` Marco Felsch 2019-12-02 3:00 ` Andrew Jeffery 2019-12-02 3:00 ` Andrew Jeffery 2019-11-29 17:25 ` [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage selection documentation Marco Felsch 2019-11-29 17:25 ` Marco Felsch 2019-12-04 13:46 ` Mark Brown 2019-12-04 13:46 ` Mark Brown 2019-12-10 9:41 ` Marco Felsch 2019-12-10 9:41 ` Marco Felsch 2019-12-11 16:14 ` Adam Thomson 2019-12-11 16:14 ` Adam Thomson 2019-12-11 17:09 ` Marco Felsch 2019-12-11 17:09 ` Marco Felsch 2019-12-12 15:08 ` Linus Walleij 2019-12-12 15:08 ` Linus Walleij 2019-12-12 15:55 ` Marco Felsch 2019-12-12 15:55 ` Marco Felsch 2019-12-12 16:10 ` Mark Brown 2019-12-12 16:10 ` Mark Brown 2019-12-12 16:21 ` Marco Felsch 2019-12-12 16:21 ` Marco Felsch 2019-12-12 16:51 ` Mark Brown 2019-12-12 16:51 ` Mark Brown 2019-12-16 8:55 ` Marco Felsch 2019-12-16 8:55 ` Marco Felsch 2019-12-16 11:44 ` Mark Brown 2019-12-16 11:44 ` Mark Brown 2019-12-17 7:35 ` Marco Felsch 2019-12-17 7:35 ` Marco Felsch 2019-12-17 12:58 ` Mark Brown 2019-12-17 12:58 ` Mark Brown 2020-01-07 8:36 ` Marco Felsch 2020-01-07 8:36 ` Marco Felsch 2020-01-07 13:09 ` Mark Brown 2020-01-07 13:09 ` Mark Brown 2020-01-07 13:38 ` Marco Felsch 2020-01-07 13:38 ` Marco Felsch 2020-01-14 15:43 ` Mark Brown 2020-01-14 15:43 ` Mark Brown 2019-12-16 16:32 ` Adam Thomson 2019-12-16 16:32 ` Adam Thomson 2019-12-17 9:00 ` Marco Felsch 2019-12-17 9:00 ` Marco Felsch 2019-12-17 9:12 ` Marco Felsch 2019-12-17 9:12 ` Marco Felsch 2019-12-17 9:53 ` Adam Thomson 2019-12-17 9:53 ` Adam Thomson 2019-12-17 12:31 ` Marco Felsch 2019-12-17 12:31 ` Marco Felsch 2019-12-17 13:13 ` Adam Thomson 2019-12-17 13:13 ` Adam Thomson 2019-12-16 16:32 ` Adam Thomson 2019-12-16 16:32 ` Adam Thomson 2019-12-16 12:28 ` Linus Walleij 2019-12-16 12:28 ` Linus Walleij 2019-11-29 17:25 ` Marco Felsch [this message] 2019-11-29 17:25 ` [PATCH v3 4/6] regulator: da9062: add voltage selection gpio support Marco Felsch 2019-11-29 17:25 ` [PATCH v3 5/6] dt-bindings: mfd: da9062: add regulator gpio enable/disable documentation Marco Felsch 2019-11-29 17:25 ` Marco Felsch 2019-12-13 22:23 ` Rob Herring 2019-12-13 22:23 ` Rob Herring 2019-12-16 16:31 ` Lee Jones 2019-12-16 16:31 ` Lee Jones 2019-11-29 17:25 ` [PATCH v3 6/6] regulator: da9062: add gpio based regulator dis-/enable support Marco Felsch 2019-11-29 17:25 ` Marco Felsch 2019-12-02 11:44 ` [PATCH v3 0/6] DA9062 PMIC features Linus Walleij 2019-12-02 11:44 ` Linus Walleij 2019-12-02 12:04 ` Lee Jones 2019-12-02 12:04 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191129172537.31410-5-m.felsch@pengutronix.de \ --to=m.felsch@pengutronix.de \ --cc=andrew@aj.id.au \ --cc=bgolaszewski@baylibre.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=kernel@pengutronix.de \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=support.opensource@diasemi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.