From: Thierry Reding <thierry.reding@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v2 9/9] drm/tegra: Run hub cleanup on ->remove()
Date: Tue, 3 Dec 2019 17:19:14 +0100 [thread overview]
Message-ID: <20191203161914.1312555-9-thierry.reding@gmail.com> (raw)
In-Reply-To: <20191203161914.1312555-1-thierry.reding@gmail.com>
From: Thierry Reding <treding@nvidia.com>
The call to tegra_display_hub_cleanup() that takes care of disabling the
window groups is missing from the driver's ->remove() callback. Call it
to make sure the runtime PM reference counts for the display controllers
are balanced.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpu/drm/tegra/drm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 7a16b51eaa2d..f455ce71e85d 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -1241,6 +1241,9 @@ static int host1x_drm_remove(struct host1x_device *dev)
drm_atomic_helper_shutdown(drm);
drm_mode_config_cleanup(drm);
+ if (tegra->hub)
+ tegra_display_hub_cleanup(tegra->hub);
+
err = host1x_device_exit(dev);
if (err < 0)
dev_err(&dev->dev, "host1x device cleanup failed: %d\n", err);
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-12-03 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 16:19 [PATCH v2 1/9] drm/tegra: hub: Remove bogus connection mutex check Thierry Reding
2019-12-03 16:19 ` [PATCH v2 2/9] drm/tegra: gem: Properly pin imported buffers Thierry Reding
2019-12-03 16:19 ` [PATCH v2 3/9] drm/tegra: gem: Remove premature import restrictions Thierry Reding
2019-12-03 16:19 ` [PATCH v2 4/9] drm/tegra: Use proper IOVA address for cursor image Thierry Reding
2019-12-03 16:19 ` [PATCH v2 5/9] drm/tegra: sor: Implement system suspend/resume Thierry Reding
2019-12-09 0:40 ` Dmitry Osipenko
2019-12-03 16:19 ` [PATCH v2 6/9] drm/tegra: vic: Export module device table Thierry Reding
2019-12-03 16:19 ` [PATCH v2 7/9] drm/tegra: Silence expected errors on IOMMU attach Thierry Reding
2019-12-03 16:19 ` [PATCH v2 8/9] drm/tegra: sor: Make the +5V HDMI supply optional Thierry Reding
2019-12-03 16:19 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203161914.1312555-9-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.