All of lore.kernel.org
 help / color / mirror / Atom feed
From: 加藤一博 <kato-k@ksysllc.co.jp>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Cc: "kazuhiro kato" <kazuhiro.kato@hotmail.co.jp>,
	加藤一博 <kato-k@ksysllc.co.jp>
Subject: [PATCH] gitk: fix branch name encoding error on gitk
Date: Sat, 7 Dec 2019 00:32:25 +0000	[thread overview]
Message-ID: <20191207003203.9612-1-kato-k@ksysllc.co.jp> (raw)

From: Kazuhiro Kato <kazuhiro.kato@hotmail.co.jp>

After "git checkout -b '漢字'" to create a branch with UTF-8
character in it, "gitk" shows the branch name incorrectly, as it
forgets to turn the bytes read from the "git show-ref" command
into Unicode characters.

Signed-off-by: Kazuhiro Kato <kato-k@ksysllc.co.jp>
---
 gitk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gitk b/gitk
index abe4805..3f61a5b 100755
--- a/gitk
+++ b/gitk
@@ -1780,11 +1780,15 @@ proc readrefs {} {
     global otherrefids idotherrefs mainhead mainheadid
     global selecthead selectheadid
     global hideremotes
+    global tclencoding
 
     foreach v {tagids idtags headids idheads otherrefids idotherrefs} {
 	unset -nocomplain $v
     }
     set refd [open [list | git show-ref -d] r]
+    if {$tclencoding != {}} {
+	fconfigure $refd -encoding $tclencoding
+    }
     while {[gets $refd line] >= 0} {
 	if {[string index $line 40] ne " "} continue
 	set id [string range $line 0 39]
-- 
2.20.1.windows.1


             reply	other threads:[~2019-12-07  0:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-07  0:32 加藤一博 [this message]
2019-12-09 19:19 ` [PATCH] gitk: fix branch name encoding error on gitk Junio C Hamano
2019-12-15  4:29 ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191207003203.9612-1-kato-k@ksysllc.co.jp \
    --to=kato-k@ksysllc.co.jp \
    --cc=git@vger.kernel.org \
    --cc=kazuhiro.kato@hotmail.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.