From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org Cc: "Thomas Huth" <thuth@redhat.com>, "Stefano Stabellini" <sstabellini@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Paul Durrant" <paul@xen.org>, "Markus Armbruster" <armbru@redhat.com>, "Alex Williamson" <alex.williamson@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Anthony Perard" <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, "Philippe Mathieu-Daudé" <philmd@redhat.com> Subject: [PATCH-for-5.0 v3 4/6] hw/pci-host/i440fx: Use definitions instead of magic values Date: Mon, 9 Dec 2019 10:50:00 +0100 [thread overview] Message-ID: <20191209095002.32194-5-philmd@redhat.com> (raw) In-Reply-To: <20191209095002.32194-1-philmd@redhat.com> Use definitions from "hw/pci/pci_regs.h". This also helps when using git-grep. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/pci-host/i440fx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index 0cc80b276d..414138595b 100644 --- a/hw/pci-host/i440fx.c +++ b/hw/pci-host/i440fx.c @@ -376,13 +376,13 @@ typedef struct { /* Here we just expose minimal host bridge offset subset. */ static const IGDHostInfo igd_host_bridge_infos[] = { - {0x08, 2}, /* revision id */ - {0x2c, 2}, /* sybsystem vendor id */ - {0x2e, 2}, /* sybsystem id */ - {0x50, 2}, /* SNB: processor graphics control register */ - {0x52, 2}, /* processor graphics control register */ - {0xa4, 4}, /* SNB: graphics base of stolen memory */ - {0xa8, 4}, /* SNB: base of GTT stolen memory */ + {PCI_REVISION_ID, 2}, + {PCI_SUBSYSTEM_VENDOR_ID, 2}, + {PCI_SUBSYSTEM_ID, 2}, + {0x50, 2}, /* SNB: processor graphics control register */ + {0x52, 2}, /* processor graphics control register */ + {0xa4, 4}, /* SNB: graphics base of stolen memory */ + {0xa8, 4}, /* SNB: base of GTT stolen memory */ }; static void host_pci_config_read(int pos, int len, uint32_t *val, Error **errp) -- 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org Cc: "Thomas Huth" <thuth@redhat.com>, "Stefano Stabellini" <sstabellini@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Paul Durrant" <paul@xen.org>, "Markus Armbruster" <armbru@redhat.com>, "Alex Williamson" <alex.williamson@redhat.com>, "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Anthony Perard" <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, "Philippe Mathieu-Daudé" <philmd@redhat.com> Subject: [Xen-devel] [PATCH-for-5.0 v3 4/6] hw/pci-host/i440fx: Use definitions instead of magic values Date: Mon, 9 Dec 2019 10:50:00 +0100 [thread overview] Message-ID: <20191209095002.32194-5-philmd@redhat.com> (raw) In-Reply-To: <20191209095002.32194-1-philmd@redhat.com> Use definitions from "hw/pci/pci_regs.h". This also helps when using git-grep. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/pci-host/i440fx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index 0cc80b276d..414138595b 100644 --- a/hw/pci-host/i440fx.c +++ b/hw/pci-host/i440fx.c @@ -376,13 +376,13 @@ typedef struct { /* Here we just expose minimal host bridge offset subset. */ static const IGDHostInfo igd_host_bridge_infos[] = { - {0x08, 2}, /* revision id */ - {0x2c, 2}, /* sybsystem vendor id */ - {0x2e, 2}, /* sybsystem id */ - {0x50, 2}, /* SNB: processor graphics control register */ - {0x52, 2}, /* processor graphics control register */ - {0xa4, 4}, /* SNB: graphics base of stolen memory */ - {0xa8, 4}, /* SNB: base of GTT stolen memory */ + {PCI_REVISION_ID, 2}, + {PCI_SUBSYSTEM_VENDOR_ID, 2}, + {PCI_SUBSYSTEM_ID, 2}, + {0x50, 2}, /* SNB: processor graphics control register */ + {0x52, 2}, /* processor graphics control register */ + {0xa4, 4}, /* SNB: graphics base of stolen memory */ + {0xa8, 4}, /* SNB: base of GTT stolen memory */ }; static void host_pci_config_read(int pos, int len, uint32_t *val, Error **errp) -- 2.21.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-09 9:51 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-09 9:49 [PATCH-for-5.0 v3 0/6] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through Philippe Mathieu-Daudé 2019-12-09 9:49 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-12-09 9:49 ` [PATCH-for-5.0 v3 1/6] hw/pci-host/i440fx: Correct the header description Philippe Mathieu-Daudé 2019-12-09 9:49 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-12-09 10:02 ` Thomas Huth 2019-12-09 10:02 ` [Xen-devel] " Thomas Huth 2019-12-18 11:57 ` Laurent Vivier 2019-12-18 11:57 ` [Xen-devel] " Laurent Vivier 2019-12-09 9:49 ` [PATCH-for-5.0 v3 2/6] hw/pci-host/i440fx: Extract PCII440FXState to "hw/pci-host/i440fx.h" Philippe Mathieu-Daudé 2019-12-09 9:49 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-12-09 10:03 ` Thomas Huth 2019-12-09 10:03 ` [Xen-devel] " Thomas Huth 2019-12-09 9:49 ` [PATCH-for-5.0 v3 3/6] hw/pci-host/i440fx: Use size_t to iterate over ARRAY_SIZE() Philippe Mathieu-Daudé 2019-12-09 9:49 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-12-09 10:05 ` Thomas Huth 2019-12-09 10:05 ` [Xen-devel] " Thomas Huth 2019-12-18 11:57 ` Laurent Vivier 2019-12-18 11:57 ` [Xen-devel] " Laurent Vivier 2019-12-18 12:01 ` Paolo Bonzini 2019-12-18 12:01 ` [Xen-devel] " Paolo Bonzini 2019-12-18 12:31 ` Laurent Vivier 2019-12-18 12:31 ` [Xen-devel] " Laurent Vivier 2019-12-09 9:50 ` Philippe Mathieu-Daudé [this message] 2019-12-09 9:50 ` [Xen-devel] [PATCH-for-5.0 v3 4/6] hw/pci-host/i440fx: Use definitions instead of magic values Philippe Mathieu-Daudé 2019-12-09 10:08 ` Thomas Huth 2019-12-09 10:08 ` [Xen-devel] " Thomas Huth 2019-12-09 9:50 ` [PATCH-for-5.0 v3 5/6] hw/pci-host/i440fx: Extract the IGD passthrough host bridge device Philippe Mathieu-Daudé 2019-12-09 9:50 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-12-09 10:08 ` Durrant, Paul 2019-12-09 10:08 ` Durrant, Paul 2019-12-09 9:50 ` [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge Philippe Mathieu-Daudé 2019-12-09 9:50 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-12-09 10:10 ` Durrant, Paul 2019-12-09 10:10 ` Durrant, Paul 2019-12-09 10:42 ` Paolo Bonzini 2019-12-09 10:42 ` Paolo Bonzini 2019-12-09 10:56 ` Philippe Mathieu-Daudé 2019-12-09 10:56 ` Philippe Mathieu-Daudé 2019-12-09 11:12 ` Paolo Bonzini 2019-12-09 11:12 ` Paolo Bonzini 2019-12-09 10:39 ` Paolo Bonzini 2019-12-09 10:39 ` [Xen-devel] " Paolo Bonzini 2019-12-09 18:39 ` [PATCH-for-5.0 v3 0/6] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through no-reply 2019-12-09 18:39 ` [Xen-devel] " no-reply 2019-12-09 18:49 ` no-reply 2019-12-09 18:49 ` [Xen-devel] " no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191209095002.32194-5-philmd@redhat.com \ --to=philmd@redhat.com \ --cc=alex.williamson@redhat.com \ --cc=anthony.perard@citrix.com \ --cc=armbru@redhat.com \ --cc=mst@redhat.com \ --cc=paul@xen.org \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=sstabellini@kernel.org \ --cc=thuth@redhat.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.