From: Sudeep Holla <sudeep.holla@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi <cristian.marussi@arm.com> Subject: [PATCH 09/15] firmware: arm_scmi: Add scmi protocol version and id device attributes Date: Tue, 10 Dec 2019 14:53:39 +0000 [thread overview] Message-ID: <20191210145345.11616-10-sudeep.holla@arm.com> (raw) In-Reply-To: <20191210145345.11616-1-sudeep.holla@arm.com> Linux kernel bus driver management layer provides way to add set of default attributes of the devices on the bus. Using the same, let's add the scmi per protocol version and id attributes to the sysfs. It helps to identify the individual protocol details from the sysfs entries similar to the SCMI protocol and firmware version. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/firmware/arm_scmi/bus.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c index f619da2634a6..ed0ed02f7158 100644 --- a/drivers/firmware/arm_scmi/bus.c +++ b/drivers/firmware/arm_scmi/bus.c @@ -92,11 +92,38 @@ static int scmi_dev_remove(struct device *dev) return 0; } +static ssize_t protocol_version_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct scmi_device *scmi_dev = to_scmi_dev(dev); + + return sprintf(buf, "%u.%u\n", PROTOCOL_REV_MAJOR(scmi_dev->version), + PROTOCOL_REV_MINOR(scmi_dev->version)); +} +static DEVICE_ATTR_RO(protocol_version); + +static ssize_t protocol_id_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct scmi_device *scmi_dev = to_scmi_dev(dev); + + return sprintf(buf, "%u\n", scmi_dev->protocol_id); +} +static DEVICE_ATTR_RO(protocol_id); + +static struct attribute *versions_attrs[] = { + &dev_attr_protocol_version.attr, + &dev_attr_protocol_id.attr, + NULL, +}; +ATTRIBUTE_GROUPS(versions); + static struct bus_type scmi_bus_type = { .name = "scmi_protocol", .match = scmi_dev_match, .probe = scmi_dev_probe, .remove = scmi_dev_remove, + .dev_groups = versions_groups, }; int scmi_driver_register(struct scmi_driver *driver, struct module *owner, -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Cristian Marussi <cristian.marussi@arm.com>, Sudeep Holla <sudeep.holla@arm.com> Subject: [PATCH 09/15] firmware: arm_scmi: Add scmi protocol version and id device attributes Date: Tue, 10 Dec 2019 14:53:39 +0000 [thread overview] Message-ID: <20191210145345.11616-10-sudeep.holla@arm.com> (raw) In-Reply-To: <20191210145345.11616-1-sudeep.holla@arm.com> Linux kernel bus driver management layer provides way to add set of default attributes of the devices on the bus. Using the same, let's add the scmi per protocol version and id attributes to the sysfs. It helps to identify the individual protocol details from the sysfs entries similar to the SCMI protocol and firmware version. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/firmware/arm_scmi/bus.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c index f619da2634a6..ed0ed02f7158 100644 --- a/drivers/firmware/arm_scmi/bus.c +++ b/drivers/firmware/arm_scmi/bus.c @@ -92,11 +92,38 @@ static int scmi_dev_remove(struct device *dev) return 0; } +static ssize_t protocol_version_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct scmi_device *scmi_dev = to_scmi_dev(dev); + + return sprintf(buf, "%u.%u\n", PROTOCOL_REV_MAJOR(scmi_dev->version), + PROTOCOL_REV_MINOR(scmi_dev->version)); +} +static DEVICE_ATTR_RO(protocol_version); + +static ssize_t protocol_id_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct scmi_device *scmi_dev = to_scmi_dev(dev); + + return sprintf(buf, "%u\n", scmi_dev->protocol_id); +} +static DEVICE_ATTR_RO(protocol_id); + +static struct attribute *versions_attrs[] = { + &dev_attr_protocol_version.attr, + &dev_attr_protocol_id.attr, + NULL, +}; +ATTRIBUTE_GROUPS(versions); + static struct bus_type scmi_bus_type = { .name = "scmi_protocol", .match = scmi_dev_match, .probe = scmi_dev_probe, .remove = scmi_dev_remove, + .dev_groups = versions_groups, }; int scmi_driver_register(struct scmi_driver *driver, struct module *owner, -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-10 14:54 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-10 14:53 [PATCH 00/15] firmware: arm_scmi: Add support for multiple device per protocol Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-10 14:53 ` [PATCH 01/15] " Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-10 17:02 ` Cristian Marussi 2019-12-10 17:02 ` Cristian Marussi 2019-12-10 14:53 ` [PATCH 02/15] firmware: arm_scmi: Skip scmi mbox channel setup for addtional devices Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-10 17:33 ` Cristian Marussi 2019-12-10 17:33 ` Cristian Marussi 2019-12-10 14:53 ` [PATCH 03/15] firmware: arm_scmi: Skip protocol initialisation for additional devices Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-10 18:14 ` Cristian Marussi 2019-12-10 18:14 ` Cristian Marussi 2019-12-10 14:53 ` [PATCH 04/15] firmware: arm_scmi: Add names to scmi devices created Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-10 18:26 ` Cristian Marussi 2019-12-10 18:26 ` Cristian Marussi 2019-12-10 14:53 ` [PATCH 05/15] firmware: arm_scmi: Add versions and identifier attributes using dev_groups Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-11 13:21 ` Cristian Marussi 2019-12-11 13:21 ` Cristian Marussi 2019-12-10 14:53 ` [PATCH 06/15] firmware: arm_scmi: Update scmi_prot_init_fn_t to use device instead of handle Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-11 17:34 ` Cristian Marussi 2019-12-11 17:34 ` Cristian Marussi 2019-12-10 14:53 ` [PATCH 07/15] firmware: arm_scmi: Stash version in protocol init functions Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-11 17:35 ` Cristian Marussi 2019-12-11 17:35 ` Cristian Marussi 2019-12-10 14:53 ` [PATCH 08/15] firmware: arm_scmi: Add and initialise protocol version to scmi_device structure Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-11 18:06 ` Cristian Marussi 2019-12-11 18:06 ` Cristian Marussi 2019-12-12 12:15 ` Sudeep Holla 2019-12-12 12:15 ` Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla [this message] 2019-12-10 14:53 ` [PATCH 09/15] firmware: arm_scmi: Add scmi protocol version and id device attributes Sudeep Holla 2019-12-11 18:08 ` Cristian Marussi 2019-12-11 18:08 ` Cristian Marussi 2019-12-10 14:53 ` [PATCH 10/15] firmware: arm_scmi: Drop logging individual scmi protocol version Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-11 18:09 ` Cristian Marussi 2019-12-11 18:09 ` Cristian Marussi 2019-12-10 14:53 ` [PATCH 11/15] firmware: arm_scmi: Match scmi device by both name and protocol id Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-11 18:09 ` Cristian Marussi 2019-12-11 18:09 ` Cristian Marussi 2019-12-11 18:10 ` Cristian Marussi 2019-12-11 18:10 ` Cristian Marussi 2019-12-10 14:53 ` [PATCH 12/15] clk: scmi: " Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-24 7:49 ` Stephen Boyd 2019-12-24 7:49 ` Stephen Boyd 2019-12-10 14:53 ` [PATCH 13/15] cpufreq: " Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-11 2:39 ` Viresh Kumar 2019-12-11 2:39 ` Viresh Kumar 2019-12-11 10:13 ` Sudeep Holla 2019-12-11 10:13 ` Sudeep Holla 2019-12-11 10:30 ` Viresh Kumar 2019-12-11 10:30 ` Viresh Kumar 2019-12-10 14:53 ` [PATCH 14/15] hwmon: (scmi-hwmon) " Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-10 18:06 ` Guenter Roeck 2019-12-10 18:06 ` Guenter Roeck 2019-12-10 18:20 ` Sudeep Holla 2019-12-10 18:20 ` Sudeep Holla 2019-12-10 14:53 ` [PATCH 15/15] reset: reset-scmi: " Sudeep Holla 2019-12-10 14:53 ` Sudeep Holla 2019-12-11 9:51 ` Philipp Zabel 2019-12-11 9:51 ` Philipp Zabel 2019-12-11 15:28 ` Sudeep Holla 2019-12-11 15:28 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191210145345.11616-10-sudeep.holla@arm.com \ --to=sudeep.holla@arm.com \ --cc=cristian.marussi@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.