All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Boris Brezillon <bbrezillon@kernel.org>,
	Sean Paul <sean@poorly.run>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v3 33/50] drm/omap: dss: Remove .set_hdmi_mode() and .set_infoframe() operations
Date: Wed, 11 Dec 2019 00:57:33 +0200	[thread overview]
Message-ID: <20191210225750.15709-34-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20191210225750.15709-1-laurent.pinchart@ideasonboard.com>

The omapdss_hdmi_ops .set_hdmi_mode() and .set_infoframe() operations
operations are not used anymore, remove them.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/gpu/drm/omapdrm/dss/omapdss.h  |  3 ---
 drivers/gpu/drm/omapdrm/omap_encoder.c | 26 --------------------------
 2 files changed, 29 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
index 269e143d57be..30a12cf91cbb 100644
--- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
+++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
@@ -287,9 +287,6 @@ struct omap_dss_writeback_info {
 
 struct omapdss_hdmi_ops {
 	void (*lost_hotplug)(struct omap_dss_device *dssdev);
-	int (*set_hdmi_mode)(struct omap_dss_device *dssdev, bool hdmi_mode);
-	int (*set_infoframe)(struct omap_dss_device *dssdev,
-		const struct hdmi_avi_infoframe *avi);
 };
 
 struct omapdss_dsi_ops {
diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c b/drivers/gpu/drm/omapdrm/omap_encoder.c
index b232acd3bc3d..18a79dde6815 100644
--- a/drivers/gpu/drm/omapdrm/omap_encoder.c
+++ b/drivers/gpu/drm/omapdrm/omap_encoder.c
@@ -69,28 +69,6 @@ static void omap_encoder_update_videomode_flags(struct videomode *vm,
 	}
 }
 
-static void omap_encoder_hdmi_mode_set(struct drm_connector *connector,
-				       struct drm_encoder *encoder,
-				       struct drm_display_mode *adjusted_mode)
-{
-	struct omap_encoder *omap_encoder = to_omap_encoder(encoder);
-	struct omap_dss_device *dssdev = omap_encoder->output;
-	bool hdmi_mode = connector->display_info.is_hdmi;
-
-	if (dssdev->ops && dssdev->ops->hdmi.set_hdmi_mode)
-		dssdev->ops->hdmi.set_hdmi_mode(dssdev, hdmi_mode);
-
-	if (hdmi_mode && dssdev->ops && dssdev->ops->hdmi.set_infoframe) {
-		struct hdmi_avi_infoframe avi;
-		int r;
-
-		r = drm_hdmi_avi_infoframe_from_display_mode(&avi, connector,
-							     adjusted_mode);
-		if (r == 0)
-			dssdev->ops->hdmi.set_infoframe(dssdev, &avi);
-	}
-}
-
 static void omap_encoder_mode_set(struct drm_encoder *encoder,
 				  struct drm_display_mode *mode,
 				  struct drm_display_mode *adjusted_mode)
@@ -142,10 +120,6 @@ static void omap_encoder_mode_set(struct drm_encoder *encoder,
 		if (dssdev->ops && dssdev->ops->set_timings)
 			dssdev->ops->set_timings(dssdev, adjusted_mode);
 	}
-
-	/* Set the HDMI mode and HDMI infoframe if applicable. */
-	if (output->type == OMAP_DISPLAY_TYPE_HDMI)
-		omap_encoder_hdmi_mode_set(connector, encoder, adjusted_mode);
 }
 
 static void omap_encoder_disable(struct drm_encoder *encoder)
-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-12-10 22:59 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 22:57 [PATCH v3 00/50] drm/omap: Replace custom display drivers with drm_bridge and drm_panel Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 01/50] video: hdmi: Change return type of hdmi_avi_infoframe_init() to void Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 02/50] drm/connector: Add helper to get a connector type name Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 03/50] drm/edid: Add flag to drm_display_info to identify HDMI sinks Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 04/50] drm/bridge: Add connector-related bridge operations and data Laurent Pinchart
2019-12-11 11:01   ` Mihail Atanassov
2019-12-12 23:15     ` Laurent Pinchart
2019-12-12 23:24       ` Laurent Pinchart
2019-12-15 10:22   ` Sam Ravnborg
2019-12-18  1:16     ` Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 05/50] drm/bridge: Extend bridge API to disable connector creation Laurent Pinchart
2019-12-17 12:12   ` Tomi Valkeinen
2019-12-18  1:17     ` Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 06/50] drm/bridge: dumb-vga-dac: Rename internal symbols to simple-bridge Laurent Pinchart
2019-12-11 21:13   ` Sam Ravnborg
2019-12-11 23:42     ` Laurent Pinchart
2019-12-12  8:58       ` Maxime Ripard
2019-12-10 22:57 ` [PATCH v3 07/50] drm/bridge: dumb-vga-dac: Rename driver " Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 08/50] drm/bridge: simple-bridge: Add support for non-VGA bridges Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 09/50] drm/bridge: simple-bridge: Add support for enable GPIO Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 10/50] drm/bridge: simple-bridge: Add support for the TI OP362 Laurent Pinchart
2019-12-18  7:04   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 11/50] drm/bridge: Add bridge driver for display connectors Laurent Pinchart
2019-12-15 12:03   ` Sam Ravnborg
2019-12-18  1:48     ` Laurent Pinchart
2019-12-16  9:07   ` Boris Brezillon
2019-12-16 13:11   ` Tomi Valkeinen
2019-12-18  1:45     ` Laurent Pinchart
2019-12-18  6:57       ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 12/50] drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter Laurent Pinchart
2019-12-16 13:06   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 13/50] drm/bridge: panel: Implement bridge connector operations Laurent Pinchart
2019-12-16  9:09   ` Boris Brezillon
2019-12-10 22:57 ` [PATCH v3 14/50] drm/bridge: tfp410: Replace manual connector handling with bridge Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 15/50] drm/bridge: tfp410: Allow operation without drm_connector Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 16/50] drm: Add helper to create a connector for a chain of bridges Laurent Pinchart
2019-12-16  9:21   ` Boris Brezillon
2019-12-10 22:57 ` [PATCH v3 17/50] drm/omap: Fix possible object reference leak Laurent Pinchart
2019-12-17  7:28   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 18/50] drm/omap: dss: Cleanup DSS ports on initialisation failure Laurent Pinchart
2019-12-17  7:49   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 19/50] drm/omap: Simplify HDMI mode and infoframe configuration Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 20/50] drm/omap: Factor out display type to connector type conversion Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 21/50] drm/omap: Use the drm_panel_bridge API Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 22/50] drm/omap: dss: Fix output next device lookup in DT Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 23/50] drm/omap: Add infrastructure to support drm_bridge local to DSS outputs Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 24/50] drm/omap: dss: Make omap_dss_device_ops optional Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 25/50] drm/omap: hdmi: Allocate EDID in the .read_edid() operation Laurent Pinchart
2019-12-10 22:57 ` [PATCH v3 26/50] drm/omap: hdmi4: Rework EDID read to isolate data read Laurent Pinchart
2019-12-17 12:25   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 27/50] drm/omap: hdmi5: " Laurent Pinchart
2019-12-17 12:36   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 28/50] drm/omap: hdmi4: Register a drm_bridge for EDID read Laurent Pinchart
2019-12-17 12:41   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 29/50] drm/omap: hdmi5: " Laurent Pinchart
2019-12-17 12:41   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 30/50] drm/omap: hdmi4: Move mode set, enable and disable operations to bridge Laurent Pinchart
2019-12-18 11:26   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 31/50] drm/omap: hdmi5: " Laurent Pinchart
2019-12-18 11:28   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 32/50] drm/omap: hdmi4: Implement drm_bridge .hpd_notify() operation Laurent Pinchart
2019-12-18 11:47   ` Tomi Valkeinen
2019-12-10 22:57 ` Laurent Pinchart [this message]
2019-12-18 11:50   ` [PATCH v3 33/50] drm/omap: dss: Remove .set_hdmi_mode() and .set_infoframe() operations Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 34/50] drm/omap: venc: Register a drm_bridge Laurent Pinchart
2019-12-18 11:53   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 35/50] drm/omap: Create connector for bridges Laurent Pinchart
2019-12-15 10:00   ` Sam Ravnborg
2019-12-18  1:56     ` Laurent Pinchart
2019-12-18 12:55   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 36/50] drm/omap: Switch the HDMI and VENC outputs to drm_bridge Laurent Pinchart
2019-12-18 13:22   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 37/50] drm/omap: Remove HPD, detect and EDID omapdss operations Laurent Pinchart
2019-12-19  8:25   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 38/50] drm/omap: hdmi: Remove omap_dss_device operations Laurent Pinchart
2019-12-19  8:26   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 39/50] drm/omap: venc: " Laurent Pinchart
2019-12-19  8:27   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 40/50] drm/omap: hdmi4: Simplify EDID read Laurent Pinchart
2019-12-19  8:28   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 41/50] drm/omap: hdmi5: " Laurent Pinchart
2019-12-19  8:30   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 42/50] drm/omap: dpi: Sort includes alphabetically Laurent Pinchart
2019-12-19  8:54   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 43/50] drm/omap: dpi: Reorder functions in sections Laurent Pinchart
2019-12-19  8:56   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 44/50] drm/omap: dpi: Simplify clock setting API Laurent Pinchart
2019-12-19  9:01   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 45/50] drm/omap: dpi: Register a drm_bridge Laurent Pinchart
2019-12-19  9:21   ` Tomi Valkeinen
2019-12-19  9:40     ` Laurent Pinchart
2019-12-19 10:01       ` Tomi Valkeinen
2019-12-19 10:03         ` Laurent Pinchart
2019-12-19 10:15           ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 46/50] drm/omap: sdi: Sort includes alphabetically Laurent Pinchart
2019-12-19  9:04   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 47/50] drm/omap: sdi: Register a drm_bridge Laurent Pinchart
2019-12-19  9:27   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 48/50] drm/omap: dss: Remove unused omap_dss_device operations Laurent Pinchart
2019-12-19  9:28   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 49/50] drm/omap: dss: Inline the omapdss_display_get() function Laurent Pinchart
2019-12-19  9:31   ` Tomi Valkeinen
2019-12-10 22:57 ` [PATCH v3 50/50] drm/omap: dss: Remove unused omapdss_of_find_connected_device() function Laurent Pinchart
2019-12-19  9:31   ` Tomi Valkeinen
2019-12-15 12:27 ` [PATCH v3 00/50] drm/omap: Replace custom display drivers with drm_bridge and drm_panel Sam Ravnborg
2019-12-18  2:03   ` Laurent Pinchart
2019-12-18  7:07     ` Tomi Valkeinen
2019-12-18 14:46       ` Laurent Pinchart
2019-12-18 15:27         ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191210225750.15709-34-laurent.pinchart@ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=bbrezillon@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    --cc=sean@poorly.run \
    --cc=sebastian.reichel@collabora.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.