From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Bard liao <yung-chuan.liao@linux.intel.com>, Rander Wang <rander.wang@linux.intel.com>, Ranjani Sridharan <ranjani.sridharan@linux.intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Subject: [PATCH v5 00/11] soundwire: update ASoC interfaces Date: Wed, 11 Dec 2019 19:44:56 -0600 [thread overview] Message-ID: <20191212014507.28050-1-pierre-louis.bossart@linux.intel.com> (raw) We need new fields in existing structures to a) deal with race conditions on codec probe/enumeration b) allow for multi-step ACPI scan/probe/startup on Intel plaforms c) deal with MSI issues using a single handler/threads for all audio interrupts d) deal with access to registers shared across multiple links on Intel platforms These structures for a) will be used by the SOF driver as well as codec drivers. The b) c) and d) cases are only for the Intel-specific implementation. To avoid conflicts between ASoC and Soundwire trees, these 11 patches are provided out-of-order, before the functionality enabled in these header files is added in follow-up patch series which can be applied separately in the ASoC and Soundwire trees. As discussed earlier, Vinod would need to provide an immutable tag for Mark Brown, and the integration on the ASoC side of SOF changes and new codecs drivers can proceed in parallel with SoundWire core changes. I had multiple offline discussions with Vinod/Mark/Takashi on how to proceed withe volume of SoundWire changes. Now that v5.5-rc1 is out we should go ahead with these interface changes. The next patchset "[PATCH v3 00/15] soundwire: intel: implement new ASoC interfaces" can still be reviewed but will not apply as is due to a one-line conflict. An update will be provided when Vinod applies this series to avoid noise on mailing lists. An update for the series "[PATCH v3 00/22] soundwire: code hardening and suspend-resume support" is ready but will be provided when both the interfaces changes and the implementation changes are merged. Comments and feedback welcome ~Pierre Changes since v4: One line change to remove EXPORT_SYMBOL(sdw_intel_init) Fix build issue with randconfig reported by kbuild (missing include of linux/irqreturn.h) Changes since v3: Reordered code and added kernel doc comments Added prototypes and fields needed to deal with SoundWire interrupts in a single handler/thread, following what is already done on the DSP side. Added mutex to control access to registers shared across links Added initial definitions for clock stop support on Intel platforms. Depending on power and latency requirements, different "quirks" can be supported. Changes since v2: Added new field to deal with a race condition leading to a timeout when the codec goes through a pm_runtime suspend/resume transition while the Master remains active. Clarified commit messages with detailed explanations what those race conditions are and why the changes were introduced. Reordered fields for Intel routines Added kernel-doc definitions for structures Modified the patch subjects to make the mapping between interface definition and implementation straightforward. Changes since v1 (no feedback received since October 23) additional initialization_complete utility to help codec drivers with their resume operation, waiting for the enumeration to complete is not always enough. Changes since v3: Reordered code and added kernel doc comments Added prototypes and fields needed to deal with SoundWire interrupts in a single handler/thread, following what is already done on the DSP side. Added mutex to control access to registers shared across links Added initial definitions for clock stop support on Intel platforms. Depending on power and latency requirements, different "quirks" can be supported. Changes since v2: Added new field to deal with a race condition leading to a timeout when the codec goes through a pm_runtime suspend/resume transition while the Master remains active. Clarified commit messages with detailed explanations what those race conditions are and why the changes were introduced. Reordered fields for Intel routines Added kernel-doc definitions for structures Modified the patch subjects to make the mapping between interface definition and implementation straightforward. Changes since v1 (no feedback received since October 23) additional initialization_complete utility to help codec drivers with their resume operation, waiting for the enumeration to complete is not always enough. Bard Liao (2): soundwire: intel: update headers for interrupts soundwire: intel: add link_list to handle interrupts with a single thread Pierre-Louis Bossart (7): soundwire: sdw_slave: add probe_complete structure and new fields soundwire: sdw_slave: add enumeration_complete structure soundwire: sdw_slave: add initialization_complete definition soundwire: sdw_slave: track unattach_request to handle all init sequences soundwire: intel: update interfaces between ASoC and SoundWire soundwire: intel: add mutex for shared SHIM register access soundwire: intel: add clock stop quirks Rander Wang (2): soundwire: intel: update stream callbacks for hwparams/free stream operations soundwire: intel: add prototype for WAKEEN interrupt processing drivers/soundwire/intel.c | 20 ++-- drivers/soundwire/intel.h | 13 ++- drivers/soundwire/intel_init.c | 32 ++---- include/linux/soundwire/sdw.h | 19 ++++ include/linux/soundwire/sdw_intel.h | 156 ++++++++++++++++++++++++++-- 5 files changed, 196 insertions(+), 44 deletions(-) -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: alsa-devel@alsa-project.org Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan <ranjani.sridharan@linux.intel.com>, vkoul@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Bard liao <yung-chuan.liao@linux.intel.com>, Rander Wang <rander.wang@linux.intel.com> Subject: [alsa-devel] [PATCH v5 00/11] soundwire: update ASoC interfaces Date: Wed, 11 Dec 2019 19:44:56 -0600 [thread overview] Message-ID: <20191212014507.28050-1-pierre-louis.bossart@linux.intel.com> (raw) We need new fields in existing structures to a) deal with race conditions on codec probe/enumeration b) allow for multi-step ACPI scan/probe/startup on Intel plaforms c) deal with MSI issues using a single handler/threads for all audio interrupts d) deal with access to registers shared across multiple links on Intel platforms These structures for a) will be used by the SOF driver as well as codec drivers. The b) c) and d) cases are only for the Intel-specific implementation. To avoid conflicts between ASoC and Soundwire trees, these 11 patches are provided out-of-order, before the functionality enabled in these header files is added in follow-up patch series which can be applied separately in the ASoC and Soundwire trees. As discussed earlier, Vinod would need to provide an immutable tag for Mark Brown, and the integration on the ASoC side of SOF changes and new codecs drivers can proceed in parallel with SoundWire core changes. I had multiple offline discussions with Vinod/Mark/Takashi on how to proceed withe volume of SoundWire changes. Now that v5.5-rc1 is out we should go ahead with these interface changes. The next patchset "[PATCH v3 00/15] soundwire: intel: implement new ASoC interfaces" can still be reviewed but will not apply as is due to a one-line conflict. An update will be provided when Vinod applies this series to avoid noise on mailing lists. An update for the series "[PATCH v3 00/22] soundwire: code hardening and suspend-resume support" is ready but will be provided when both the interfaces changes and the implementation changes are merged. Comments and feedback welcome ~Pierre Changes since v4: One line change to remove EXPORT_SYMBOL(sdw_intel_init) Fix build issue with randconfig reported by kbuild (missing include of linux/irqreturn.h) Changes since v3: Reordered code and added kernel doc comments Added prototypes and fields needed to deal with SoundWire interrupts in a single handler/thread, following what is already done on the DSP side. Added mutex to control access to registers shared across links Added initial definitions for clock stop support on Intel platforms. Depending on power and latency requirements, different "quirks" can be supported. Changes since v2: Added new field to deal with a race condition leading to a timeout when the codec goes through a pm_runtime suspend/resume transition while the Master remains active. Clarified commit messages with detailed explanations what those race conditions are and why the changes were introduced. Reordered fields for Intel routines Added kernel-doc definitions for structures Modified the patch subjects to make the mapping between interface definition and implementation straightforward. Changes since v1 (no feedback received since October 23) additional initialization_complete utility to help codec drivers with their resume operation, waiting for the enumeration to complete is not always enough. Changes since v3: Reordered code and added kernel doc comments Added prototypes and fields needed to deal with SoundWire interrupts in a single handler/thread, following what is already done on the DSP side. Added mutex to control access to registers shared across links Added initial definitions for clock stop support on Intel platforms. Depending on power and latency requirements, different "quirks" can be supported. Changes since v2: Added new field to deal with a race condition leading to a timeout when the codec goes through a pm_runtime suspend/resume transition while the Master remains active. Clarified commit messages with detailed explanations what those race conditions are and why the changes were introduced. Reordered fields for Intel routines Added kernel-doc definitions for structures Modified the patch subjects to make the mapping between interface definition and implementation straightforward. Changes since v1 (no feedback received since October 23) additional initialization_complete utility to help codec drivers with their resume operation, waiting for the enumeration to complete is not always enough. Bard Liao (2): soundwire: intel: update headers for interrupts soundwire: intel: add link_list to handle interrupts with a single thread Pierre-Louis Bossart (7): soundwire: sdw_slave: add probe_complete structure and new fields soundwire: sdw_slave: add enumeration_complete structure soundwire: sdw_slave: add initialization_complete definition soundwire: sdw_slave: track unattach_request to handle all init sequences soundwire: intel: update interfaces between ASoC and SoundWire soundwire: intel: add mutex for shared SHIM register access soundwire: intel: add clock stop quirks Rander Wang (2): soundwire: intel: update stream callbacks for hwparams/free stream operations soundwire: intel: add prototype for WAKEEN interrupt processing drivers/soundwire/intel.c | 20 ++-- drivers/soundwire/intel.h | 13 ++- drivers/soundwire/intel_init.c | 32 ++---- include/linux/soundwire/sdw.h | 19 ++++ include/linux/soundwire/sdw_intel.h | 156 ++++++++++++++++++++++++++-- 5 files changed, 196 insertions(+), 44 deletions(-) -- 2.20.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next reply other threads:[~2019-12-12 1:45 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-12 1:44 Pierre-Louis Bossart [this message] 2019-12-12 1:44 ` [alsa-devel] [PATCH v5 00/11] soundwire: update ASoC interfaces Pierre-Louis Bossart 2019-12-12 1:44 ` [PATCH v5 01/11] soundwire: sdw_slave: add probe_complete structure and new fields Pierre-Louis Bossart 2019-12-12 1:44 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 1:44 ` [PATCH v5 02/11] soundwire: sdw_slave: add enumeration_complete structure Pierre-Louis Bossart 2019-12-12 1:44 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 1:44 ` [PATCH v5 03/11] soundwire: sdw_slave: add initialization_complete definition Pierre-Louis Bossart 2019-12-12 1:44 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 1:45 ` [PATCH v5 04/11] soundwire: sdw_slave: track unattach_request to handle all init sequences Pierre-Louis Bossart 2019-12-12 1:45 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 1:45 ` [PATCH v5 05/11] soundwire: intel: update interfaces between ASoC and SoundWire Pierre-Louis Bossart 2019-12-12 1:45 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 1:45 ` [PATCH v5 06/11] soundwire: intel: update stream callbacks for hwparams/free stream operations Pierre-Louis Bossart 2019-12-12 1:45 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 1:45 ` [PATCH v5 07/11] soundwire: intel: update headers for interrupts Pierre-Louis Bossart 2019-12-12 1:45 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 1:45 ` [PATCH v5 08/11] soundwire: intel: add link_list to handle interrupts with a single thread Pierre-Louis Bossart 2019-12-12 1:45 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 1:45 ` [PATCH v5 09/11] soundwire: intel: add prototype for WAKEEN interrupt processing Pierre-Louis Bossart 2019-12-12 1:45 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 1:45 ` [PATCH v5 10/11] soundwire: intel: add mutex for shared SHIM register access Pierre-Louis Bossart 2019-12-12 1:45 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 1:45 ` [PATCH v5 11/11] soundwire: intel: add clock stop quirks Pierre-Louis Bossart 2019-12-12 1:45 ` [alsa-devel] " Pierre-Louis Bossart 2019-12-12 3:49 ` [PATCH v5 00/11] soundwire: update ASoC interfaces Vinod Koul 2019-12-12 3:49 ` [alsa-devel] " Vinod Koul 2019-12-12 14:37 ` Pierre-Louis Bossart 2019-12-12 14:37 ` Pierre-Louis Bossart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191212014507.28050-1-pierre-louis.bossart@linux.intel.com \ --to=pierre-louis.bossart@linux.intel.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jank@cadence.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rander.wang@linux.intel.com \ --cc=ranjani.sridharan@linux.intel.com \ --cc=slawomir.blauciak@intel.com \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.de \ --cc=vkoul@kernel.org \ --cc=yung-chuan.liao@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.