From: Sean Paul <sean@poorly.run> To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, rodrigo.vivi@intel.com, Sean Paul <seanpaul@chromium.org> Subject: [PATCH v2 03/12] drm/i915: WARN if HDCP signalling is enabled upon disable Date: Thu, 12 Dec 2019 14:02:21 -0500 [thread overview] Message-ID: <20191212190230.188505-4-sean@poorly.run> (raw) In-Reply-To: <20191212190230.188505-1-sean@poorly.run> From: Sean Paul <seanpaul@chromium.org> HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Sean Paul <seanpaul@chromium.org> Changes in v2: - Added to the set in lieu of just clearing the bit --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 5b6f32517c75..4a5bdf3ef51d 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -1951,6 +1951,8 @@ void intel_ddi_disable_transcoder_func(const struct intel_crtc_state *crtc_state i915_reg_t reg = TRANS_DDI_FUNC_CTL(cpu_transcoder); u32 val = I915_READ(reg); + WARN_ON(val & TRANS_DDI_HDCP_SIGNALLING); + if (INTEL_GEN(dev_priv) >= 12) { val &= ~(TRANS_DDI_FUNC_ENABLE | TGL_TRANS_DDI_PORT_MASK | TRANS_DDI_DP_VC_PAYLOAD_ALLOC); -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run> To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, Sean Paul <seanpaul@chromium.org> Subject: [Intel-gfx] [PATCH v2 03/12] drm/i915: WARN if HDCP signalling is enabled upon disable Date: Thu, 12 Dec 2019 14:02:21 -0500 [thread overview] Message-ID: <20191212190230.188505-4-sean@poorly.run> (raw) In-Reply-To: <20191212190230.188505-1-sean@poorly.run> From: Sean Paul <seanpaul@chromium.org> HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Sean Paul <seanpaul@chromium.org> Changes in v2: - Added to the set in lieu of just clearing the bit --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 5b6f32517c75..4a5bdf3ef51d 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -1951,6 +1951,8 @@ void intel_ddi_disable_transcoder_func(const struct intel_crtc_state *crtc_state i915_reg_t reg = TRANS_DDI_FUNC_CTL(cpu_transcoder); u32 val = I915_READ(reg); + WARN_ON(val & TRANS_DDI_HDCP_SIGNALLING); + if (INTEL_GEN(dev_priv) >= 12) { val &= ~(TRANS_DDI_FUNC_ENABLE | TGL_TRANS_DDI_PORT_MASK | TRANS_DDI_DP_VC_PAYLOAD_ALLOC); -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-12 19:02 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-12 19:02 [PATCH v2 00/12] drm/i915: Add support for HDCP 1.4 over MST connectors Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-12 19:02 ` [PATCH v2 01/12] drm/i915: Fix sha_text population code Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-12 19:02 ` Sean Paul 2019-12-13 10:20 ` Ramalingam C 2019-12-13 10:20 ` [Intel-gfx] " Ramalingam C 2019-12-13 10:20 ` Ramalingam C 2019-12-12 19:02 ` [PATCH v2 02/12] drm/i915: Clear the repeater bit on HDCP disable Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-12 19:02 ` Sean Paul 2019-12-13 10:29 ` Ramalingam C 2019-12-13 10:29 ` [Intel-gfx] " Ramalingam C 2019-12-13 10:29 ` Ramalingam C 2019-12-13 19:07 ` Sean Paul 2019-12-13 19:07 ` [Intel-gfx] " Sean Paul 2019-12-13 19:07 ` Sean Paul 2019-12-12 19:02 ` Sean Paul [this message] 2019-12-12 19:02 ` [Intel-gfx] [PATCH v2 03/12] drm/i915: WARN if HDCP signalling is enabled upon disable Sean Paul 2019-12-13 10:37 ` Ramalingam C 2019-12-13 10:37 ` [Intel-gfx] " Ramalingam C 2019-12-12 19:02 ` [PATCH v2 04/12] drm/i915: Intercept Aksv writes in the aux hooks Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-13 10:52 ` Ramalingam C 2019-12-13 10:52 ` [Intel-gfx] " Ramalingam C 2019-12-12 19:02 ` [PATCH v2 05/12] drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-13 10:43 ` Ramalingam C 2019-12-13 10:43 ` [Intel-gfx] " Ramalingam C 2019-12-12 19:02 ` [PATCH v2 06/12] drm/i915: Factor out hdcp->value assignments Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-13 11:11 ` Ramalingam C 2019-12-13 11:11 ` [Intel-gfx] " Ramalingam C 2019-12-12 19:02 ` [PATCH v2 07/12] drm/i915: Protect workers against disappearing connectors Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-13 11:10 ` Ramalingam C 2019-12-13 11:10 ` [Intel-gfx] " Ramalingam C 2019-12-13 19:04 ` Sean Paul 2019-12-13 19:04 ` [Intel-gfx] " Sean Paul 2019-12-12 19:02 ` [PATCH v2 08/12] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-13 11:58 ` Ramalingam C 2019-12-13 11:58 ` [Intel-gfx] " Ramalingam C 2019-12-13 19:03 ` Sean Paul 2019-12-13 19:03 ` [Intel-gfx] " Sean Paul 2019-12-12 19:02 ` [PATCH v2 09/12] drm/i915: Support DP MST in enc_to_dig_port() function Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-12 19:02 ` [PATCH v2 10/12] drm/i915: Use ddi_update_pipe in intel_dp_mst Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-12 19:02 ` [PATCH v2 11/12] drm/i915: Expose HDCP shim functions from dp for use by dp_mst Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-13 11:25 ` Ville Syrjälä 2019-12-13 11:25 ` [Intel-gfx] " Ville Syrjälä 2019-12-13 11:59 ` Jani Nikula 2019-12-13 11:59 ` [Intel-gfx] " Jani Nikula 2019-12-12 19:02 ` [PATCH v2 12/12] drm/i915: Add HDCP 1.4 support for MST connectors Sean Paul 2019-12-12 19:02 ` [Intel-gfx] " Sean Paul 2019-12-12 21:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for HDCP 1.4 over MST connectors (rev2) Patchwork 2019-12-12 21:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2019-12-12 22:50 ` Sean Paul 2019-12-12 22:55 ` Chris Wilson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191212190230.188505-4-sean@poorly.run \ --to=sean@poorly.run \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=rodrigo.vivi@intel.com \ --cc=seanpaul@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.