From: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk> To: ben.dooks@codethink.co.uk Cc: Boris Brezillon <bbrezillon@kernel.org>, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] i3c: make 'i3c_bus_set_mode' static Date: Tue, 17 Dec 2019 12:01:50 +0000 [thread overview] Message-ID: <20191217120150.2134326-1-ben.dooks@codethink.co.uk> (raw) The function i3c_bus_set_mode() is not declared or exported, so make it static to avoid the following warning: drivers/i3c/master.c:530:5: warning: symbol 'i3c_bus_set_mode' was not declared. Should it be static? If it is needed in the future, then it should be declared and suitably exported. Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> --- Cc: Boris Brezillon <bbrezillon@kernel.org> Cc: linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/i3c/master.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 043691656245..7f8f896fa0c3 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -527,8 +527,8 @@ static const struct device_type i3c_masterdev_type = { .groups = i3c_masterdev_groups, }; -int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode, - unsigned long max_i2c_scl_rate) +static int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode, + unsigned long max_i2c_scl_rate) { struct i3c_master_controller *master = i3c_bus_to_i3c_master(i3cbus); -- 2.24.0
WARNING: multiple messages have this Message-ID (diff)
From: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk> To: ben.dooks@codethink.co.uk Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Boris Brezillon <bbrezillon@kernel.org> Subject: [PATCH] i3c: make 'i3c_bus_set_mode' static Date: Tue, 17 Dec 2019 12:01:50 +0000 [thread overview] Message-ID: <20191217120150.2134326-1-ben.dooks@codethink.co.uk> (raw) The function i3c_bus_set_mode() is not declared or exported, so make it static to avoid the following warning: drivers/i3c/master.c:530:5: warning: symbol 'i3c_bus_set_mode' was not declared. Should it be static? If it is needed in the future, then it should be declared and suitably exported. Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> --- Cc: Boris Brezillon <bbrezillon@kernel.org> Cc: linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/i3c/master.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 043691656245..7f8f896fa0c3 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -527,8 +527,8 @@ static const struct device_type i3c_masterdev_type = { .groups = i3c_masterdev_groups, }; -int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode, - unsigned long max_i2c_scl_rate) +static int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode, + unsigned long max_i2c_scl_rate) { struct i3c_master_controller *master = i3c_bus_to_i3c_master(i3cbus); -- 2.24.0 _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next reply other threads:[~2019-12-17 12:11 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-17 12:01 Ben Dooks (Codethink) [this message] 2019-12-17 12:01 ` [PATCH] i3c: make 'i3c_bus_set_mode' static Ben Dooks (Codethink) 2019-12-18 8:27 ` Boris Brezillon 2019-12-18 8:27 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191217120150.2134326-1-ben.dooks@codethink.co.uk \ --to=ben.dooks@codethink.co.uk \ --cc=bbrezillon@kernel.org \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.