From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: "Paolo Bonzini" <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org Cc: "Peter Maydell" <peter.maydell@linaro.org>, "Li Zhijian" <lizhijian@cn.fujitsu.com>, "Paul Burton" <pburton@wavecomp.com>, "Jason Wang" <jasowang@redhat.com>, "KONRAD Frederic" <frederic.konrad@adacore.com>, "Gerd Hoffmann" <kraxel@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Alberto Garcia" <berto@igalia.com>, "Sagar Karandikar" <sagark@eecs.berkeley.edu>, qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>, "Markus Armbruster" <armbru@redhat.com>, "Halil Pasic" <pasic@linux.ibm.com>, "Christian Borntraeger" <borntraeger@de.ibm.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, "Joel Stanley" <joel@jms.id.au>, "Samuel Thibault" <samuel.thibault@ens-lyon.org>, "Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Antony Pavlov" <antonynpavlov@gmail.com>, "Laurent Vivier" <lvivier@redhat.com>, "Corey Minyard" <minyard@acm.org>, "Amit Shah" <amit@kernel.org>, "Alistair Francis" <alistair@alistair23.me>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Fabien Chouteau" <chouteau@adacore.com>, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, "Peter Chubb" <peter.chubb@nicta.com.au>, "Alex Bennée" <alex.bennee@linaro.org>, "Kevin Wolf" <kwolf@redhat.com>, qemu-riscv@nongnu.org, "Igor Mitsyanko" <i.mitsyanko@gmail.com>, "Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>, "Cornelia Huck" <cohuck@redhat.com>, "Max Reitz" <mreitz@redhat.com>, "Zhang Chen" <chen.zhang@intel.com>, "Michael Walle" <michael@walle.cc>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Thomas Huth" <huth@tuxfamily.org>, "Aleksandar Markovic" <amarkovic@wavecomp.com>, "Aurelien Jarno" <aurelien@aurel32.net> Subject: [RFC PATCH 08/14] hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler Date: Tue, 17 Dec 2019 17:38:02 +0100 [thread overview] Message-ID: <20191217163808.20068-9-philmd@redhat.com> (raw) In-Reply-To: <20191217163808.20068-1-philmd@redhat.com> The Chardev events are listed in the QEMUChrEvent enum. To be able to use this enum in the IOEventHandler typedef, we need to explicit when frontends ignore some events, to silent GCC the following warnings: CC hw/usb/redirect.o hw/usb/redirect.c: In function ‘usbredir_chardev_event’: hw/usb/redirect.c:1361:5: error: enumeration value ‘CHR_EVENT_BREAK’ not handled in switch [-Werror=switch] 1361 | switch (event) { | ^~~~~~ hw/usb/redirect.c:1361:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not handled in switch [-Werror=switch] hw/usb/redirect.c:1361:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ not handled in switch [-Werror=switch] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Cc: Gerd Hoffmann <kraxel@redhat.com> --- hw/usb/redirect.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index e0f5ca6f81..acc376cc95 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -1370,6 +1370,9 @@ static void usbredir_chardev_event(void *opaque, int event) DPRINTF("chardev close\n"); qemu_bh_schedule(dev->chardev_close_bh); break; + default: + /* Ignore */ + break; } } -- 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: "Paolo Bonzini" <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org Cc: "Cornelia Huck" <cohuck@redhat.com>, "Zhang Chen" <chen.zhang@intel.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Fabien Chouteau" <chouteau@adacore.com>, "Paul Burton" <pburton@wavecomp.com>, "Peter Maydell" <peter.maydell@linaro.org>, "KONRAD Frederic" <frederic.konrad@adacore.com>, "Aurelien Jarno" <aurelien@aurel32.net>, "Jason Wang" <jasowang@redhat.com>, qemu-block@nongnu.org, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Corey Minyard" <minyard@acm.org>, "Max Reitz" <mreitz@redhat.com>, "Li Zhijian" <lizhijian@cn.fujitsu.com>, "Gerd Hoffmann" <kraxel@redhat.com>, "Michael Walle" <michael@walle.cc>, "Markus Armbruster" <armbru@redhat.com>, "Laurent Vivier" <lvivier@redhat.com>, "Igor Mitsyanko" <i.mitsyanko@gmail.com>, "Joel Stanley" <joel@jms.id.au>, "Alex Bennée" <alex.bennee@linaro.org>, "Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>, "Alberto Garcia" <berto@igalia.com>, "Peter Chubb" <peter.chubb@nicta.com.au>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Christian Borntraeger" <borntraeger@de.ibm.com>, "Andrzej Zaborowski" <balrogg@gmail.com>, "Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>, "Aleksandar Markovic" <amarkovic@wavecomp.com>, "Sagar Karandikar" <sagark@eecs.berkeley.edu>, "Antony Pavlov" <antonynpavlov@gmail.com>, qemu-arm@nongnu.org, "Alistair Francis" <alistair@alistair23.me>, "Kevin Wolf" <kwolf@redhat.com>, qemu-s390x@nongnu.org, "Gonglei (Arei)" <arei.gonglei@huawei.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Samuel Thibault" <samuel.thibault@ens-lyon.org>, "Amit Shah" <amit@kernel.org>, qemu-riscv@nongnu.org, "Halil Pasic" <pasic@linux.ibm.com>, "Thomas Huth" <huth@tuxfamily.org> Subject: [RFC PATCH 08/14] hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler Date: Tue, 17 Dec 2019 17:38:02 +0100 [thread overview] Message-ID: <20191217163808.20068-9-philmd@redhat.com> (raw) In-Reply-To: <20191217163808.20068-1-philmd@redhat.com> The Chardev events are listed in the QEMUChrEvent enum. To be able to use this enum in the IOEventHandler typedef, we need to explicit when frontends ignore some events, to silent GCC the following warnings: CC hw/usb/redirect.o hw/usb/redirect.c: In function ‘usbredir_chardev_event’: hw/usb/redirect.c:1361:5: error: enumeration value ‘CHR_EVENT_BREAK’ not handled in switch [-Werror=switch] 1361 | switch (event) { | ^~~~~~ hw/usb/redirect.c:1361:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not handled in switch [-Werror=switch] hw/usb/redirect.c:1361:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ not handled in switch [-Werror=switch] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Cc: Gerd Hoffmann <kraxel@redhat.com> --- hw/usb/redirect.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index e0f5ca6f81..acc376cc95 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -1370,6 +1370,9 @@ static void usbredir_chardev_event(void *opaque, int event) DPRINTF("chardev close\n"); qemu_bh_schedule(dev->chardev_close_bh); break; + default: + /* Ignore */ + break; } } -- 2.21.0
next prev parent reply other threads:[~2019-12-17 16:44 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-17 16:37 [PATCH 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef Philippe Mathieu-Daudé 2019-12-17 16:37 ` Philippe Mathieu-Daudé 2019-12-17 16:37 ` [PATCH 01/14] hw/ipmi: Remove unnecessary declarations Philippe Mathieu-Daudé 2019-12-17 16:37 ` Philippe Mathieu-Daudé 2019-12-17 16:37 ` [RFC PATCH 02/14] chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler Philippe Mathieu-Daudé 2019-12-17 16:37 ` Philippe Mathieu-Daudé 2019-12-17 16:37 ` [RFC PATCH 03/14] vhost-user: " Philippe Mathieu-Daudé 2019-12-17 16:37 ` Philippe Mathieu-Daudé 2019-12-17 16:37 ` [RFC PATCH 04/14] virtio-console: " Philippe Mathieu-Daudé 2019-12-17 16:37 ` Philippe Mathieu-Daudé 2019-12-17 16:37 ` [RFC PATCH 05/14] hw/ipmi: " Philippe Mathieu-Daudé 2019-12-17 16:37 ` Philippe Mathieu-Daudé 2019-12-17 16:38 ` [RFC PATCH 06/14] hw/usb/dev-serial: Explicit we ignore few " Philippe Mathieu-Daudé 2019-12-17 16:38 ` Philippe Mathieu-Daudé 2019-12-17 16:38 ` [RFC PATCH 07/14] ccid-card-passthru: Explicit we ignore " Philippe Mathieu-Daudé 2019-12-17 16:38 ` Philippe Mathieu-Daudé 2019-12-17 16:38 ` Philippe Mathieu-Daudé [this message] 2019-12-17 16:38 ` [RFC PATCH 08/14] hw/usb/redirect: Explicit we ignore few " Philippe Mathieu-Daudé 2019-12-17 16:38 ` [RFC PATCH 09/14] monitor/qmp: " Philippe Mathieu-Daudé 2019-12-17 16:38 ` Philippe Mathieu-Daudé 2019-12-17 16:38 ` [RFC PATCH 10/14] monitor/hmp: Explicit we ignore a " Philippe Mathieu-Daudé 2019-12-17 16:38 ` Philippe Mathieu-Daudé 2019-12-17 17:37 ` Dr. David Alan Gilbert 2019-12-17 17:46 ` Philippe Mathieu-Daudé 2019-12-17 17:51 ` Dr. David Alan Gilbert 2019-12-17 16:38 ` [RFC PATCH 11/14] net/vhost-user: Explicit we ignore few " Philippe Mathieu-Daudé 2019-12-17 16:38 ` Philippe Mathieu-Daudé 2019-12-17 16:38 ` [RFC PATCH 12/14] vhost-user-blk: " Philippe Mathieu-Daudé 2019-12-17 16:38 ` Philippe Mathieu-Daudé 2019-12-17 16:38 ` [RFC PATCH 13/14] hw/char/terminal3270: Explicit ignored " Philippe Mathieu-Daudé 2019-12-17 16:38 ` Philippe Mathieu-Daudé 2019-12-19 6:52 ` Markus Armbruster 2019-12-19 6:52 ` Markus Armbruster 2019-12-19 13:09 ` Philippe Mathieu-Daudé 2019-12-19 13:09 ` Philippe Mathieu-Daudé 2019-12-17 16:38 ` [PATCH 14/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef Philippe Mathieu-Daudé 2019-12-17 16:38 ` Philippe Mathieu-Daudé 2019-12-17 16:50 ` [PATCH 00/14] " Philippe Mathieu-Daudé 2019-12-17 16:50 ` Philippe Mathieu-Daudé
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191217163808.20068-9-philmd@redhat.com \ --to=philmd@redhat.com \ --cc=aleksandar.rikalo@rt-rk.com \ --cc=alex.bennee@linaro.org \ --cc=alistair@alistair23.me \ --cc=amarkovic@wavecomp.com \ --cc=amit@kernel.org \ --cc=antonynpavlov@gmail.com \ --cc=arei.gonglei@huawei.com \ --cc=armbru@redhat.com \ --cc=aurelien@aurel32.net \ --cc=berto@igalia.com \ --cc=borntraeger@de.ibm.com \ --cc=chen.zhang@intel.com \ --cc=chouteau@adacore.com \ --cc=cohuck@redhat.com \ --cc=dgilbert@redhat.com \ --cc=edgar.iglesias@gmail.com \ --cc=frederic.konrad@adacore.com \ --cc=huth@tuxfamily.org \ --cc=i.mitsyanko@gmail.com \ --cc=jasowang@redhat.com \ --cc=joel@jms.id.au \ --cc=kbastian@mail.uni-paderborn.de \ --cc=kraxel@redhat.com \ --cc=kwolf@redhat.com \ --cc=lizhijian@cn.fujitsu.com \ --cc=lvivier@redhat.com \ --cc=marcandre.lureau@redhat.com \ --cc=michael@walle.cc \ --cc=minyard@acm.org \ --cc=mreitz@redhat.com \ --cc=mst@redhat.com \ --cc=palmer@dabbelt.com \ --cc=pasic@linux.ibm.com \ --cc=pbonzini@redhat.com \ --cc=pburton@wavecomp.com \ --cc=peter.chubb@nicta.com.au \ --cc=peter.maydell@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ --cc=qemu-s390x@nongnu.org \ --cc=sagark@eecs.berkeley.edu \ --cc=samuel.thibault@ens-lyon.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.