All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v6 8/8] drm/i915/display: Add comment to a function that probably can be removed
Date: Fri, 20 Dec 2019 13:42:28 -0800	[thread overview]
Message-ID: <20191220214228.262345-8-jose.souza@intel.com> (raw)
In-Reply-To: <20191220214228.262345-1-jose.souza@intel.com>

This function is only called from port sync and it is identical to
what will be executed again in intel_update_crtc() over port sync
pipes.
If it is really necessary at least it deserves a better name and a
comment, leaving it to people working on port sync.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 3998bbfe2456..0b90ba0167f3 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -14483,6 +14483,10 @@ static void intel_set_dp_tp_ctl_normal(struct intel_crtc *crtc,
 	intel_dp_stop_link_train(intel_dp);
 }
 
+/*
+ * TODO: This is only called from port sync and it is identical to what will be
+ * executed again in intel_update_crtc() over port sync pipes
+ */
 static void intel_post_crtc_enable_updates(struct intel_crtc *crtc,
 					   struct intel_atomic_state *state)
 {
-- 
2.24.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-12-20 21:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20 21:42 [Intel-gfx] [PATCH v6 1/8] drm/i915: Introduce intel_crtc_state_alloc() José Roberto de Souza
2019-12-20 21:42 ` [Intel-gfx] [PATCH v6 2/8] drm/i915/display: Share intel_connector_needs_modeset() José Roberto de Souza
2019-12-20 21:42 ` [Intel-gfx] [PATCH v6 3/8] drm/i915/tgl: Select master transcoder for MST stream José Roberto de Souza
2019-12-20 21:42 ` [Intel-gfx] [PATCH v6 4/8] drm/i915/display: Always enables MST master pipe first José Roberto de Souza
2019-12-20 21:42 ` [Intel-gfx] [PATCH v6 5/8] drm/i915/dp: Fix MST disable sequence José Roberto de Souza
2019-12-20 21:42 ` [Intel-gfx] [PATCH v6 6/8] drm/i915/display: Prepare for fastset external dependencies check José Roberto de Souza
2019-12-20 21:42 ` [Intel-gfx] [PATCH v6 7/8] drm/i915/mst: Force modeset on MST slaves when master needs a modeset José Roberto de Souza
2019-12-20 21:42 ` José Roberto de Souza [this message]
2019-12-21  0:12 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v6,1/8] drm/i915: Introduce intel_crtc_state_alloc() Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191220214228.262345-8-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.