All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mihail Atanassov <Mihail.Atanassov@arm.com>
To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>, nd <nd@arm.com>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"freedreno@lists.freedesktop.org"
	<freedreno@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH v3 35/35] drm/msm: Use drm_bridge_init()
Date: Tue, 24 Dec 2019 17:34:55 +0000	[thread overview]
Message-ID: <20191224173408.25624-36-mihail.atanassov@arm.com> (raw)
In-Reply-To: <20191224173408.25624-1-mihail.atanassov@arm.com>

No functional change: drm_bridge_init() sets bridge->of_node, but that's
not used by msm anywhere, and the bridges aren't published with
drm_bridge_add() for it to matter.

v3:
 - drop driver_private argument (Laurent)

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
 drivers/gpu/drm/msm/dsi/dsi_manager.c  | 3 +--
 drivers/gpu/drm/msm/edp/edp_bridge.c   | 3 +--
 drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c
index 0fc29f1be8cc..058f8f9a8535 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_manager.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c
@@ -662,8 +662,7 @@ struct drm_bridge *msm_dsi_manager_bridge_init(u8 id)
 	encoder = msm_dsi->encoder;
 
 	bridge = &dsi_bridge->base;
-	bridge->funcs = &dsi_mgr_bridge_funcs;
-
+	drm_bridge_init(bridge, msm_dsi->dev->dev, &dsi_mgr_bridge_funcs, NULL);
 	ret = drm_bridge_attach(encoder, bridge, NULL);
 	if (ret)
 		goto fail;
diff --git a/drivers/gpu/drm/msm/edp/edp_bridge.c b/drivers/gpu/drm/msm/edp/edp_bridge.c
index 301dd7a80bde..1f1cc87d0dd2 100644
--- a/drivers/gpu/drm/msm/edp/edp_bridge.c
+++ b/drivers/gpu/drm/msm/edp/edp_bridge.c
@@ -95,8 +95,7 @@ struct drm_bridge *msm_edp_bridge_init(struct msm_edp *edp)
 	edp_bridge->edp = edp;
 
 	bridge = &edp_bridge->base;
-	bridge->funcs = &edp_bridge_funcs;
-
+	drm_bridge_init(bridge, edp->dev->dev, &edp_bridge_funcs, NULL);
 	ret = drm_bridge_attach(edp->encoder, bridge, NULL);
 	if (ret)
 		goto fail;
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
index 07c098dce310..ed62d0822615 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
@@ -285,8 +285,7 @@ struct drm_bridge *msm_hdmi_bridge_init(struct hdmi *hdmi)
 	hdmi_bridge->hdmi = hdmi;
 
 	bridge = &hdmi_bridge->base;
-	bridge->funcs = &msm_hdmi_bridge_funcs;
-
+	drm_bridge_init(bridge, hdmi->dev->dev, &msm_hdmi_bridge_funcs, NULL);
 	ret = drm_bridge_attach(hdmi->encoder, bridge, NULL);
 	if (ret)
 		goto fail;
-- 
2.24.0


WARNING: multiple messages have this Message-ID (diff)
From: Mihail Atanassov <Mihail.Atanassov@arm.com>
To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Cc: "freedreno@lists.freedesktop.org"
	<freedreno@lists.freedesktop.org>,
	Mihail Atanassov <Mihail.Atanassov@arm.com>,
	David Airlie <airlied@linux.ie>, Sam Ravnborg <sam@ravnborg.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	nd <nd@arm.com>, Sean Paul <sean@poorly.run>
Subject: [PATCH v3 35/35] drm/msm: Use drm_bridge_init()
Date: Tue, 24 Dec 2019 17:34:55 +0000	[thread overview]
Message-ID: <20191224173408.25624-36-mihail.atanassov@arm.com> (raw)
In-Reply-To: <20191224173408.25624-1-mihail.atanassov@arm.com>

No functional change: drm_bridge_init() sets bridge->of_node, but that's
not used by msm anywhere, and the bridges aren't published with
drm_bridge_add() for it to matter.

v3:
 - drop driver_private argument (Laurent)

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
 drivers/gpu/drm/msm/dsi/dsi_manager.c  | 3 +--
 drivers/gpu/drm/msm/edp/edp_bridge.c   | 3 +--
 drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c
index 0fc29f1be8cc..058f8f9a8535 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_manager.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c
@@ -662,8 +662,7 @@ struct drm_bridge *msm_dsi_manager_bridge_init(u8 id)
 	encoder = msm_dsi->encoder;
 
 	bridge = &dsi_bridge->base;
-	bridge->funcs = &dsi_mgr_bridge_funcs;
-
+	drm_bridge_init(bridge, msm_dsi->dev->dev, &dsi_mgr_bridge_funcs, NULL);
 	ret = drm_bridge_attach(encoder, bridge, NULL);
 	if (ret)
 		goto fail;
diff --git a/drivers/gpu/drm/msm/edp/edp_bridge.c b/drivers/gpu/drm/msm/edp/edp_bridge.c
index 301dd7a80bde..1f1cc87d0dd2 100644
--- a/drivers/gpu/drm/msm/edp/edp_bridge.c
+++ b/drivers/gpu/drm/msm/edp/edp_bridge.c
@@ -95,8 +95,7 @@ struct drm_bridge *msm_edp_bridge_init(struct msm_edp *edp)
 	edp_bridge->edp = edp;
 
 	bridge = &edp_bridge->base;
-	bridge->funcs = &edp_bridge_funcs;
-
+	drm_bridge_init(bridge, edp->dev->dev, &edp_bridge_funcs, NULL);
 	ret = drm_bridge_attach(edp->encoder, bridge, NULL);
 	if (ret)
 		goto fail;
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
index 07c098dce310..ed62d0822615 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
@@ -285,8 +285,7 @@ struct drm_bridge *msm_hdmi_bridge_init(struct hdmi *hdmi)
 	hdmi_bridge->hdmi = hdmi;
 
 	bridge = &hdmi_bridge->base;
-	bridge->funcs = &msm_hdmi_bridge_funcs;
-
+	drm_bridge_init(bridge, hdmi->dev->dev, &msm_hdmi_bridge_funcs, NULL);
 	ret = drm_bridge_attach(hdmi->encoder, bridge, NULL);
 	if (ret)
 		goto fail;
-- 
2.24.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-12-24 17:35 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-24 17:34 [PATCH v3 00/35] drm/bridge: Consolidate initialization Mihail Atanassov
2019-12-24 17:34 ` Mihail Atanassov
2019-12-24 17:34 ` Mihail Atanassov
2019-12-24 17:34 ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 01/35] drm: Remove drm_bridge->dev Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 02/35] drm/bridge: analogix_dp: Stop using drm_bridge->driver_private Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 03/35] drm/bridge/synopsys: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 04/35] drm/bridge: thc63lvd1024: Don't set drm_bridge->driver_private Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 05/35] drm/exynos: mic: Stop using drm_bridge->driver_private Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 06/35] drm: rcar-du: lvds: Don't set drm_bridge->driver_private Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 07/35] drm/sti: Stop using drm_bridge->driver_private Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 08/35] drm/bridge: Drop driver_private from struct drm_bridge Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 09/35] drm: Introduce drm_bridge_init() Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 10/35] drm/bridge: adv7511: Use drm_bridge_init() Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 11/35] drm/bridge/analogix: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 12/35] drm/bridge: cdns: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 13/35] drm/bridge: dumb-vga-dac: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 14/35] drm/bridge: lvds-codec: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 15/35] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 17/35] drm/bridge: panel: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 16/35] drm/bridge: nxp-ptn3460: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 18/35] drm/bridge: ps8622: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 19/35] drm/bridge: sii902x: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 20/35] drm/bridge: sii9234: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 21/35] drm/bridge: sil_sii8620: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 22/35] drm/bridge: dw-hdmi: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 23/35] drm/bridge/synopsys: dsi: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 24/35] drm/bridge: tc358764: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 25/35] drm/bridge: tc358767: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 26/35] drm/bridge: thc63: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 27/35] drm/bridge: ti-sn65dsi86: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 28/35] drm/bridge: ti-tfp410: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 29/35] drm/exynos: mic: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 30/35] drm/i2c: tda998x: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 31/35] drm/mcde: dsi: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 32/35] drm/mediatek: hdmi: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 33/35] drm: rcar-du: lvds: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` [PATCH v3 34/35] drm/sti: " Mihail Atanassov
2019-12-24 17:34   ` Mihail Atanassov
2019-12-24 17:34 ` Mihail Atanassov [this message]
2019-12-24 17:34   ` [PATCH v3 35/35] drm/msm: " Mihail Atanassov
2019-12-24 17:40 ` [PATCH v3 RESEND 01/35] drm: Remove drm_bridge->dev Mihail Atanassov
2019-12-24 17:40   ` Mihail Atanassov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191224173408.25624-36-mihail.atanassov@arm.com \
    --to=mihail.atanassov@arm.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nd@arm.com \
    --cc=robdclark@gmail.com \
    --cc=sam@ravnborg.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.