All of lore.kernel.org
 help / color / mirror / Atom feed
From: yu kuai <yukuai3@huawei.com>
To: <eric@anholt.net>, <airlied@linux.ie>, <daniel@ffwll.ch>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<yukuai3@huawei.com>, <yi.zhang@huawei.com>,
	<zhengbin13@huawei.com>
Subject: [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl
Date: Wed, 25 Dec 2019 21:17:15 +0800	[thread overview]
Message-ID: <20191225131715.3527-1-yukuai3@huawei.com> (raw)

v3d_submit_cl_ioctl call kfree() with variable 'bin' twice.

Fix it by removing the latter one.

Signed-off-by: yu kuai <yukuai3@huawei.com>
---
 drivers/gpu/drm/v3d/v3d_gem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index 549dde83408b..37515e47b47e 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++ b/drivers/gpu/drm/v3d/v3d_gem.c
@@ -568,7 +568,6 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data,
 		ret = v3d_job_init(v3d, file_priv, &bin->base,
 				   v3d_job_free, args->in_sync_bcl);
 		if (ret) {
-			kfree(bin);
 			v3d_job_put(&render->base);
 			kfree(bin);
 			return ret;
-- 
2.17.2


WARNING: multiple messages have this Message-ID (diff)
From: yu kuai <yukuai3@huawei.com>
To: <eric@anholt.net>, <airlied@linux.ie>, <daniel@ffwll.ch>
Cc: zhengbin13@huawei.com, yukuai3@huawei.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	yi.zhang@huawei.com
Subject: [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl
Date: Wed, 25 Dec 2019 21:17:15 +0800	[thread overview]
Message-ID: <20191225131715.3527-1-yukuai3@huawei.com> (raw)

v3d_submit_cl_ioctl call kfree() with variable 'bin' twice.

Fix it by removing the latter one.

Signed-off-by: yu kuai <yukuai3@huawei.com>
---
 drivers/gpu/drm/v3d/v3d_gem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index 549dde83408b..37515e47b47e 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++ b/drivers/gpu/drm/v3d/v3d_gem.c
@@ -568,7 +568,6 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data,
 		ret = v3d_job_init(v3d, file_priv, &bin->base,
 				   v3d_job_free, args->in_sync_bcl);
 		if (ret) {
-			kfree(bin);
 			v3d_job_put(&render->base);
 			kfree(bin);
 			return ret;
-- 
2.17.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2019-12-25 13:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-25 13:17 yu kuai [this message]
2019-12-25 13:17 ` [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl yu kuai
2019-12-28 20:45 ` Markus Elfring
2019-12-28 20:45   ` Markus Elfring
2019-12-29  1:19   ` yukuai (C)
2019-12-29  1:19     ` yukuai (C)
2019-12-29 12:14     ` Markus Elfring
2019-12-29 12:14       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191225131715.3527-1-yukuai3@huawei.com \
    --to=yukuai3@huawei.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.