From: roman.stratiienko@globallogic.com
To: mripard@kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jernej.skrabec@siol.net
Cc: Roman Stratiienko <roman.stratiienko@globallogic.com>
Subject: [RFC 4/4] drm/sun4i: Update mixer's internal registers after initialization
Date: Sat, 28 Dec 2019 22:28:18 +0200 [thread overview]
Message-ID: <20191228202818.69908-5-roman.stratiienko@globallogic.com> (raw)
In-Reply-To: <20191228202818.69908-1-roman.stratiienko@globallogic.com>
From: Roman Stratiienko <roman.stratiienko@globallogic.com>
At system start blink of u-boot ghost framebuffer can be observed.
Fix it.
Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
---
drivers/gpu/drm/sun4i/sun8i_mixer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index da84fccf7784..b906b8cc464e 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -588,6 +588,9 @@ static int sun8i_mixer_bind(struct device *dev, struct device *master,
regmap_update_bits(mixer->engine.regs, SUN8I_MIXER_BLEND_PIPE_CTL(base),
SUN8I_MIXER_BLEND_PIPE_CTL_EN_MSK, 0);
+ regmap_write(mixer->engine.regs, SUN8I_MIXER_GLOBAL_DBUFF,
+ SUN8I_MIXER_GLOBAL_DBUFF_ENABLE);
+
return 0;
err_disable_bus_clk:
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: roman.stratiienko@globallogic.com
To: mripard@kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jernej.skrabec@siol.net
Cc: Roman Stratiienko <roman.stratiienko@globallogic.com>
Subject: [RFC 4/4] drm/sun4i: Update mixer's internal registers after initialization
Date: Sat, 28 Dec 2019 22:28:18 +0200 [thread overview]
Message-ID: <20191228202818.69908-5-roman.stratiienko@globallogic.com> (raw)
In-Reply-To: <20191228202818.69908-1-roman.stratiienko@globallogic.com>
From: Roman Stratiienko <roman.stratiienko@globallogic.com>
At system start blink of u-boot ghost framebuffer can be observed.
Fix it.
Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
---
drivers/gpu/drm/sun4i/sun8i_mixer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index da84fccf7784..b906b8cc464e 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -588,6 +588,9 @@ static int sun8i_mixer_bind(struct device *dev, struct device *master,
regmap_update_bits(mixer->engine.regs, SUN8I_MIXER_BLEND_PIPE_CTL(base),
SUN8I_MIXER_BLEND_PIPE_CTL_EN_MSK, 0);
+ regmap_write(mixer->engine.regs, SUN8I_MIXER_GLOBAL_DBUFF,
+ SUN8I_MIXER_GLOBAL_DBUFF_ENABLE);
+
return 0;
err_disable_bus_clk:
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: roman.stratiienko@globallogic.com
To: mripard@kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jernej.skrabec@siol.net
Cc: Roman Stratiienko <roman.stratiienko@globallogic.com>
Subject: [RFC 4/4] drm/sun4i: Update mixer's internal registers after initialization
Date: Sat, 28 Dec 2019 22:28:18 +0200 [thread overview]
Message-ID: <20191228202818.69908-5-roman.stratiienko@globallogic.com> (raw)
In-Reply-To: <20191228202818.69908-1-roman.stratiienko@globallogic.com>
From: Roman Stratiienko <roman.stratiienko@globallogic.com>
At system start blink of u-boot ghost framebuffer can be observed.
Fix it.
Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
---
drivers/gpu/drm/sun4i/sun8i_mixer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index da84fccf7784..b906b8cc464e 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -588,6 +588,9 @@ static int sun8i_mixer_bind(struct device *dev, struct device *master,
regmap_update_bits(mixer->engine.regs, SUN8I_MIXER_BLEND_PIPE_CTL(base),
SUN8I_MIXER_BLEND_PIPE_CTL_EN_MSK, 0);
+ regmap_write(mixer->engine.regs, SUN8I_MIXER_GLOBAL_DBUFF,
+ SUN8I_MIXER_GLOBAL_DBUFF_ENABLE);
+
return 0;
err_disable_bus_clk:
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-28 20:28 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 20:28 roman.stratiienko
2019-12-28 20:28 ` roman.stratiienko
2019-12-28 20:28 ` [RFC 1/4] drm/sun4i: Wait for previous mixing process finish before committing next roman.stratiienko
2019-12-28 20:28 ` roman.stratiienko
2019-12-28 20:28 ` roman.stratiienko
2019-12-29 9:11 ` Jernej Škrabec
2019-12-29 9:11 ` Jernej Škrabec
2019-12-29 9:11 ` Jernej Škrabec
2019-12-28 20:28 ` [RFC 2/4] drm/sun4i: Use CRTC size instead of PRIMARY plane size as mixer frame roman.stratiienko
2019-12-28 20:28 ` roman.stratiienko
2019-12-28 20:28 ` roman.stratiienko
2019-12-29 9:20 ` Jernej Škrabec
2019-12-29 9:20 ` Jernej Škrabec
2019-12-29 9:20 ` Jernej Škrabec
2019-12-28 20:28 ` [RFC 3/4] drm/sun4i: Reimplement plane z position setting logic roman.stratiienko
2019-12-28 20:28 ` roman.stratiienko
2019-12-28 20:28 ` roman.stratiienko
2019-12-29 9:40 ` Jernej Škrabec
2019-12-29 9:40 ` Jernej Škrabec
2019-12-29 9:40 ` Jernej Škrabec
2019-12-29 12:08 ` Roman Stratiienko
2019-12-29 12:08 ` Roman Stratiienko
2019-12-29 12:08 ` Roman Stratiienko
2019-12-29 12:18 ` Jernej Škrabec
2019-12-29 12:18 ` Jernej Škrabec
2019-12-29 12:18 ` Jernej Škrabec
2019-12-29 12:47 ` Roman Stratiienko
2019-12-29 12:47 ` Roman Stratiienko
2019-12-29 12:47 ` Roman Stratiienko
2019-12-29 13:02 ` Jernej Škrabec
2019-12-29 13:02 ` Jernej Škrabec
2019-12-29 13:02 ` Jernej Škrabec
2019-12-29 13:13 ` Roman Stratiienko
2019-12-29 13:13 ` Roman Stratiienko
2019-12-29 13:13 ` Roman Stratiienko
2019-12-29 13:33 ` Jernej Škrabec
2019-12-29 13:33 ` Jernej Škrabec
2019-12-29 13:33 ` Jernej Škrabec
2020-01-02 9:49 ` Maxime Ripard
2020-01-02 9:49 ` Maxime Ripard
2020-01-02 9:49 ` Maxime Ripard
2019-12-28 20:28 ` roman.stratiienko [this message]
2019-12-28 20:28 ` [RFC 4/4] drm/sun4i: Update mixer's internal registers after initialization roman.stratiienko
2019-12-28 20:28 ` roman.stratiienko
2019-12-29 9:25 ` Jernej Škrabec
2019-12-29 9:25 ` Jernej Škrabec
2019-12-29 9:25 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191228202818.69908-5-roman.stratiienko@globallogic.com \
--to=roman.stratiienko@globallogic.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.