All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: linux-nfs@vger.kernel.org
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
Subject: [nfs-utils PATCH 5/7] rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning
Date: Fri,  3 Jan 2020 22:50:37 +0100	[thread overview]
Message-ID: <20200103215039.27471-6-giulio.benetti@benettiengineering.com> (raw)
In-Reply-To: <20200103215039.27471-1-giulio.benetti@benettiengineering.com>

format and vecformat must be declared as "char * const" to be really
treated as constant when building with -Werror=format-nonliteral,
otherwise compiler will consider them subject to change throughout the
function.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 tools/rpcgen/rpc_cout.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/rpcgen/rpc_cout.c b/tools/rpcgen/rpc_cout.c
index f806a86a..df2609c4 100644
--- a/tools/rpcgen/rpc_cout.c
+++ b/tools/rpcgen/rpc_cout.c
@@ -319,8 +319,8 @@ emit_union(definition *def)
   case_list *cl;
   declaration *cs;
   char *object;
-  char *vecformat = "objp->%s_u.%s";
-  char *format = "&objp->%s_u.%s";
+  char * const vecformat = "objp->%s_u.%s";
+  char * const format = "&objp->%s_u.%s";
 
   print_stat(1,&def->def.un.enum_decl);
   f_print(fout, "\tswitch (objp->%s) {\n", def->def.un.enum_decl.name);
-- 
2.20.1


  parent reply	other threads:[~2020-01-03 21:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03 21:50 [nfs-utils PATCH 0/7] silence some warning in rpcgen Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 1/7] rpcgen: rpc_cout: silence unused def parameter Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 2/7] rpcgen: rpc_util: add storeval args to prototype Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 3/7] rpcgen: rpc_util: add findval " Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 4/7] rpcgen: rpc_parse: add get_definition() void argument Giulio Benetti
2020-01-03 21:50 ` Giulio Benetti [this message]
2020-01-15 16:29   ` [nfs-utils PATCH 5/7] rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning Giulio Benetti
2020-01-16 20:07     ` Steve Dickson
2020-01-16 20:38       ` Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 6/7] rpcgen: rpc_hout: fix potential -Wformat-security warning Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 7/7] rpcgen: rpc_hout: fix indentation on f_print() argument separator Giulio Benetti
2020-01-07 19:06 ` [nfs-utils PATCH 0/7] silence some warning in rpcgen Steve Dickson
2020-01-09 14:00   ` Giulio Benetti
2020-01-09 15:10     ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200103215039.27471-6-giulio.benetti@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.