All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kai Li <li.kai4@h3c.com>
To: <jack@suse.cz>
Cc: <tytso@mit.edu>, <linux-ext4@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <joseph.qi@linux.alibaba.com>,
	<gechangwei@live.cn>, <wang.yongd@h3c.com>, <wang.xibo@h3c.com>,
	Kai Li <li.kai4@h3c.com>
Subject: [PATCH] jbd2: clear JBD2_ABORT flag before journal_reset to update log tail info when load journal
Date: Sat, 11 Jan 2020 10:25:42 +0800	[thread overview]
Message-ID: <20200111022542.5008-1-li.kai4@h3c.com> (raw)

Fixes: 85e0c4e89c1b "jbd2: if the journal is aborted then don't allow update of the log tail"

If journal is dirty when mount, it will be replayed but jbd2 sb
log tail cannot be updated to mark a new start because
journal->j_flags has already been set with JBD2_ABORT first
in journal_init_common.
When a new transaction is committed, it will be recorded in block 1
first(journal->j_tail is set to 1 in journal_reset). If emergency
restart again before journal super block is updated unfortunately,
the new recorded trans will not be replayed in the next mount.
It is danerous which may lead to metadata corruption for file system.

Signed-off-by: Kai Li <li.kai4@h3c.com>
---
 fs/jbd2/journal.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 5e408ee24a1a..069b22eba795 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1710,6 +1710,11 @@ int jbd2_journal_load(journal_t *journal)
 		       journal->j_devname);
 		return -EFSCORRUPTED;
 	}
+	/*
+	 * clear JBD2_ABORT flag initialized in journal_init_common
+	 * here to update log tail information with the newest seq.
+	 */
+	journal->j_flags &= ~JBD2_ABORT;
 
 	/* OK, we've finished with the dynamic journal bits:
 	 * reinitialise the dynamic contents of the superblock in memory
@@ -1717,7 +1722,6 @@ int jbd2_journal_load(journal_t *journal)
 	if (journal_reset(journal))
 		goto recovery_error;
 
-	journal->j_flags &= ~JBD2_ABORT;
 	journal->j_flags |= JBD2_LOADED;
 	return 0;
 
-- 
2.24.0.windows.2


             reply	other threads:[~2020-01-11  2:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-11  2:25 Kai Li [this message]
2020-01-14 10:31 ` [PATCH] jbd2: clear JBD2_ABORT flag before journal_reset to update log tail info when load journal Jan Kara
2020-01-17 21:26   ` Theodore Y. Ts'o
2020-01-20  6:30     ` Likai
2020-12-02 12:01       ` yebin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200111022542.5008-1-li.kai4@h3c.com \
    --to=li.kai4@h3c.com \
    --cc=gechangwei@live.cn \
    --cc=jack@suse.cz \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=wang.xibo@h3c.com \
    --cc=wang.yongd@h3c.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.