From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz
Subject: [PATCH 3/4] btrfs: make the scan logs consistent
Date: Tue, 14 Jan 2020 14:09:19 +0800 [thread overview]
Message-ID: <20200114060920.4527-3-anand.jain@oracle.com> (raw)
In-Reply-To: <20200114060920.4527-1-anand.jain@oracle.com>
Typically we follow, a logging format <parameter> <value> and no ":"
so just follow that here.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
David,
If required you may roll this into the patch 2/4 in this series. I didn't
dare, as there may be some concerns that it isn't relevent there.
fs/btrfs/volumes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 0301c3d693d8..bafc57bc02c8 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -890,14 +890,14 @@ static noinline struct btrfs_device *device_list_add(const char *path,
bdput(path_bdev);
mutex_unlock(&fs_devices->device_list_mutex);
btrfs_warn_in_rcu(NO_FS_INFO,
- "duplicate device fsid:devid for %pU:%llu old:%s new:%s",
+ "duplicate device fsid %pU devid %llu exisitng %s new %s",
disk_super->fsid, devid,
rcu_str_deref(device->name), path);
return ERR_PTR(-EEXIST);
}
bdput(path_bdev);
btrfs_info_in_rcu(NO_FS_INFO,
- "device fsid %pU devid %llu moved old:%s new:%s",
+ "device fsid %pU devid %llu moved old %s new %s",
disk_super->fsid, devid,
rcu_str_deref(device->name), path);
}
--
2.23.0
next prev parent reply other threads:[~2020-01-14 6:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 6:09 [PATCH 1/4] btrfs: add NO_FS_INFO to btrfs_printk Anand Jain
2020-01-14 6:09 ` [PATCH 2/4] btrfs: stop using uninitiazlised fs_info in device_list_add() Anand Jain
2020-01-14 6:58 ` Qu Wenruo
2020-01-14 7:30 ` Nikolay Borisov
2020-01-14 6:09 ` Anand Jain [this message]
2020-01-14 6:09 ` [PATCH 4/4] btrfs: use btrfs consistent logging wrappers Anand Jain
2020-01-14 6:54 ` [PATCH 1/4] btrfs: add NO_FS_INFO to btrfs_printk Qu Wenruo
2020-01-14 7:21 ` Anand Jain
2020-01-14 7:31 ` Nikolay Borisov
2020-01-14 7:33 ` Qu Wenruo
2020-01-22 15:50 ` David Sterba
2020-01-23 7:22 ` Anand Jain
2020-02-03 4:06 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114060920.4527-3-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.