All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 07/13] drm/i915/gt: Expose engine->mmio_base via sysfs
Date: Tue, 14 Jan 2020 09:36:42 +0000	[thread overview]
Message-ID: <20200114093648.2090633-7-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20200114093648.2090633-1-chris@chris-wilson.co.uk>

Use the per-engine sysfs directory to let userspace discover the
mmio_base of each engine. Prior to recent generations, the user
accessible registers on each engine are at a fixed offset relative to
each engine -- but require absolute addressing. As the absolute address
depends on the actual physical engine, this is not always possible to
determine from userspace (for example icl may expose vcs1 or vcs2 as the
second vcs engine). Make this easy for userspace to discover by
providing the mmio_base in sysfs.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_engine_sysfs.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_engine_sysfs.c b/drivers/gpu/drm/i915/gt/intel_engine_sysfs.c
index df263af3a9ea..abddd8d0f9ae 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_sysfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_engine_sysfs.c
@@ -48,6 +48,15 @@ inst_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
 static struct kobj_attribute inst_attr =
 __ATTR(instance, 0444, inst_show, NULL);
 
+static ssize_t
+mmio_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
+{
+	return sprintf(buf, "0x%x\n", kobj_to_engine(kobj)->mmio_base);
+}
+
+static struct kobj_attribute mmio_attr =
+__ATTR(mmio_base, 0444, mmio_show, NULL);
+
 static const char * const vcs_caps[] = {
 	[ilog2(I915_VIDEO_CLASS_CAPABILITY_HEVC)] = "hevc",
 	[ilog2(I915_VIDEO_AND_ENHANCE_CLASS_CAPABILITY_SFC)] = "sfc",
@@ -170,6 +179,7 @@ void intel_engines_add_sysfs(struct drm_i915_private *i915)
 		&name_attr.attr,
 		&class_attr.attr,
 		&inst_attr.attr,
+		&mmio_attr.attr,
 		&caps_attr.attr,
 		&all_caps_attr.attr,
 		NULL
-- 
2.25.0.rc2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-01-14  9:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14  9:36 [Intel-gfx] [PATCH 01/13] drm/i915: Flush idle barriers when waiting Chris Wilson
2020-01-14  9:36 ` [Intel-gfx] [PATCH 02/13] drm/i915: Allow userspace to specify ringsize on construction Chris Wilson
2020-01-14  9:36 ` [Intel-gfx] [PATCH 03/13] drm/i915/gem: Honour O_NONBLOCK before throttling execbuf submissions Chris Wilson
2020-01-14  9:36 ` [Intel-gfx] [PATCH 04/13] drm/i915: Only retire requests when eviction is allowed to blocked Chris Wilson
2020-01-14  9:36 ` [Intel-gfx] [PATCH 05/13] drm/i915: Disable preemption support on Icelake Chris Wilson
2020-01-14  9:36 ` [Intel-gfx] [PATCH 06/13] drm/i915/gt: Expose engine properties via sysfs Chris Wilson
2020-01-14  9:36 ` Chris Wilson [this message]
2020-01-14  9:36 ` [Intel-gfx] [PATCH 08/13] drm/i915/gt: Expose timeslice duration to sysfs Chris Wilson
2020-01-14  9:36 ` [Intel-gfx] [PATCH 09/13] drm/i915/gt: Expose busywait " Chris Wilson
2020-01-14  9:36 ` [Intel-gfx] [PATCH 10/13] drm/i915/gt: Expose reset stop timeout via sysfs Chris Wilson
2020-01-14  9:36 ` [Intel-gfx] [PATCH 11/13] drm/i915/gt: Expose preempt reset " Chris Wilson
2020-01-14  9:36 ` [Intel-gfx] [PATCH 12/13] drm/i915/gt: Expose heartbeat interval " Chris Wilson
2020-01-14  9:36 ` [Intel-gfx] [PATCH 13/13] drm/i915/gt: Limit C-states while waiting for requests Chris Wilson
2020-01-14 15:12   ` Mika Kuoppala
2020-01-14 15:18     ` Chris Wilson
2020-01-14 10:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/13] drm/i915: Flush idle barriers when waiting Patchwork
2020-01-14 10:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-01-14 10:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-14 10:38 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-16 11:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200114093648.2090633-7-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.