From: Guenter Roeck <linux@roeck-us.net>
To: linux-hwmon@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Clemens Ladisch" <clemens@ladisch.de>,
"Jean Delvare" <jdelvare@suse.com>,
"Darren Salt" <devspam@moreofthesa.me.uk>,
"Bernhard Gebetsberger" <bernhard.gebetsberger@gmx.at>,
"Ken Moffat" <zarniwhoop73@googlemail.com>,
"Ondrej Čerman" <ocerman@sda1.eu>,
"Holger Kiehl" <Holger.Kiehl@dwd.de>,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
"Brad Campbell" <lists2009@fnarfbargle.com>,
"Guenter Roeck" <linux@roeck-us.net>
Subject: [PATCH v2 5/5] hwmon: (k10temp) Don't show temperature limits on Ryzen (Zen) CPUs
Date: Sat, 18 Jan 2020 09:26:15 -0800 [thread overview]
Message-ID: <20200118172615.26329-6-linux@roeck-us.net> (raw)
In-Reply-To: <20200118172615.26329-1-linux@roeck-us.net>
The maximum Tdie or Tctl is not published for Ryzen CPUs. What is
known, however, is that the traditional value of 70 degrees C is no
longer correct. Displaying it is meaningless, confusing, and wrong.
Stop doing it.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v2: Added patch.
drivers/hwmon/k10temp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index a4313b662a3a..cdfebe435003 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -347,7 +347,7 @@ static umode_t k10temp_is_visible(const void *_data,
}
break;
case hwmon_temp_max:
- if (channel)
+ if (channel || data->show_tdie)
return 0;
break;
case hwmon_temp_crit:
--
2.17.1
next prev parent reply other threads:[~2020-01-18 17:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 17:26 [PATCH v2 0/5] hwmon: k10temp driver improvements Guenter Roeck
2020-01-18 17:26 ` [PATCH v2 1/5] hwmon: (k10temp) Use bitops Guenter Roeck
2020-01-18 17:26 ` [PATCH v2 2/5] hmon: (k10temp) Convert to use devm_hwmon_device_register_with_info Guenter Roeck
2020-01-18 17:26 ` [PATCH v2 3/5] hwmon: (k10temp) Report temperatures per CPU die Guenter Roeck
2020-01-18 17:26 ` [PATCH v2 4/5] hwmon: (k10temp) Show core and SoC current and voltages on Ryzen CPUs Guenter Roeck
2020-01-18 17:26 ` Guenter Roeck [this message]
2020-01-19 0:33 ` [PATCH v2 0/5] hwmon: k10temp driver improvements Ken Moffat
2020-01-19 0:48 ` Guenter Roeck
2020-01-19 1:08 ` Ken Moffat
2020-01-19 3:13 ` Brad Campbell
2020-01-19 10:18 ` Jonathan McDowell
2020-01-19 15:46 ` Guenter Roeck
2020-01-19 19:38 ` Jonathan McDowell
2020-01-19 13:38 ` Holger Kiehl
2020-01-19 15:49 ` Guenter Roeck
2020-01-21 6:27 ` Andreas Hartmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200118172615.26329-6-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Holger.Kiehl@dwd.de \
--cc=bernhard.gebetsberger@gmx.at \
--cc=clemens@ladisch.de \
--cc=devspam@moreofthesa.me.uk \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists2009@fnarfbargle.com \
--cc=ocerman@sda1.eu \
--cc=sebastian.reichel@collabora.com \
--cc=zarniwhoop73@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.