All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org, richardw.yang@linux.intel.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com
Subject: [Patch v2 2/4] mm/page_alloc.c: bad_[reason|flags] is not necessary when PageHWPoison
Date: Mon, 20 Jan 2020 11:04:13 +0800	[thread overview]
Message-ID: <20200120030415.15925-3-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20200120030415.15925-1-richardw.yang@linux.intel.com>

Since function returns directly, bad_[reason|flags] is not used any
where.

This is a following cleanup for commit e570f56cccd21 ("mm:
check_new_page_bad() directly returns in __PG_HWPOISON case")

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Acked-by: David Rientjes <rientjes@google.com>
---
 mm/page_alloc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 0cf6218aaba7..a43b9d2482f2 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2051,8 +2051,6 @@ static void check_new_page_bad(struct page *page)
 	if (unlikely(page_ref_count(page) != 0))
 		bad_reason = "nonzero _refcount";
 	if (unlikely(page->flags & __PG_HWPOISON)) {
-		bad_reason = "HWPoisoned (hardware-corrupted)";
-		bad_flags = __PG_HWPOISON;
 		/* Don't complain about hwpoisoned pages */
 		page_mapcount_reset(page); /* remove PageBuddy */
 		return;
-- 
2.17.1


  parent reply	other threads:[~2020-01-20  3:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20  3:04 [Patch v2 0/4] mm/page_alloc.c: cleanup on check page Wei Yang
2020-01-20  3:04 ` [Patch v2 1/4] mm: enable dump several reasons for __dump_page() Wei Yang
2020-01-20  6:12   ` Anshuman Khandual
2020-01-20  8:55     ` Wei Yang
2020-01-21  5:20       ` Anshuman Khandual
2020-01-22  0:58         ` Wei Yang
2020-01-26  2:44         ` Wei Yang
2020-01-20  3:04 ` Wei Yang [this message]
2020-01-20  6:28   ` [Patch v2 2/4] mm/page_alloc.c: bad_[reason|flags] is not necessary when PageHWPoison Anshuman Khandual
2020-01-20 12:13     ` Wei Yang
2020-01-20 10:17   ` Michal Hocko
2020-01-20 12:20   ` David Hildenbrand
2020-01-20  3:04 ` [Patch v2 3/4] mm/page_alloc.c: pass all bad reasons to bad_page() Wei Yang
2020-01-20  6:33   ` Anshuman Khandual
2020-01-20 12:33     ` Wei Yang
2020-01-20 10:22   ` Michal Hocko
2020-01-20 12:19     ` David Hildenbrand
2020-01-21  1:49       ` Wei Yang
2020-01-21  6:08     ` Anshuman Khandual
2020-01-21  8:47       ` Michal Hocko
2020-01-20  3:04 ` [Patch v2 4/4] mm/page_alloc.c: extract commom part to check page Wei Yang
2020-01-20  6:43   ` Anshuman Khandual
2020-01-20 12:36     ` Wei Yang
2020-01-21  4:49       ` Anshuman Khandual
2020-01-22  1:00         ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200120030415.15925-3-richardw.yang@linux.intel.com \
    --to=richardw.yang@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.