All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bulekov, Alexander" <alxndr@bu.edu>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	"Bulekov, Alexander" <alxndr@bu.edu>,
	"bsd@redhat.com" <bsd@redhat.com>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: [PATCH v8 04/21] qtest: add qtest_server_send abstraction
Date: Wed, 29 Jan 2020 05:34:14 +0000	[thread overview]
Message-ID: <20200129053357.27454-5-alxndr@bu.edu> (raw)
In-Reply-To: <20200129053357.27454-1-alxndr@bu.edu>

qtest_server_send is a function pointer specifying the handler used to
transmit data to the qtest client. In the standard configuration, this
calls the CharBackend handler, but now it is possible for other types of
handlers, e.g direct-function calls if the qtest client and server
exist within the same process (inproc)

Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Thomas Huth <thuth@redhat.com>
---
 include/sysemu/qtest.h |  3 +++
 qtest.c                | 18 ++++++++++++++++--
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/include/sysemu/qtest.h b/include/sysemu/qtest.h
index 5ed09c80b1..e2f1047fd7 100644
--- a/include/sysemu/qtest.h
+++ b/include/sysemu/qtest.h
@@ -26,4 +26,7 @@ bool qtest_driver(void);
 
 void qtest_server_init(const char *qtest_chrdev, const char *qtest_log, Error **errp);
 
+void qtest_server_set_send_handler(void (*send)(void *, const char *),
+                                 void *opaque);
+
 #endif
diff --git a/qtest.c b/qtest.c
index 12432f99cf..938c3746d6 100644
--- a/qtest.c
+++ b/qtest.c
@@ -42,6 +42,8 @@ static GString *inbuf;
 static int irq_levels[MAX_IRQ];
 static qemu_timeval start_time;
 static bool qtest_opened;
+static void (*qtest_server_send)(void*, const char*);
+static void *qtest_server_send_opaque;
 
 #define FMT_timeval "%ld.%06ld"
 
@@ -228,8 +230,10 @@ static void GCC_FMT_ATTR(1, 2) qtest_log_send(const char *fmt, ...)
     va_end(ap);
 }
 
-static void do_qtest_send(CharBackend *chr, const char *str, size_t len)
+static void qtest_server_char_be_send(void *opaque, const char *str)
 {
+    size_t len = strlen(str);
+    CharBackend* chr = (CharBackend *)opaque;
     qemu_chr_fe_write_all(chr, (uint8_t *)str, len);
     if (qtest_log_fp && qtest_opened) {
         fprintf(qtest_log_fp, "%s", str);
@@ -238,7 +242,7 @@ static void do_qtest_send(CharBackend *chr, const char *str, size_t len)
 
 static void qtest_send(CharBackend *chr, const char *str)
 {
-    do_qtest_send(chr, str, strlen(str));
+    qtest_server_send(qtest_server_send_opaque, str);
 }
 
 static void GCC_FMT_ATTR(2, 3) qtest_sendf(CharBackend *chr,
@@ -783,6 +787,16 @@ void qtest_server_init(const char *qtest_chrdev, const char *qtest_log, Error **
     qemu_chr_fe_set_echo(&qtest_chr, true);
 
     inbuf = g_string_new("");
+
+    if (!qtest_server_send) {
+        qtest_server_set_send_handler(qtest_server_char_be_send, &qtest_chr);
+    }
+}
+
+void qtest_server_set_send_handler(void (*send)(void*, const char*), void *opaque)
+{
+    qtest_server_send = send;
+    qtest_server_send_opaque = opaque;
 }
 
 bool qtest_driver(void)
-- 
2.23.0



  parent reply	other threads:[~2020-01-29  5:38 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29  5:34 [PATCH v8 00/21] Add virtual device fuzzing support Bulekov, Alexander
2020-01-29  5:34 ` [PATCH v8 01/21] softmmu: split off vl.c:main() into main.c Bulekov, Alexander
2020-01-30 14:39   ` Stefan Hajnoczi
2020-01-30 15:06   ` Alex Bennée
2020-01-30 17:44     ` Alexander Bulekov
2020-01-30 18:41       ` Alex Bennée
2020-02-05 14:02   ` Darren Kenny
2020-01-29  5:34 ` [PATCH v8 02/21] module: check module wasn't already initialized Bulekov, Alexander
2020-01-29  5:34 ` [PATCH v8 03/21] fuzz: add FUZZ_TARGET module type Bulekov, Alexander
2020-02-05 11:28   ` Darren Kenny
2020-01-29  5:34 ` Bulekov, Alexander [this message]
2020-02-05 11:30   ` [PATCH v8 04/21] qtest: add qtest_server_send abstraction Darren Kenny
2020-01-29  5:34 ` [PATCH v8 05/21] libqtest: add a layer of abstraction to send/recv Bulekov, Alexander
2020-02-05 11:32   ` Darren Kenny
2020-01-29  5:34 ` [PATCH v8 06/21] libqtest: make bufwrite rely on the TransportOps Bulekov, Alexander
2020-02-05 11:36   ` Darren Kenny
2020-01-29  5:34 ` [PATCH v8 07/21] qtest: add in-process incoming command handler Bulekov, Alexander
2020-02-05 11:39   ` Darren Kenny
2020-01-29  5:34 ` [PATCH v8 08/21] libqos: rename i2c_send and i2c_recv Bulekov, Alexander
2020-02-05 11:40   ` Darren Kenny
2020-01-29  5:34 ` [PATCH v8 09/21] libqos: split qos-test and libqos makefile vars Bulekov, Alexander
2020-01-29  5:34 ` [PATCH v8 10/21] libqos: move useful qos-test funcs to qos_external Bulekov, Alexander
2020-01-29 10:03   ` Paolo Bonzini
2020-02-05 13:34   ` Darren Kenny
2020-01-29  5:34 ` [PATCH v8 11/21] fuzz: add fuzzer skeleton Bulekov, Alexander
2020-02-05 11:55   ` Darren Kenny
2020-01-29  5:34 ` [PATCH v8 12/21] exec: keep ram block across fork when using qtest Bulekov, Alexander
2020-02-05 13:00   ` Darren Kenny
2020-01-29  5:34 ` [PATCH v8 13/21] main: keep rcu_atfork callback enabled for qtest Bulekov, Alexander
2020-01-30 14:42   ` Stefan Hajnoczi
2020-01-30 17:24     ` Paolo Bonzini
2020-01-30 17:42       ` Alexander Bulekov
2020-01-30 18:14         ` Paolo Bonzini
2020-02-05 13:58   ` Darren Kenny
2020-06-18  7:34   ` Thomas Huth
2020-06-18 15:08     ` Alexander Bulekov
2020-01-29  5:34 ` [PATCH v8 14/21] fuzz: support for fork-based fuzzing Bulekov, Alexander
2020-01-29  5:34 ` [PATCH v8 16/21] fuzz: add target/fuzz makefile rules Bulekov, Alexander
2020-01-29  5:34 ` [PATCH v8 15/21] fuzz: add support for qos-assisted fuzz targets Bulekov, Alexander
2020-02-05 13:18   ` Darren Kenny
2020-02-11 16:19     ` Alexander Bulekov
2020-01-29  5:34 ` [PATCH v8 17/21] fuzz: add configure flag --enable-fuzzing Bulekov, Alexander
2020-02-05 13:19   ` Darren Kenny
2020-01-29  5:34 ` [PATCH v8 18/21] fuzz: add i440fx fuzz targets Bulekov, Alexander
2020-02-05 13:26   ` Darren Kenny
2020-02-06 14:47     ` Alexander Bulekov
2020-01-29  5:34 ` [PATCH v8 19/21] fuzz: add virtio-net fuzz target Bulekov, Alexander
2020-01-30 14:43   ` Stefan Hajnoczi
2020-02-05 13:57   ` Darren Kenny
2020-02-06 14:51     ` Alexander Bulekov
2020-01-29  5:34 ` [PATCH v8 20/21] fuzz: add virtio-scsi " Bulekov, Alexander
2020-02-05 13:31   ` Darren Kenny
2020-01-29  5:34 ` [PATCH v8 21/21] fuzz: add documentation to docs/devel/ Bulekov, Alexander
2020-02-05 13:33   ` Darren Kenny
2020-01-30 14:44 ` [PATCH v8 00/21] Add virtual device fuzzing support Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200129053357.27454-5-alxndr@bu.edu \
    --to=alxndr@bu.edu \
    --cc=bsd@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.