All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org,
	sean@poorly.run, oleksandr_andrushchenko@epam.com,
	sam@ravnborg.org, laurent.pinchart@ideasonboard.com,
	emil.velikov@collabora.com
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org
Subject: [PATCH v5 10/15] drm/repaper: Remove sending of vblank event
Date: Wed, 29 Jan 2020 13:05:26 +0100	[thread overview]
Message-ID: <20200129120531.6891-11-tzimmermann@suse.de> (raw)
In-Reply-To: <20200129120531.6891-1-tzimmermann@suse.de>

The atomic helpers automatically send out fake VBLANK events if no
vblanking has been initialized. Remove the sending code from the
driver.

v4:
	* separate commit from core vblank changes

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/tiny/repaper.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c
index 76d179200775..183484595aea 100644
--- a/drivers/gpu/drm/tiny/repaper.c
+++ b/drivers/gpu/drm/tiny/repaper.c
@@ -33,7 +33,6 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_modes.h>
 #include <drm/drm_rect.h>
-#include <drm/drm_vblank.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 
@@ -856,18 +855,10 @@ static void repaper_pipe_update(struct drm_simple_display_pipe *pipe,
 				struct drm_plane_state *old_state)
 {
 	struct drm_plane_state *state = pipe->plane.state;
-	struct drm_crtc *crtc = &pipe->crtc;
 	struct drm_rect rect;
 
 	if (drm_atomic_helper_damage_merged(old_state, state, &rect))
 		repaper_fb_dirty(state->fb);
-
-	if (crtc->state->event) {
-		spin_lock_irq(&crtc->dev->event_lock);
-		drm_crtc_send_vblank_event(crtc, crtc->state->event);
-		spin_unlock_irq(&crtc->dev->event_lock);
-		crtc->state->event = NULL;
-	}
 }
 
 static const struct drm_simple_display_pipe_funcs repaper_pipe_funcs = {
-- 
2.25.0

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org,
	sean@poorly.run, oleksandr_andrushchenko@epam.com,
	sam@ravnborg.org, laurent.pinchart@ideasonboard.com,
	emil.velikov@collabora.com
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org
Subject: [PATCH v5 10/15] drm/repaper: Remove sending of vblank event
Date: Wed, 29 Jan 2020 13:05:26 +0100	[thread overview]
Message-ID: <20200129120531.6891-11-tzimmermann@suse.de> (raw)
In-Reply-To: <20200129120531.6891-1-tzimmermann@suse.de>

The atomic helpers automatically send out fake VBLANK events if no
vblanking has been initialized. Remove the sending code from the
driver.

v4:
	* separate commit from core vblank changes

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/tiny/repaper.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c
index 76d179200775..183484595aea 100644
--- a/drivers/gpu/drm/tiny/repaper.c
+++ b/drivers/gpu/drm/tiny/repaper.c
@@ -33,7 +33,6 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_modes.h>
 #include <drm/drm_rect.h>
-#include <drm/drm_vblank.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 
@@ -856,18 +855,10 @@ static void repaper_pipe_update(struct drm_simple_display_pipe *pipe,
 				struct drm_plane_state *old_state)
 {
 	struct drm_plane_state *state = pipe->plane.state;
-	struct drm_crtc *crtc = &pipe->crtc;
 	struct drm_rect rect;
 
 	if (drm_atomic_helper_damage_merged(old_state, state, &rect))
 		repaper_fb_dirty(state->fb);
-
-	if (crtc->state->event) {
-		spin_lock_irq(&crtc->dev->event_lock);
-		drm_crtc_send_vblank_event(crtc, crtc->state->event);
-		spin_unlock_irq(&crtc->dev->event_lock);
-		crtc->state->event = NULL;
-	}
 }
 
 static const struct drm_simple_display_pipe_funcs repaper_pipe_funcs = {
-- 
2.25.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org,
	sean@poorly.run, oleksandr_andrushchenko@epam.com,
	sam@ravnborg.org, laurent.pinchart@ideasonboard.com,
	emil.velikov@collabora.com
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org
Subject: [Xen-devel] [PATCH v5 10/15] drm/repaper: Remove sending of vblank event
Date: Wed, 29 Jan 2020 13:05:26 +0100	[thread overview]
Message-ID: <20200129120531.6891-11-tzimmermann@suse.de> (raw)
In-Reply-To: <20200129120531.6891-1-tzimmermann@suse.de>

The atomic helpers automatically send out fake VBLANK events if no
vblanking has been initialized. Remove the sending code from the
driver.

v4:
	* separate commit from core vblank changes

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/tiny/repaper.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c
index 76d179200775..183484595aea 100644
--- a/drivers/gpu/drm/tiny/repaper.c
+++ b/drivers/gpu/drm/tiny/repaper.c
@@ -33,7 +33,6 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_modes.h>
 #include <drm/drm_rect.h>
-#include <drm/drm_vblank.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 
@@ -856,18 +855,10 @@ static void repaper_pipe_update(struct drm_simple_display_pipe *pipe,
 				struct drm_plane_state *old_state)
 {
 	struct drm_plane_state *state = pipe->plane.state;
-	struct drm_crtc *crtc = &pipe->crtc;
 	struct drm_rect rect;
 
 	if (drm_atomic_helper_damage_merged(old_state, state, &rect))
 		repaper_fb_dirty(state->fb);
-
-	if (crtc->state->event) {
-		spin_lock_irq(&crtc->dev->event_lock);
-		drm_crtc_send_vblank_event(crtc, crtc->state->event);
-		spin_unlock_irq(&crtc->dev->event_lock);
-		crtc->state->event = NULL;
-	}
 }
 
 static const struct drm_simple_display_pipe_funcs repaper_pipe_funcs = {
-- 
2.25.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2020-01-29 12:05 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 12:05 [PATCH v5 00/15] Use no_vblank property for drivers without VBLANK Thomas Zimmermann
2020-01-29 12:05 ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05 ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 01/15] drm: Initialize struct drm_crtc_state.no_vblank from device settings Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 02/15] drm/arc: Remove sending of vblank event Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 03/15] drm/ast: Don't set struct drm_crtc_state.no_vblank explictly Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 04/15] drm/bochs: Remove sending of vblank event Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 05/15] drm/cirrus: " Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 06/15] drm/gm12u320: " Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 07/15] drm/ili9225: " Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 08/15] drm/mipi-dbi: " Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 09/15] drm/qxl: " Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` Thomas Zimmermann [this message]
2020-01-29 12:05   ` [Xen-devel] [PATCH v5 10/15] drm/repaper: " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 11/15] drm/st7586: " Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 12/15] drm/udl: Don't set struct drm_crtc_state.no_vblank explictly Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 13/15] drm/vboxvideo: Remove sending of vblank event Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 14/15] drm/virtio: " Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 12:05 ` [PATCH v5 15/15] drm/xen: Explicitly disable automatic " Thomas Zimmermann
2020-01-29 12:05   ` [Xen-devel] " Thomas Zimmermann
2020-01-29 12:05   ` Thomas Zimmermann
2020-01-29 13:00   ` Oleksandr Andrushchenko
2020-01-29 13:00     ` [Xen-devel] " Oleksandr Andrushchenko
2020-01-29 13:00     ` Oleksandr Andrushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200129120531.6891-11-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@ffwll.ch \
    --cc=david@lechnology.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.velikov@collabora.com \
    --cc=hdegoede@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=noralf@tronnes.org \
    --cc=oleksandr_andrushchenko@epam.com \
    --cc=sam@ravnborg.org \
    --cc=sean@poorly.run \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.