All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	david@redhat.com, Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: [kvm-unit-tests PULL 5/6] s390x: lib: fix program interrupt handler if sclp_busy was set
Date: Thu, 30 Jan 2020 14:11:15 +0100	[thread overview]
Message-ID: <20200130131116.12386-6-david@redhat.com> (raw)
In-Reply-To: <20200130131116.12386-1-david@redhat.com>

From: Claudio Imbrenda <imbrenda@linux.ibm.com>

Fix the program interrupt handler for the case where sclp_busy is set.

The interrupt handler will attempt to write an error message on the
console using the SCLP, and will wait for sclp_busy to become false
before doing so. If an exception happenes between setting the flag and
the SCLP call, or if the call itself raises an exception, we need to
clear the flag so we can successfully print the error message.

Acked-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Message-Id: <20200120184256.188698-6-imbrenda@linux.ibm.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 lib/s390x/interrupt.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/s390x/interrupt.c b/lib/s390x/interrupt.c
index 05f30be..ccb376a 100644
--- a/lib/s390x/interrupt.c
+++ b/lib/s390x/interrupt.c
@@ -106,10 +106,13 @@ static void fixup_pgm_int(void)
 
 void handle_pgm_int(void)
 {
-	if (!pgm_int_expected)
+	if (!pgm_int_expected) {
+		/* Force sclp_busy to false, otherwise we will loop forever */
+		sclp_handle_ext();
 		report_abort("Unexpected program interrupt: %d at %#lx, ilen %d\n",
 			     lc->pgm_int_code, lc->pgm_old_psw.addr,
 			     lc->pgm_int_id);
+	}
 
 	pgm_int_expected = false;
 	fixup_pgm_int();
-- 
2.24.1


  parent reply	other threads:[~2020-01-30 13:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30 13:11 [kvm-unit-tests PULL 0/6] s390x updates David Hildenbrand
2020-01-30 13:11 ` [kvm-unit-tests PULL 1/6] s390x: export sclp_setup_int David Hildenbrand
2020-01-30 13:11 ` [kvm-unit-tests PULL 2/6] s390x: sclp: add service call instruction wrapper David Hildenbrand
2020-01-30 13:11 ` [kvm-unit-tests PULL 3/6] s390x: lib: fix stfl wrapper asm David Hildenbrand
2020-01-30 13:11 ` [kvm-unit-tests PULL 4/6] s390x: lib: add SPX and STPX instruction wrapper David Hildenbrand
2020-01-30 13:11 ` David Hildenbrand [this message]
2020-01-30 13:11 ` [kvm-unit-tests PULL 6/6] s390x: SCLP unit test David Hildenbrand
2020-01-30 17:12 ` [kvm-unit-tests PULL 0/6] s390x updates Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200130131116.12386-6-david@redhat.com \
    --to=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.