All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: thuth@redhat.com, borntraeger@de.ibm.com,
	linux-s390@vger.kernel.org, david@redhat.com, cohuck@redhat.com
Subject: [kvm-unit-tests PATCH v5 4/7] s390x: Add cpu id to interrupt error prints
Date: Sat,  1 Feb 2020 10:28:48 -0500	[thread overview]
Message-ID: <20200201152851.82867-5-frankja@linux.ibm.com> (raw)
In-Reply-To: <20200201152851.82867-1-frankja@linux.ibm.com>

It's good to know which cpu broke the test.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
 lib/s390x/interrupt.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/lib/s390x/interrupt.c b/lib/s390x/interrupt.c
index ccb376a..3a40cac 100644
--- a/lib/s390x/interrupt.c
+++ b/lib/s390x/interrupt.c
@@ -109,8 +109,8 @@ void handle_pgm_int(void)
 	if (!pgm_int_expected) {
 		/* Force sclp_busy to false, otherwise we will loop forever */
 		sclp_handle_ext();
-		report_abort("Unexpected program interrupt: %d at %#lx, ilen %d\n",
-			     lc->pgm_int_code, lc->pgm_old_psw.addr,
+		report_abort("Unexpected program interrupt: %d on cpu %d at %#lx, ilen %d\n",
+			     lc->pgm_int_code, stap(), lc->pgm_old_psw.addr,
 			     lc->pgm_int_id);
 	}
 
@@ -122,8 +122,8 @@ void handle_ext_int(void)
 {
 	if (!ext_int_expected &&
 	    lc->ext_int_code != EXT_IRQ_SERVICE_SIG) {
-		report_abort("Unexpected external call interrupt (code %#x): at %#lx",
-			     lc->ext_int_code, lc->ext_old_psw.addr);
+		report_abort("Unexpected external call interrupt (code %#x): on cpu %d at %#lx",
+			     lc->ext_int_code, stap(), lc->ext_old_psw.addr);
 		return;
 	}
 
@@ -140,18 +140,18 @@ void handle_ext_int(void)
 
 void handle_mcck_int(void)
 {
-	report_abort("Unexpected machine check interrupt: at %#lx",
-		     lc->mcck_old_psw.addr);
+	report_abort("Unexpected machine check interrupt: on cpu %d at %#lx",
+		     stap(), lc->mcck_old_psw.addr);
 }
 
 void handle_io_int(void)
 {
-	report_abort("Unexpected io interrupt: at %#lx",
-		     lc->io_old_psw.addr);
+	report_abort("Unexpected io interrupt: on cpu %d at %#lx",
+		     stap(), lc->io_old_psw.addr);
 }
 
 void handle_svc_int(void)
 {
-	report_abort("Unexpected supervisor call interrupt: at %#lx",
-		     lc->svc_old_psw.addr);
+	report_abort("Unexpected supervisor call interrupt: on cpu %d at %#lx",
+		     stap(), lc->svc_old_psw.addr);
 }
-- 
2.20.1

  parent reply	other threads:[~2020-02-01 15:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01 15:28 [kvm-unit-tests PATCH v5 0/7] s390x: smp: Improve smp code and reset checks Janosch Frank
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 1/7] s390x: smp: Cleanup smp.c Janosch Frank
2020-02-03 11:04   ` Cornelia Huck
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 2/7] s390x: smp: Fix ecall and emcall report strings Janosch Frank
2020-02-01 18:53   ` Thomas Huth
2020-02-03 11:06   ` Cornelia Huck
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 3/7] s390x: Stop the cpu that is executing exit() Janosch Frank
2020-02-01 18:55   ` Thomas Huth
2020-02-03 11:19   ` Cornelia Huck
2020-02-01 15:28 ` Janosch Frank [this message]
2020-02-01 18:57   ` [kvm-unit-tests PATCH v5 4/7] s390x: Add cpu id to interrupt error prints Thomas Huth
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 5/7] s390x: smp: Only use smp_cpu_setup once Janosch Frank
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 6/7] s390x: smp: Rework cpu start and active tracking Janosch Frank
2020-02-01 19:03   ` Thomas Huth
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 7/7] s390x: smp: Wait for cpu setup to finish Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200201152851.82867-5-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.