From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-ppc@nongnu.org, Alexey Kardashevskiy <aik@ozlabs.ru>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH qemu v6 1/6] ppc: Start CPU in the default mode which is big-endian 32bit
Date: Mon, 3 Feb 2020 14:29:38 +1100 [thread overview]
Message-ID: <20200203032943.121178-2-aik@ozlabs.ru> (raw)
In-Reply-To: <20200203032943.121178-1-aik@ozlabs.ru>
At the moment we enforce 64bit mode on a CPU when reset. This does not
make difference as SLOF or Linux set the desired mode straight away.
However if we ever boot something other than these two,
this might not work as, for example, GRUB expects the default MSR state
and does not work properly.
This removes setting MSR_SF from the PPC CPU reset.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
target/ppc/translate_init.inc.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c
index 53995f62eab2..f6a676cf55e8 100644
--- a/target/ppc/translate_init.inc.c
+++ b/target/ppc/translate_init.inc.c
@@ -10710,12 +10710,6 @@ static void ppc_cpu_reset(CPUState *s)
#endif
#endif
-#if defined(TARGET_PPC64)
- if (env->mmu_model & POWERPC_MMU_64) {
- msr |= (1ULL << MSR_SF);
- }
-#endif
-
hreg_store_msr(env, msr, 1);
#if !defined(CONFIG_USER_ONLY)
--
2.17.1
next prev parent reply other threads:[~2020-02-03 3:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 3:29 [PATCH qemu v6 0/6] spapr: Kill SLOF Alexey Kardashevskiy
2020-02-03 3:29 ` Alexey Kardashevskiy [this message]
2020-02-12 5:43 ` [PATCH qemu v6 1/6] ppc: Start CPU in the default mode which is big-endian 32bit David Gibson
2020-02-13 3:09 ` Alexey Kardashevskiy
2020-02-13 3:34 ` David Gibson
2020-02-03 3:29 ` [PATCH qemu v6 2/6] ppc/spapr: Move GPRs setup to one place Alexey Kardashevskiy
2020-02-12 18:44 ` Fabiano Rosas
2020-02-13 8:41 ` Greg Kurz
2020-02-03 3:29 ` [PATCH qemu v6 3/6] spapr/spapr: Make vty_getchars public Alexey Kardashevskiy
2020-02-03 3:29 ` [PATCH qemu v6 4/6] spapr/cas: Separate CAS handling from rebuilding the FDT Alexey Kardashevskiy
2020-02-03 3:29 ` [PATCH qemu v6 5/6] spapr: Allow changing offset for -kernel image Alexey Kardashevskiy
2020-02-12 18:54 ` Fabiano Rosas
2020-02-13 2:58 ` David Gibson
2020-02-03 3:29 ` [PATCH qemu v6 6/6] spapr: Implement Open Firmware client interface Alexey Kardashevskiy
2020-02-03 13:03 ` BALATON Zoltan
2020-02-05 4:18 ` Alexey Kardashevskiy
2020-02-05 4:59 ` [PATCH qemu v6] spapr: OF CI networking Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203032943.121178-2-aik@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.