From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: [PATCH] kconfig: Invalidate all symbols after changing to y or m.
Date: Tue, 04 Feb 2020 13:08:44 +0900 [thread overview]
Message-ID: <202002040408.01448ioc013868@www262.sakura.ne.jp> (raw)
In-Reply-To: <CAK7LNATNY1oP5XgFH3+fuUU=Z7pEz7Sqz0vKCzvhM4Kem7RkOg@mail.gmail.com>
Since commit 89b9060987d98833 ("kconfig: Add yes2modconfig and
mod2yesconfig targets.") forgot to clear SYMBOL_VALID bit after
changing to y or m, these targets did not save the changes.
Call sym_clear_all_valid() so that all symbols are revalidated.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
scripts/kconfig/confdata.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 11f6c72c2eee..aa70360f27c1 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -1331,9 +1331,8 @@ void conf_rewrite_mod_or_yes(enum conf_def_mode mode)
for_all_symbols(i, sym) {
if (sym_get_type(sym) == S_TRISTATE &&
- sym->def[S_DEF_USER].tri == old_val) {
+ sym->def[S_DEF_USER].tri == old_val)
sym->def[S_DEF_USER].tri = new_val;
- sym_add_change_count(1);
- }
}
+ sym_clear_all_valid();
}
--
2.11.0
next prev parent reply other threads:[~2020-02-04 4:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 9:50 [PATCH] kconfig: Add yes2modconfig and mod2yesconfig targets Tetsuo Handa
2019-12-06 16:09 ` Randy Dunlap
2019-12-07 1:42 ` [PATCH v2] " Tetsuo Handa
2019-12-16 11:10 ` Masahiro Yamada
2019-12-16 12:58 ` Tetsuo Handa
2019-12-17 1:03 ` Masahiro Yamada
2019-12-17 9:42 ` [PATCH v3] " Tetsuo Handa
2019-12-18 14:11 ` Masahiro Yamada
2020-02-04 4:08 ` Tetsuo Handa [this message]
2020-02-05 4:42 ` [PATCH] kconfig: Invalidate all symbols after changing to y or m Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202002040408.01448ioc013868@www262.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=dvyukov@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.