From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 0/2] btrfs: qgroup: Fix deadlock where btrfs_qgroup_wait_for_completion() waits for never-queued work
Date: Fri, 7 Feb 2020 13:38:19 +0800 [thread overview]
Message-ID: <20200207053821.25643-1-wqu@suse.com> (raw)
There is a long existing report about btrfs hangs at unmount time,
waiting for qgroup.
Jeff has submitted a patch for that, but never merged.
https://patchwork.kernel.org/patch/10376585/
After re-digging the case, although Jeff's fix can solve the problem,
the racy cause doesn't look correct to me.
After all, close_ctree() wait for qgroup rescan before destroying
related work queues. Thus as long as the work is queued, we can finish
the wait without problem.
Further digging into the bug, it looks like the deadlock is possible,
and Jeff is right about the wait-for-never-queued-work part.
But the racy part doesn't look possible, thus it should only happen
when something wrong happened.
Now with a proper cause analyse, we can craft a much smaller thus better
fix (anyway I'm the guy to backport, smaller is always better).
Changelog:
v2:
- Change the subject
It's not about race. I got confused by the initial patch.
- Change the cause analyse
No need for any race. Also add analyse for all qgroup_rescan_init()
callers to ensure no missing fixes.
BTW, qgroup_rescan_init() uses BTRFS_QGROUP_STATUS_FLAG_RESCAN flag to
determine if there is a conflicting rescan, thus it's not affected by
the timing change.
- Split the spinlock cleanup into another patch
Qu Wenruo (2):
btrfs: qgroup: Ensure qgroup_rescan_running is only set when the
worker is at least queued
btrfs: qgroup: Remove the unnecesaary spin lock for
qgroup_rescan_running|queued
fs/btrfs/qgroup.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
--
2.25.0
next reply other threads:[~2020-02-07 5:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 5:38 Qu Wenruo [this message]
2020-02-07 5:38 ` [PATCH v2 1/2] btrfs: qgroup: Ensure qgroup_rescan_running is only set when the worker is at least queued Qu Wenruo
2020-02-07 5:38 ` [PATCH v2 2/2] btrfs: qgroup: Remove the unnecesaary spin lock for qgroup_rescan_running|queued Qu Wenruo
2020-02-24 16:45 ` David Sterba
2020-02-24 23:44 ` Qu Wenruo
2020-02-25 16:49 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207053821.25643-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.